From: Isaila Alexandru <aisaila@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>, george.dunlap@citrix.com
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
tamas@tklengyel.com, Razvan Cojocaru <rcojocaru@bitdefender.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v4] x86/mm: Add mem access rights to NPT
Date: Thu, 09 Aug 2018 15:14:45 +0300 [thread overview]
Message-ID: <1533816885.10950.1.camel@bitdefender.com> (raw)
In-Reply-To: <5B5852F402000078001D79E9@prv1-mh.provo.novell.com>
On Mi, 2018-07-25 at 04:37 -0600, Jan Beulich wrote:
> >
> > >
> > > >
> > > > On 25.07.18 at 11:25, <george.dunlap@citrix.com> wrote:
> > On 07/24/2018 01:02 PM, Jan Beulich wrote:
> > >
> > > >
> > > > >
> > > > > >
> > > > > > On 24.07.18 at 13:26, <george.dunlap@citrix.com> wrote:
> > > > On 07/24/2018 09:55 AM, Jan Beulich wrote:
> > > > >
> > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > > On 23.07.18 at 15:48, <aisaila@bitdefender.com> wrote:
> > > > > > + {
> > > > > > + xfree(d->arch.monitor.msr_bitmap);
> > > > > > + return -ENOMEM;
> > > > > > + }
> > > > > > + radix_tree_init(p2m->mem_access_settings);
> > > > > > + }
> > > > > What's the SVM connection here? Please don't forget that p2m-
> > > > > pt.c
> > > > > also serves the shadow case. Perhaps struct p2m_domain should
> > > > > contain a boolean indicator whether this auxiliary data
> > > > > structure is
> > > > > needed?
> > > > It's basically just "hap_enabled()" isn't it?
> > > Only if we can't make it there when EPT is active.
> > It can make it here when VMX is active and shadow is enabled, but
> > it
> > shouldn't be able to get here when EPT is active. We could add an
> > ASSERT() to that effect; it should be safe in production, as the
> > only
> > side effect should be that we do a small pointless allocation.
> So I've looked a little more closely: This is being added to
> arch_monitor_init_domain(), called from vm_event_domctl(). I can't
> see why this wouldn't be reachable with EPT enabled.
>
Hi George,
Any thoughts on this?
Thanks,
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-08-09 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 13:48 [PATCH v4] x86/mm: Add mem access rights to NPT Alexandru Isaila
2018-07-24 8:55 ` Jan Beulich
2018-07-24 9:28 ` Razvan Cojocaru
2018-07-24 9:33 ` Jan Beulich
2018-07-24 11:26 ` George Dunlap
2018-07-24 12:02 ` Jan Beulich
2018-07-25 9:25 ` George Dunlap
2018-07-25 10:37 ` Jan Beulich
2018-08-09 12:14 ` Isaila Alexandru [this message]
2018-09-26 8:17 ` Isaila Alexandru
2018-09-26 13:13 ` George Dunlap
2018-07-25 8:29 ` Isaila Alexandru
2018-07-25 9:14 ` Jan Beulich
2018-07-25 9:28 ` Isaila Alexandru
2018-09-26 16:02 ` George Dunlap
2018-09-26 16:02 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533816885.10950.1.camel@bitdefender.com \
--to=aisaila@bitdefender.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=rcojocaru@bitdefender.com \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.