From: Sergey Shtylyov <s.shtylyov@omprussia.ru>
To: "David S. Miller" <davem@davemloft.net>, <linux-ide@vger.kernel.org>
Subject: [PATCH 2/2] tx4939ide: fix deferred probing
Date: Fri, 23 Apr 2021 23:42:34 +0300 [thread overview]
Message-ID: <153446a9-a5a9-1ce5-b224-6e0d5dd14eff@omprussia.ru> (raw)
In-Reply-To: <35757c7b-d25f-5ef6-0088-5b0fb568a0de@omprussia.ru>
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream.
Fixes: 37897989232e ("ide: Add tx4939ide driver (v6)")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/ide/tx4939ide.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ide/drivers/ide/tx4939ide.c
===================================================================
--- ide.orig/drivers/ide/tx4939ide.c
+++ ide/drivers/ide/tx4939ide.c
@@ -543,7 +543,7 @@ static int __init tx4939ide_probe(struct
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return -ENODEV;
+ return irq;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENODEV;
prev parent reply other threads:[~2021-04-23 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 20:40 [PATCH 0/2] Fix deferred probing for the Toshiba TX493x IDE drivers Sergey Shtylyov
2021-04-23 20:41 ` [PATCH 1/2] tx4938ide: fix deferred probing Sergey Shtylyov
2021-04-23 20:42 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153446a9-a5a9-1ce5-b224-6e0d5dd14eff@omprussia.ru \
--to=s.shtylyov@omprussia.ru \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.