From: Anton Nefedov <anton.nefedov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com, mreitz@redhat.com,
armbru@redhat.com, jsnow@redhat.com, pbonzini@redhat.com,
famz@redhat.com, eblake@redhat.com, den@virtuozzo.com,
berto@igalia.com, Anton Nefedov <anton.nefedov@virtuozzo.com>
Subject: [Qemu-devel] [PATCH v4 0/8] discard blockstats
Date: Tue, 21 Aug 2018 12:46:11 +0300 [thread overview]
Message-ID: <1534844779-118784-1-git-send-email-anton.nefedov@virtuozzo.com> (raw)
new in v4:
- patch 7: discard and write-zeroes code paths had been separated in
34fa110e: file-posix: Fix write_zeroes with unmap on block devices.
This patch now only accounts discards that come explicitly
through .bdrv_co_pdiscard handler.
- qapi 'Since' clauses changed 3.0 -> 3.1
v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg03688.html
----
qmp query-blockstats provides stats info for write/read/flush ops.
Patches 1-6 implement the similar for discard (unmap) command for scsi
and ide disks.
Discard stat "unmap_ops / unmap_bytes" is supposed to account the ops that
have completed without an error.
However, discard operation is advisory. Specifically,
- common block layer ignores ENOTSUP error code.
That might be returned if the block driver does not support discard,
or discard has been configured to be ignored.
- format drivers such as qcow2 may ignore discard if they were configured
to ignore that, or if the corresponding area is already marked unused
(unallocated / zero clusters).
And what is actually useful is the number of bytes actually discarded
down on the host filesystem.
To achieve that, driver-specific statistics has been added to blockstats
(patch 8).
With patch 7, file-posix driver accounts discard operations on its level too.
query-blockstat result:
(note the difference between blockdevice unmap and file discard stats. qcow2
sends fewer ops down to the file as the clusters are actually unallocated
on qcow2 level)
{
"return": [
{
"device": "drive-scsi0-0-0-0",
"parent": {
> "discard-bytes-ok": 262144,
> "discard-nb-ok": 4,
"stats": {
> "unmap_operations": 0,
> "unmap_merged": 0,
"flush_total_time_ns": 0,
"wr_highest_offset": 8111718400,
"wr_total_time_ns": 0,
"failed_wr_operations": 0,
"failed_rd_operations": 0,
"wr_merged": 0,
"wr_bytes": 0,
"timed_stats": [
],
> "failed_unmap_operations": 0,
"failed_flush_operations": 0,
"account_invalid": false,
"rd_total_time_ns": 0,
> "invalid_unmap_operations": 0,
"flush_operations": 0,
"wr_operations": 0,
> "unmap_bytes": 0,
"rd_merged": 0,
"rd_bytes": 0,
> "unmap_total_time_ns": 0,
"invalid_flush_operations": 0,
"account_failed": false,
"rd_operations": 0,
"invalid_wr_operations": 0,
"invalid_rd_operations": 0
},
"node-name": "#block012",
> "driver": "file",
> "discard-nb-failed": 0
},
"stats": {
> "unmap_operations": 860,
> "unmap_merged": 0,
"flush_total_time_ns": 21506733,
"wr_highest_offset": 13411741696,
"wr_total_time_ns": 2212749334,
"failed_wr_operations": 0,
"failed_rd_operations": 0,
"wr_merged": 0,
"wr_bytes": 3426304,
"timed_stats": [
],
> "failed_unmap_operations": 0,
"failed_flush_operations": 0,
"account_invalid": true,
"rd_total_time_ns": 3617478206,
> "invalid_unmap_operations": 0,
"flush_operations": 24,
"wr_operations": 309,
> "unmap_bytes": 11949633536,
"rd_merged": 0,
"rd_bytes": 141967360,
> "unmap_total_time_ns": 14871816,
[..]
Anton Nefedov (8):
qapi: group BlockDeviceStats fields
qapi: add unmap to BlockDeviceStats
ide: account UNMAP (TRIM) operations
scsi: store unmap offset and nb_sectors in request struct
scsi: move unmap error checking to the complete callback
scsi: account unmap operations
file-posix: account discard operations
qapi: query-blockstat: add driver specific file-posix stats
qapi/block-core.json | 82 +++++++++++++++++++++++++++++++++++++++-------
include/block/accounting.h | 1 +
include/block/block.h | 1 +
include/block/block_int.h | 1 +
block.c | 9 +++++
block/file-posix.c | 45 +++++++++++++++++++++++--
block/qapi.c | 11 +++++++
hw/ide/core.c | 12 +++++++
hw/scsi/scsi-disk.c | 29 +++++++++-------
tests/qemu-iotests/227.out | 18 ++++++++++
10 files changed, 184 insertions(+), 25 deletions(-)
--
2.7.4
next reply other threads:[~2018-08-21 9:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 9:46 Anton Nefedov [this message]
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 1/8] qapi: group BlockDeviceStats fields Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 2/8] qapi: add unmap to BlockDeviceStats Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 3/8] ide: account UNMAP (TRIM) operations Anton Nefedov
2018-10-04 15:33 ` Kevin Wolf
2018-10-08 14:38 ` Anton Nefedov
2018-10-08 15:03 ` Kevin Wolf
2018-10-08 15:25 ` Anton Nefedov
2018-10-08 15:46 ` Kevin Wolf
2018-10-08 16:04 ` Anton Nefedov
2018-10-08 16:43 ` Kevin Wolf
2018-10-17 15:32 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 4/8] scsi: store unmap offset and nb_sectors in request struct Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 5/8] scsi: move unmap error checking to the complete callback Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 6/8] scsi: account unmap operations Anton Nefedov
2018-10-04 15:47 ` Kevin Wolf
2018-10-08 14:43 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 7/8] file-posix: account discard operations Anton Nefedov
2018-10-04 15:52 ` Kevin Wolf
2018-10-08 13:47 ` Anton Nefedov
2018-08-21 9:46 ` [Qemu-devel] [PATCH v4 8/8] qapi: query-blockstat: add driver specific file-posix stats Anton Nefedov
[not found] ` <6d0b2d5b-f0a4-b62c-3dc4-e8d92eeb76b2@virtuozzo.com>
2018-10-04 14:04 ` [Qemu-devel] [PATCH v4 0/8] discard blockstats Anton Nefedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534844779-118784-1-git-send-email-anton.nefedov@virtuozzo.com \
--to=anton.nefedov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.