From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37521 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732016AbeHWSmg (ORCPT ); Thu, 23 Aug 2018 14:42:36 -0400 From: Jacopo Mondi To: Laurent Pinchart , David Airlie Cc: Jacopo Mondi , ulrich.hecht+renesas@gmail.com, kieran.bingham@ideasonboard.com, dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR RENESAS), linux-renesas-soc@vger.kernel.org (open list:DRM DRIVERS FOR RENESAS) Subject: [PATCH 2/4] drm: rcar-du: Write OTAR for DPAD channels only Date: Thu, 23 Aug 2018 17:12:12 +0200 Message-Id: <1535037134-373-3-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: <1535037134-373-1-git-send-email-jacopo+renesas@jmondi.org> References: <1535037134-373-1-git-send-email-jacopo+renesas@jmondi.org> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: According to revision 1.00 of R-Car Gen3 SoC manual, writing to OTAR register is valid only if the channel is equipped with a digital output pad (DPAD). Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 7b1c05b..9ba5551 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c @@ -315,7 +315,10 @@ static void rcar_du_crtc_set_display_timing(struct rcar_du_crtc *rcrtc) params.escr); } - rcar_du_crtc_write(rcrtc, rcrtc->index % 2 ? OTAR13 : OTAR02, 0); + if (rcrtc->index & + rcdu->info->routes[RCAR_DU_OUTPUT_DPAD0].possible_crtcs) + rcar_du_crtc_write(rcrtc, rcrtc->index % 2 ? OTAR13 : OTAR02, + 0); /* Signal polarities */ dsmr = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? DSMR_VSL : 0) -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacopo Mondi Subject: [PATCH 2/4] drm: rcar-du: Write OTAR for DPAD channels only Date: Thu, 23 Aug 2018 17:12:12 +0200 Message-ID: <1535037134-373-3-git-send-email-jacopo+renesas@jmondi.org> References: <1535037134-373-1-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2F8B89971 for ; Thu, 23 Aug 2018 15:12:31 +0000 (UTC) In-Reply-To: <1535037134-373-1-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , David Airlie Cc: ulrich.hecht+renesas@gmail.com, "open list:DRM DRIVERS FOR RENESAS" , Jacopo Mondi , kieran.bingham@ideasonboard.com, "open list:DRM DRIVERS FOR RENESAS" List-Id: dri-devel@lists.freedesktop.org QWNjb3JkaW5nIHRvIHJldmlzaW9uIDEuMDAgb2YgUi1DYXIgR2VuMyBTb0MgbWFudWFsLCB3cml0 aW5nIHRvIE9UQVIKcmVnaXN0ZXIgaXMgdmFsaWQgb25seSBpZiB0aGUgY2hhbm5lbCBpcyBlcXVp cHBlZCB3aXRoIGEgZGlnaXRhbCBvdXRwdXQKcGFkIChEUEFEKS4KClNpZ25lZC1vZmYtYnk6IEph Y29wbyBNb25kaSA8amFjb3BvK3JlbmVzYXNAam1vbmRpLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9k cm0vcmNhci1kdS9yY2FyX2R1X2NydGMuYyB8IDUgKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCA0IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf Y3J0Yy5jCmluZGV4IDdiMWMwNWIuLjliYTU1NTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfY3J0Yy5jCkBAIC0zMTUsNyArMzE1LDEwIEBAIHN0YXRpYyB2b2lkIHJjYXJfZHVfY3J0 Y19zZXRfZGlzcGxheV90aW1pbmcoc3RydWN0IHJjYXJfZHVfY3J0YyAqcmNydGMpCiAJCQkJICAg cGFyYW1zLmVzY3IpOwogCX0KIAotCXJjYXJfZHVfY3J0Y193cml0ZShyY3J0YywgcmNydGMtPmlu ZGV4ICUgMiA/IE9UQVIxMyA6IE9UQVIwMiwgMCk7CisJaWYgKHJjcnRjLT5pbmRleCAmCisJICAg IHJjZHUtPmluZm8tPnJvdXRlc1tSQ0FSX0RVX09VVFBVVF9EUEFEMF0ucG9zc2libGVfY3J0Y3Mp CisJCXJjYXJfZHVfY3J0Y193cml0ZShyY3J0YywgcmNydGMtPmluZGV4ICUgMiA/IE9UQVIxMyA6 IE9UQVIwMiwKKwkJCQkgICAwKTsKIAogCS8qIFNpZ25hbCBwb2xhcml0aWVzICovCiAJZHNtciA9 ICgobW9kZS0+ZmxhZ3MgJiBEUk1fTU9ERV9GTEFHX1BWU1lOQykgPyBEU01SX1ZTTCA6IDApCi0t IAoyLjcuNAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==