From: Dharmik Thakkar <dharmik.thakkar@arm.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, honnappa.nagarahalli@arm.com,
Dharmik Thakkar <dharmik.thakkar@arm.com>
Subject: [PATCH] test/hash: solve unit test hash compilation error
Date: Mon, 27 Aug 2018 09:26:09 -0500 [thread overview]
Message-ID: <1535379969-19642-1-git-send-email-dharmik.thakkar@arm.com> (raw)
Enable print_key_info() function compilation always.
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
test/test/test_hash.c | 24 +++++++++---------------
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/test/test/test_hash.c b/test/test/test_hash.c
index b3db9fd..13239e1 100644
--- a/test/test/test_hash.c
+++ b/test/test/test_hash.c
@@ -80,29 +80,23 @@ static uint32_t pseudo_hash(__attribute__((unused)) const void *keys,
return 3;
}
+#define UNIT_TEST_HASH_VERBOSE 0
/*
* Print out result of unit test hash operation.
*/
-#if defined(UNIT_TEST_HASH_VERBOSE)
static void print_key_info(const char *msg, const struct flow_key *key,
int32_t pos)
{
- uint8_t *p = (uint8_t *)key;
- unsigned i;
-
- printf("%s key:0x", msg);
- for (i = 0; i < sizeof(struct flow_key); i++) {
- printf("%02X", p[i]);
+ if (UNIT_TEST_HASH_VERBOSE) {
+ const uint8_t *p = (const uint8_t *)key;
+ unsigned i;
+
+ printf("%s key:0x", msg);
+ for (i = 0; i < sizeof(struct flow_key); i++)
+ printf("%02X", p[i]);
+ printf(" @ pos %d\n", pos);
}
- printf(" @ pos %d\n", pos);
-}
-#else
-static void print_key_info(__attribute__((unused)) const char *msg,
- __attribute__((unused)) const struct flow_key *key,
- __attribute__((unused)) int32_t pos)
-{
}
-#endif
/* Keys used by unit test functions */
static struct flow_key keys[5] = { {
--
2.7.4
next reply other threads:[~2018-08-27 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 14:26 Dharmik Thakkar [this message]
2018-08-27 14:41 ` [PATCH] test/hash: solve unit test hash compilation error Gavin Hu
2018-09-16 9:59 ` Thomas Monjalon
2018-09-18 19:22 ` [PATCH v2] " Dharmik Thakkar
2018-10-01 20:04 ` Honnappa Nagarahalli
2018-10-26 20:24 ` [dpdk-stable] " Thomas Monjalon
2018-10-26 21:05 ` Wang, Yipeng1
2018-10-26 21:55 ` Dharmik Thakkar
2018-10-26 21:59 ` Thomas Monjalon
2018-10-29 4:16 ` Honnappa Nagarahalli
2018-10-29 4:24 ` Thomas Monjalon
2018-10-29 4:54 ` Honnappa Nagarahalli
2018-10-26 21:09 ` Dharmik Thakkar
2018-10-26 21:43 ` [PATCH v3] " Dharmik Thakkar
2018-11-06 2:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535379969-19642-1-git-send-email-dharmik.thakkar@arm.com \
--to=dharmik.thakkar@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.