* [PATCH] xen/arm: fix SMMU driver build
@ 2018-08-28 23:47 Stefano Stabellini
2018-08-29 17:48 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Stabellini @ 2018-08-28 23:47 UTC (permalink / raw)
To: julien.grall; +Cc: Stefano Stabellini, sstabellini, xen-devel
Add missing "CONFIG_"
Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
---
xen/drivers/passthrough/arm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/drivers/passthrough/arm/Makefile b/xen/drivers/passthrough/arm/Makefile
index 0156431..b3efcfd 100644
--- a/xen/drivers/passthrough/arm/Makefile
+++ b/xen/drivers/passthrough/arm/Makefile
@@ -1,2 +1,2 @@
obj-y += iommu.o
-obj-$(ARM_SMMU) += smmu.o
+obj-$(CONFIG_ARM_SMMU) += smmu.o
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/arm: fix SMMU driver build
2018-08-28 23:47 [PATCH] xen/arm: fix SMMU driver build Stefano Stabellini
@ 2018-08-29 17:48 ` Julien Grall
2018-08-29 21:36 ` Stefano Stabellini
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2018-08-29 17:48 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Stefano Stabellini, xen-devel
Hi Stefano,
On 08/29/2018 12:47 AM, Stefano Stabellini wrote:
> Add missing "CONFIG_"
I would add the commit id where the bug was introduced.
I will commit and add in the commit message:
This build failure was introduced by commit 277aa3523d "arm: make it
possible to disable the SMMU driver".
>
> Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> ---
> xen/drivers/passthrough/arm/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/drivers/passthrough/arm/Makefile b/xen/drivers/passthrough/arm/Makefile
> index 0156431..b3efcfd 100644
> --- a/xen/drivers/passthrough/arm/Makefile
> +++ b/xen/drivers/passthrough/arm/Makefile
> @@ -1,2 +1,2 @@
> obj-y += iommu.o
> -obj-$(ARM_SMMU) += smmu.o
> +obj-$(CONFIG_ARM_SMMU) += smmu.o
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen/arm: fix SMMU driver build
2018-08-29 17:48 ` Julien Grall
@ 2018-08-29 21:36 ` Stefano Stabellini
0 siblings, 0 replies; 3+ messages in thread
From: Stefano Stabellini @ 2018-08-29 21:36 UTC (permalink / raw)
To: Julien Grall; +Cc: Stefano Stabellini, Stefano Stabellini, xen-devel
On Wed, 29 Aug 2018, Julien Grall wrote:
> Hi Stefano,
>
> On 08/29/2018 12:47 AM, Stefano Stabellini wrote:
> > Add missing "CONFIG_"
>
> I would add the commit id where the bug was introduced.
>
> I will commit and add in the commit message:
>
> This build failure was introduced by commit 277aa3523d "arm: make it possible
> to disable the SMMU driver".
Thank you!
> >
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > ---
> > xen/drivers/passthrough/arm/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/xen/drivers/passthrough/arm/Makefile
> > b/xen/drivers/passthrough/arm/Makefile
> > index 0156431..b3efcfd 100644
> > --- a/xen/drivers/passthrough/arm/Makefile
> > +++ b/xen/drivers/passthrough/arm/Makefile
> > @@ -1,2 +1,2 @@
> > obj-y += iommu.o
> > -obj-$(ARM_SMMU) += smmu.o
> > +obj-$(CONFIG_ARM_SMMU) += smmu.o
> >
>
> --
> Julien Grall
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-29 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 23:47 [PATCH] xen/arm: fix SMMU driver build Stefano Stabellini
2018-08-29 17:48 ` Julien Grall
2018-08-29 21:36 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.