[v3,3/6] usb: chipidea: Prevent unbalanced IRQ disable

* [v3,3/6] usb: chipidea: Prevent unbalanced IRQ disable
@ 2018-09-04 15:18 Loic Poulain
  0 siblings, 0 replies; only message in thread
From: Loic Poulain @ 2018-09-04 15:18 UTC (permalink / raw)
  To: Peter.Chen
  Cc: linux-usb, linux-arm-msm, david.brown, robh+dt, bjorn.andersson,
	andy.gross, andy.shevchenko, Loic Poulain

The ChipIdea IRQ is disabled before scheduling the otg work and
re-enabled on otg work completion. However if the job is already
scheduled we have to undo the effect of disable_irq int order to
balance the IRQ disable-depth value.

Fixes: be6b0c1bd0be ("usb: chipidea: using one inline function to cover queue work operations")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
 v2: v3: no change

 drivers/usb/chipidea/otg.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/otg.h b/drivers/usb/chipidea/otg.h
index 7e7428e..4f8b817 100644
--- a/drivers/usb/chipidea/otg.h
+++ b/drivers/usb/chipidea/otg.h
@@ -17,7 +17,8 @@ void ci_handle_vbus_change(struct ci_hdrc *ci);
 static inline void ci_otg_queue_work(struct ci_hdrc *ci)
 {
 	disable_irq_nosync(ci->irq);
-	queue_work(ci->wq, &ci->work);
+	if (queue_work(ci->wq, &ci->work) == false)
+		enable_irq(ci->irq);
 }
 
 #endif /* __DRIVERS_USB_CHIPIDEA_OTG_H */

^ permalink raw reply related	[flat|nested] only message in thread