From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 04/13] drm/i915: Rename the plane_state->main/aux to plane_state->color_plane[]
Date: Fri, 07 Sep 2018 16:30:36 +0100 [thread overview]
Message-ID: <153633423676.24592.13578453916542845074@skylake-alporthouse-com> (raw)
In-Reply-To: <20180907152413.15761-5-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2018-09-07 16:24:04)
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 8162025114f5..9e16bdcffc84 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -504,11 +504,7 @@ struct intel_plane_state {
> struct {
> u32 offset;
> int x, y;
> - } main;
> - struct {
> - u32 offset;
> - int x, y;
> - } aux;
> + } color_plane[2];
Is (main, aux) significant to keep around as an enum?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-07 15:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 15:24 [PATCH 00/13] drm/i915: Display gtt remapping prep stuff Ville Syrjala
2018-09-07 15:24 ` [PATCH 01/13] drm/i915: s/tile_offset/aligned_offset/ etc Ville Syrjala
2018-09-07 15:24 ` [PATCH 02/13] drm/i915: Add .max_stride() plane hook Ville Syrjala
2018-09-07 15:24 ` [PATCH 03/13] drm/i915: Use pipe A primary plane .max_stride() as the global stride limit Ville Syrjala
2018-09-07 15:24 ` [PATCH 04/13] drm/i915: Rename the plane_state->main/aux to plane_state->color_plane[] Ville Syrjala
2018-09-07 15:30 ` Chris Wilson [this message]
2018-09-07 15:54 ` Ville Syrjälä
2018-09-07 15:24 ` [PATCH 05/13] drm/i915: Store the final plane stride in plane_state Ville Syrjala
2018-09-11 15:01 ` [PATCH v4 " Ville Syrjala
2018-09-07 15:24 ` [PATCH 06/13] drm/i915: Store ggtt_view " Ville Syrjala
2018-09-07 15:24 ` [PATCH 07/13] drm/i915: s/int plane/int color_plane/ Ville Syrjala
2018-09-07 15:24 ` [PATCH 08/13] drm/i915: Nuke plane->can_scale/min_downscale Ville Syrjala
2018-09-07 15:24 ` [PATCH 09/13] drm/i915: Extract per-platform plane->check() functions Ville Syrjala
2018-09-07 15:24 ` [PATCH 10/13] drm/i915: Move skl plane fb related checks into a better place Ville Syrjala
2018-09-07 15:24 ` [PATCH 11/13] drm/i915: Move display w/a #1175 Ville Syrjala
2018-09-07 15:24 ` [PATCH 12/13] drm/i915: Move chv rotation checks to plane->check() Ville Syrjala
2018-09-07 15:24 ` [PATCH 13/13] drm/i915: Extract intel_cursor_check_surface() Ville Syrjala
2018-09-07 16:08 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display gtt remapping prep stuff Patchwork
2018-09-07 16:13 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-09-07 16:25 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-07 18:00 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-11 16:40 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Display gtt remapping prep stuff (rev2) Patchwork
2018-09-11 16:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-09-11 16:58 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-11 20:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-12 15:13 ` [PATCH 00/13] drm/i915: Display gtt remapping prep stuff Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153633423676.24592.13578453916542845074@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.