From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 1/4] mk: use script to generate examples.dox
Date: Fri, 07 Sep 2018 17:56:37 +0100
Message-ID: <1536339397.12545.18.camel@debian.org>
References: <20180831182055.30772-1-bluca@debian.org>
 <20180831182055.30772-2-bluca@debian.org> <1746678.vtfpdfx8nV@xps>
 <1535965627.11823.37.camel@debian.org>
 <20180907161322.GA24984@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 john.mcnamara@intel.com, marko.kovacevic@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com
 [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id BAF494F9B
 for <dev@dpdk.org>; Fri,  7 Sep 2018 18:56:38 +0200 (CEST)
Received: by mail-wr1-f68.google.com with SMTP id a108-v6so15594247wrc.13
 for <dev@dpdk.org>; Fri, 07 Sep 2018 09:56:38 -0700 (PDT)
In-Reply-To: <20180907161322.GA24984@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2018-09-07 at 17:13 +0100, Bruce Richardson wrote:
> On Mon, Sep 03, 2018 at 10:07:07AM +0100, Luca Boccassi wrote:
> > On Mon, 2018-09-03 at 02:54 +0200, Thomas Monjalon wrote:
> > > 31/08/2018 20:20, Luca Boccassi:
> > > > +# SC2129 - avoid multiple individual redirects
> > >=20
> > > What is SC2129 ?
> >=20
> > shellcheck - will clarify in v2
> >=20
> > > > +{ \
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '/**\n'; \
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '@page examples DPDK Example Progra=
ms\n\n'; \
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0find "${EXAMPLES_DIR}" -type f -name '*.c'=
 -printf '@examp
> > > > le
> > > > examples/%P\n' | LC_ALL=3DC sort; \
> > > > +=C2=A0=C2=A0=C2=A0=C2=A0printf '*/\n'; \
> > > > +} > "${API_EXAMPLES}"
> > >=20
> > > Why using backslashes (continuation lines)?
> >=20
> > Good point, will remove in v2
> >=20
>=20
> Agree, rather than using continuation lines, I suggest one of the
> following:
> * use exec > ${API_EXAMPLES} at the top of the script
> * let the script just print to stdout and have make/meson put that in
> the
> =C2=A0 output file for you.
>=20
> /Bruce

exec > works and checkbashism is also happy with it, so used that in v2

--=20
Kind regards,
Luca Boccassi