* dma: idma64: replace spin_lock_irqsave with spin_lock
@ 2018-09-07 19:02 ` Zhaoxiong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Zhaoxiong Yuan @ 2018-09-07 19:02 UTC (permalink / raw)
To: dan.j.williams, vkoul; +Cc: dmaengine, linux-kernel, Zhaoxiong Yuan
idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary
to call spin_lock_irqsave.
Signed-off-by: Zhaoxiong Yuan <yuanzhx326@gmail.com>
---
drivers/dma/idma64.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index 1fbf9cb..5b9c156 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -142,9 +142,8 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
{
struct idma64_chan *idma64c = &idma64->chan[c];
struct idma64_desc *desc;
- unsigned long flags;
- spin_lock_irqsave(&idma64c->vchan.lock, flags);
+ spin_lock(&idma64c->vchan.lock);
desc = idma64c->desc;
if (desc) {
if (status_err & (1 << c)) {
@@ -161,7 +160,7 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
if (idma64c->desc == NULL || desc->status == DMA_ERROR)
idma64_stop_transfer(idma64c);
}
- spin_unlock_irqrestore(&idma64c->vchan.lock, flags);
+ spin_unlock(&idma64c->vchan.lock);
}
static irqreturn_t idma64_irq(int irq, void *dev)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock
@ 2018-09-07 19:02 ` Zhaoxiong Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Zhaoxiong Yuan @ 2018-09-07 19:02 UTC (permalink / raw)
To: dan.j.williams, vkoul; +Cc: dmaengine, linux-kernel, Zhaoxiong Yuan
idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary
to call spin_lock_irqsave.
Signed-off-by: Zhaoxiong Yuan <yuanzhx326@gmail.com>
---
drivers/dma/idma64.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index 1fbf9cb..5b9c156 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -142,9 +142,8 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
{
struct idma64_chan *idma64c = &idma64->chan[c];
struct idma64_desc *desc;
- unsigned long flags;
- spin_lock_irqsave(&idma64c->vchan.lock, flags);
+ spin_lock(&idma64c->vchan.lock);
desc = idma64c->desc;
if (desc) {
if (status_err & (1 << c)) {
@@ -161,7 +160,7 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
if (idma64c->desc == NULL || desc->status == DMA_ERROR)
idma64_stop_transfer(idma64c);
}
- spin_unlock_irqrestore(&idma64c->vchan.lock, flags);
+ spin_unlock(&idma64c->vchan.lock);
}
static irqreturn_t idma64_irq(int irq, void *dev)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* dma: idma64: replace spin_lock_irqsave with spin_lock
2018-09-07 19:02 ` [PATCH] " Zhaoxiong Yuan
@ 2018-09-11 7:44 ` Vinod
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2018-09-11 7:44 UTC (permalink / raw)
To: Zhaoxiong Yuan; +Cc: dan.j.williams, dmaengine, linux-kernel
On 08-09-18, 06:02, Zhaoxiong Yuan wrote:
> idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary
> to call spin_lock_irqsave.
Please add a line after log and s-o-b
I have applied after doing above and fixing subsystem tag (dmaengine)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock
@ 2018-09-11 7:44 ` Vinod
0 siblings, 0 replies; 4+ messages in thread
From: Vinod @ 2018-09-11 7:44 UTC (permalink / raw)
To: Zhaoxiong Yuan; +Cc: dan.j.williams, dmaengine, linux-kernel
On 08-09-18, 06:02, Zhaoxiong Yuan wrote:
> idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary
> to call spin_lock_irqsave.
Please add a line after log and s-o-b
I have applied after doing above and fixing subsystem tag (dmaengine)
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-11 7:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 19:02 dma: idma64: replace spin_lock_irqsave with spin_lock Zhaoxiong Yuan
2018-09-07 19:02 ` [PATCH] " Zhaoxiong Yuan
2018-09-11 7:44 Vinod Koul
2018-09-11 7:44 ` [PATCH] " Vinod
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.