From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 06/24] drm/omap: Allocate drm_device earlier and unref it as last step Date: Tue, 27 Feb 2018 15:07:11 +0200 Message-ID: <15364928.EofS2yUN4y@avalon> References: <1518428694-18018-1-git-send-email-tomi.valkeinen@ti.com> <1518428694-18018-7-git-send-email-tomi.valkeinen@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B67C6E65E for ; Tue, 27 Feb 2018 13:06:23 +0000 (UTC) In-Reply-To: <1518428694-18018-7-git-send-email-tomi.valkeinen@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: Peter Ujfalusi , Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gTW9uZGF5LCAxMiBGZWJydWFy eSAyMDE4IDExOjQ0OjM2IEVFVCBUb21pIFZhbGtlaW5lbiB3cm90ZToKPiBGcm9tOiBQZXRlciBV amZhbHVzaSA8cGV0ZXIudWpmYWx1c2lAdGkuY29tPgo+IAo+IElmIHdlIGFsbG9jYXRlIHRoZSBk cm1fZGV2aWNlIGVhcmxpZXIgd2UgY2FuIGp1c3QgcmV0dXJuIHRoZSBlcnJvciBjb2RlCj4gd2l0 aG91dCB0aGUgbmVlZCB0byB1c2UgZ290by4KPiBEbyB0aGUgdW5yZWYgb2YgdGhlIGRybV9kZXZp Y2UgYXMgYSBsYXN0IHN0ZXAgd2hlbiBjbGVhbmluZyB1cC4gVGhpcyB3aWxsCj4gbWFrZSB0aGUg ZHJtX2RldmljZSBhdmFpbGFibGUgbG9uZ2VyIGZvciB1cyBhbmQgbWFrZXMgc3VyZSB0aGF0IHdl IG9ubHkKPiBmcmVlIHVwIHRoZSBtZW1vcnkgd2hlbiBhbGwgb3RoZXIgY2xlYW51cHMgaGF2ZSBi ZWVuIGFscmVhZHkgZG9uZS4KCkhvdyBhYm91dCBtYWtpbmcgaXQgZXZlbiBzaW1wbGVyIGJ5IGVt YmVkZGluZyBkcm1fZGV2aWNlIGluc2lkZSAKb21hcF9kcm1fcHJpdmF0ZSA/Cgo+IFNpZ25lZC1v ZmYtYnk6IFBldGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+Cj4gUmV2aWV3ZWQt Ynk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIHwgMjkgKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRy bS9vbWFwX2Rydi5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIGluZGV4 IDNjZDkxODhhYjMwYi4uNTdkMTFmOWFlZWFkCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL29tYXBkcm0vb21hcF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29t YXBfZHJ2LmMKPiBAQCAtNTMzLDYgKzUzMywxNCBAQCBzdGF0aWMgaW50IHBkZXZfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWlmICghcHJpdikKPiAgCQlyZXR1cm4gLUVO T01FTTsKPiAKPiArCS8qIEFsbG9jYXRlIGFuZCBpbml0aWFsaXplIHRoZSBEUk0gZGV2aWNlLiAq Lwo+ICsJZGRldiA9IGRybV9kZXZfYWxsb2MoJm9tYXBfZHJtX2RyaXZlciwgJnBkZXYtPmRldik7 Cj4gKwlpZiAoSVNfRVJSKGRkZXYpKQo+ICsJCXJldHVybiBQVFJfRVJSKGRkZXYpOwo+ICsKPiAr CWRkZXYtPmRldl9wcml2YXRlID0gcHJpdjsKPiArCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYs IGRkZXYpOwo+ICsKPiAgCW9tYXBfY3J0Y19wcmVfaW5pdCgpOwo+IAo+ICAJcmV0ID0gb21hcF9j b25uZWN0X2Rzc2RldnMoKTsKPiBAQCAtNTQ5LDE2ICs1NTcsNiBAQCBzdGF0aWMgaW50IHBkZXZf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCXNwaW5fbG9ja19pbml0KCZw cml2LT5saXN0X2xvY2spOwo+ICAJSU5JVF9MSVNUX0hFQUQoJnByaXYtPm9ial9saXN0KTsKPiAK PiAtCS8qIEFsbG9jYXRlIGFuZCBpbml0aWFsaXplIHRoZSBEUk0gZGV2aWNlLiAqLwo+IC0JZGRl diA9IGRybV9kZXZfYWxsb2MoJm9tYXBfZHJtX2RyaXZlciwgJnBkZXYtPmRldik7Cj4gLQlpZiAo SVNfRVJSKGRkZXYpKSB7Cj4gLQkJcmV0ID0gUFRSX0VSUihkZGV2KTsKPiAtCQlnb3RvIGVycl9k ZXN0cm95X3dxOwo+IC0JfQo+IC0KPiAtCWRkZXYtPmRldl9wcml2YXRlID0gcHJpdjsKPiAtCXBs YXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRkZXYpOwo+IC0KPiAgCS8qIEdldCBtZW1vcnkgYmFu ZHdpZHRoIGxpbWl0cyAqLwo+ICAJaWYgKHByaXYtPmRpc3BjX29wcy0+Z2V0X21lbW9yeV9iYW5k d2lkdGhfbGltaXQpCj4gIAkJcHJpdi0+bWF4X2JhbmR3aWR0aCA9Cj4gQEAgLTU2OSw3ICs1Njcs NyBAQCBzdGF0aWMgaW50IHBkZXZfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgCXJldCA9IG9tYXBfbW9kZXNldF9pbml0KGRkZXYpOwo+ICAJaWYgKHJldCkgewo+ICAJCWRl dl9lcnIoJnBkZXYtPmRldiwgIm9tYXBfbW9kZXNldF9pbml0IGZhaWxlZDogcmV0PSVkXG4iLCBy ZXQpOwo+IC0JCWdvdG8gZXJyX2ZyZWVfZHJtX2RldjsKPiArCQlnb3RvIGVycl9nZW1fZGVpbml0 Owo+ICAJfQo+IAo+ICAJLyogSW5pdGlhbGl6ZSB2YmxhbmsgaGFuZGxpbmcsIHN0YXJ0IHdpdGgg YWxsIENSVENzIGRpc2FibGVkLiAqLwo+IEBAIC02MDUsMTQgKzYwMywxMyBAQCBzdGF0aWMgaW50 IHBkZXZfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgZXJyX2NsZWFudXBf bW9kZXNldDoKPiAgCWRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRkZXYpOwo+ICAJb21hcF9kcm1f aXJxX3VuaW5zdGFsbChkZGV2KTsKPiAtZXJyX2ZyZWVfZHJtX2RldjoKPiArZXJyX2dlbV9kZWlu aXQ6Cj4gIAlvbWFwX2dlbV9kZWluaXQoZGRldik7Cj4gLQlkcm1fZGV2X3VucmVmKGRkZXYpOwo+ IC1lcnJfZGVzdHJveV93cToKPiAgCWRlc3Ryb3lfd29ya3F1ZXVlKHByaXYtPndxKTsKPiAgCW9t YXBfZGlzY29ubmVjdF9kc3NkZXZzKCk7Cj4gIGVycl9jcnRjX3VuaW5pdDoKPiAgCW9tYXBfY3J0 Y19wcmVfdW5pbml0KCk7Cj4gKwlkcm1fZGV2X3VucmVmKGRkZXYpOwo+ICAJcmV0dXJuIHJldDsK PiAgfQo+IAo+IEBAIC02MzcsMTMgKzYzNCwxMyBAQCBzdGF0aWMgaW50IHBkZXZfcmVtb3ZlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlvbWFwX2RybV9pcnFfdW5pbnN0YWxsKGRk ZXYpOwo+ICAJb21hcF9nZW1fZGVpbml0KGRkZXYpOwo+IAo+IC0JZHJtX2Rldl91bnJlZihkZGV2 KTsKPiAtCj4gIAlkZXN0cm95X3dvcmtxdWV1ZShwcml2LT53cSk7Cj4gCj4gIAlvbWFwX2Rpc2Nv bm5lY3RfZHNzZGV2cygpOwo+ICAJb21hcF9jcnRjX3ByZV91bmluaXQoKTsKPiAKPiArCWRybV9k ZXZfdW5yZWYoZGRldik7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KCgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=