From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tursulin@ursulin.net>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Subject: Re: [PATCH] i915/oa: Simplify updating contexts
Date: Thu, 13 Sep 2018 09:58:59 +0100 [thread overview]
Message-ID: <153682913917.31648.12651548186204221559@skylake-alporthouse-com> (raw)
In-Reply-To: <2e7615e0-962e-0983-e7f9-8feafbe797c0@linux.intel.com>
Quoting Tvrtko Ursulin (2018-09-13 09:54:15)
>
> On 12/09/2018 16:50, Chris Wilson wrote:
> > By feeding a request, you ensure the reconfig is loaded again. +1 for
> > having it turn off when idle (and not instrument the kernel context at
> > all)!
> >
> > Still I follow your logic that this should leave the oa config in
> > exactly the same state as before the patch, so
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Thanks, yeah, I am not sure excluding kernel context is possible. If I
> understand the comments in i915_perf.c, and how much Lionel explained to
> me, when on we want it on all the time so sampling timers are always on
> regardless of context switches.
I was just thinking along the lines of not having the sampling active
when we are idle... But doesn't it actually break our powersaving model
entirely if the GT remains active after we drop our wakeref for it?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-13 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:29 [PATCH] i915/oa: Simplify updating contexts Tvrtko Ursulin
2018-09-12 15:46 ` Lionel Landwerlin
2018-09-12 15:50 ` Chris Wilson
2018-09-13 8:54 ` Tvrtko Ursulin
2018-09-13 8:58 ` Chris Wilson [this message]
2018-09-13 8:59 ` Chris Wilson
2018-09-12 16:58 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-13 8:43 ` Tvrtko Ursulin
2018-09-12 23:14 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153682913917.31648.12651548186204221559@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.