From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbdCZWke (ORCPT ); Sun, 26 Mar 2017 18:40:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60690 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbdCZWk3 (ORCPT ); Sun, 26 Mar 2017 18:40:29 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7B22A4DAF8 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jsnitsel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7B22A4DAF8 Date: Sun, 26 Mar 2017 18:40:27 -0400 (EDT) From: Jerry Snitselaar To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Peter Huewe , Jarkko Sakkinen , Marcel Selhorst Message-ID: <1536920674.6131725.1490568027655.JavaMail.zimbra@redhat.com> In-Reply-To: <20170326203628.GA3113@obsidianresearch.com> References: <20170325200521.19224-1-jsnitsel@redhat.com> <20170325200521.19224-2-jsnitsel@redhat.com> <20170326203628.GA3113@obsidianresearch.com> Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.125] Thread-Topic: tpm_tis: convert to using locality callbacks Thread-Index: tk79bZmC+f5DFFN7QWQrzEQKSpE+vQ== X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Sun, 26 Mar 2017 22:40:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: "Jason Gunthorpe" > To: "Jerry Snitselaar" > Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Peter Huewe" , "Jarkko > Sakkinen" , "Marcel Selhorst" > Sent: Sunday, March 26, 2017 1:36:28 PM > Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks > > On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote: > > > @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip) > > interrupt = 0; > > > > tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt); > > - release_locality(chip, priv->locality, 1); > > + release_locality(chip, priv->locality); > > Why is this done during remove? The tpm core should now keep things so > that there is not a requested locality except during command so execution > we should not get here with a requested locality.. > > Jason > You're right, this call should be dropped. With release_locality always releasing now it shouldn't have a locality when going into remove. I'll drop this in v2. Thanks, Jerry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Snitselaar Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks Date: Sun, 26 Mar 2017 18:40:27 -0400 (EDT) Message-ID: <1536920674.6131725.1490568027655.JavaMail.zimbra@redhat.com> References: <20170325200521.19224-1-jsnitsel@redhat.com> <20170325200521.19224-2-jsnitsel@redhat.com> <20170326203628.GA3113@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170326203628.GA3113-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jason Gunthorpe Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: tpmdd-devel@lists.sourceforge.net ----- Original Message ----- > From: "Jason Gunthorpe" > To: "Jerry Snitselaar" > Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Peter Huewe" , "Jarkko > Sakkinen" , "Marcel Selhorst" > Sent: Sunday, March 26, 2017 1:36:28 PM > Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks > > On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote: > > > @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip) > > interrupt = 0; > > > > tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt); > > - release_locality(chip, priv->locality, 1); > > + release_locality(chip, priv->locality); > > Why is this done during remove? The tpm core should now keep things so > that there is not a requested locality except during command so execution > we should not get here with a requested locality.. > > Jason > You're right, this call should be dropped. With release_locality always releasing now it shouldn't have a locality when going into remove. I'll drop this in v2. Thanks, Jerry ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot