From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DB1ECE562 for ; Fri, 21 Sep 2018 09:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2B5121531 for ; Fri, 21 Sep 2018 09:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2B5121531 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389728AbeIUPiN (ORCPT ); Fri, 21 Sep 2018 11:38:13 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:18378 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727391AbeIUPiN (ORCPT ); Fri, 21 Sep 2018 11:38:13 -0400 X-UUID: c583095e738a43b9bdeee3261c178ce0-20180921 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 654323504; Fri, 21 Sep 2018 17:50:06 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 21 Sep 2018 17:50:04 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 21 Sep 2018 17:50:05 +0800 Message-ID: <1537523404.20660.10.camel@mtksdaap41> Subject: Re: [PATCH v3 06/12] drm/mediatek: add dpi driver for mt2701 and mt7623 From: CK Hu To: Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , , , Yingjoe Chen , Cawa Cheng , Daniel Kurtz , "Philipp Zabel" , YT Shen , "Thierry Reding" , Mao Huang , , , "Sascha Hauer" , chunhui dai Date: Fri, 21 Sep 2018 17:50:04 +0800 In-Reply-To: <20180921032822.30771-7-bibby.hsieh@mediatek.com> References: <20180921032822.30771-1-bibby.hsieh@mediatek.com> <20180921032822.30771-7-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi dirver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > Reviewed-by: CK Hu > Signed-off-by: chunhui dai > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 7a4868a0afec..a9d8231a0a9e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -688,11 +688,29 @@ static unsigned int mt8173_calculate_factor(int clock) > return 3 << 1; > } > > +static unsigned int mt2701_calculate_factor(int clock) > +{ > + if (clock <= 64000) > + return 16; > + else if (clock <= 128000) > + return 8; > + else if (clock <= 256000) > + return 4; > + else > + return 2; > +} > + > static const struct mtk_dpi_conf mt8173_conf = { > .cal_factor = mt8173_calculate_factor, > .reg_h_fre_con = 0xe0, > }; > > +static const struct mtk_dpi_conf mt2701_conf = { > + .cal_factor = mt2701_calculate_factor, > + .reg_h_fre_con = 0xb0, > + .edge_sel_en = true, > +}; > + > static int mtk_dpi_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -784,6 +802,9 @@ static int mtk_dpi_remove(struct platform_device *pdev) > } > > static const struct of_device_id mtk_dpi_of_ids[] = { > + { .compatible = "mediatek,mt2701-dpi", > + .data = &mt2701_conf, > + }, > { .compatible = "mediatek,mt8173-dpi", > .data = &mt8173_conf, > }, > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 39721119713b..d961112fa2f5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -424,6 +424,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8173-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt2701-dpi", > + .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt8173-dpi", > .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt2701-disp-mutex", From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v3 06/12] drm/mediatek: add dpi driver for mt2701 and mt7623 Date: Fri, 21 Sep 2018 17:50:04 +0800 Message-ID: <1537523404.20660.10.camel@mtksdaap41> References: <20180921032822.30771-1-bibby.hsieh@mediatek.com> <20180921032822.30771-7-bibby.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180921032822.30771-7-bibby.hsieh@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: Bibby Hsieh Cc: David Airlie , Matthias Brugger , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Yingjoe Chen , Cawa Cheng , Daniel Kurtz , Philipp Zabel , YT Shen , Thierry Reding , Mao Huang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sascha Hauer , chunhui dai List-Id: linux-mediatek@lists.infradead.org Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi dirver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > Reviewed-by: CK Hu > Signed-off-by: chunhui dai > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 7a4868a0afec..a9d8231a0a9e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -688,11 +688,29 @@ static unsigned int mt8173_calculate_factor(int clock) > return 3 << 1; > } > > +static unsigned int mt2701_calculate_factor(int clock) > +{ > + if (clock <= 64000) > + return 16; > + else if (clock <= 128000) > + return 8; > + else if (clock <= 256000) > + return 4; > + else > + return 2; > +} > + > static const struct mtk_dpi_conf mt8173_conf = { > .cal_factor = mt8173_calculate_factor, > .reg_h_fre_con = 0xe0, > }; > > +static const struct mtk_dpi_conf mt2701_conf = { > + .cal_factor = mt2701_calculate_factor, > + .reg_h_fre_con = 0xb0, > + .edge_sel_en = true, > +}; > + > static int mtk_dpi_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -784,6 +802,9 @@ static int mtk_dpi_remove(struct platform_device *pdev) > } > > static const struct of_device_id mtk_dpi_of_ids[] = { > + { .compatible = "mediatek,mt2701-dpi", > + .data = &mt2701_conf, > + }, > { .compatible = "mediatek,mt8173-dpi", > .data = &mt8173_conf, > }, > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 39721119713b..d961112fa2f5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -424,6 +424,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8173-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt2701-dpi", > + .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt8173-dpi", > .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt2701-disp-mutex", From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Fri, 21 Sep 2018 17:50:04 +0800 Subject: [PATCH v3 06/12] drm/mediatek: add dpi driver for mt2701 and mt7623 In-Reply-To: <20180921032822.30771-7-bibby.hsieh@mediatek.com> References: <20180921032822.30771-1-bibby.hsieh@mediatek.com> <20180921032822.30771-7-bibby.hsieh@mediatek.com> Message-ID: <1537523404.20660.10.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi dirver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > Reviewed-by: CK Hu > Signed-off-by: chunhui dai > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 7a4868a0afec..a9d8231a0a9e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -688,11 +688,29 @@ static unsigned int mt8173_calculate_factor(int clock) > return 3 << 1; > } > > +static unsigned int mt2701_calculate_factor(int clock) > +{ > + if (clock <= 64000) > + return 16; > + else if (clock <= 128000) > + return 8; > + else if (clock <= 256000) > + return 4; > + else > + return 2; > +} > + > static const struct mtk_dpi_conf mt8173_conf = { > .cal_factor = mt8173_calculate_factor, > .reg_h_fre_con = 0xe0, > }; > > +static const struct mtk_dpi_conf mt2701_conf = { > + .cal_factor = mt2701_calculate_factor, > + .reg_h_fre_con = 0xb0, > + .edge_sel_en = true, > +}; > + > static int mtk_dpi_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -784,6 +802,9 @@ static int mtk_dpi_remove(struct platform_device *pdev) > } > > static const struct of_device_id mtk_dpi_of_ids[] = { > + { .compatible = "mediatek,mt2701-dpi", > + .data = &mt2701_conf, > + }, > { .compatible = "mediatek,mt8173-dpi", > .data = &mt8173_conf, > }, > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 39721119713b..d961112fa2f5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -424,6 +424,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > .data = (void *)MTK_DSI }, > { .compatible = "mediatek,mt8173-dsi", > .data = (void *)MTK_DSI }, > + { .compatible = "mediatek,mt2701-dpi", > + .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt8173-dpi", > .data = (void *)MTK_DPI }, > { .compatible = "mediatek,mt2701-disp-mutex",