From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Benjamin Marzinski" Subject: [PATCH v3 12/19] libmutipath: don't use malformed uevents Date: Fri, 21 Sep 2018 18:05:20 -0500 Message-ID: <1537571127-10143-13-git-send-email-bmarzins@redhat.com> References: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development Cc: Martin Wilck List-Id: dm-devel.ids A uevent that doesn't include the ACTION and DEVPATH fields is malformed. It should be ignored, instead of used with those fields being NULL. Signed-off-by: Benjamin Marzinski --- libmultipath/uevent.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c index fd8ca35..5f910e6 100644 --- a/libmultipath/uevent.c +++ b/libmultipath/uevent.c @@ -729,6 +729,12 @@ struct uevent *uevent_from_udev_device(struct udev_device *dev) if (i == HOTPLUG_NUM_ENVP - 1) break; } + if (!uev->devpath || ! uev->action) { + udev_device_unref(dev); + condlog(1, "uevent missing necessary fields"); + FREE(uev); + return NULL; + } uev->udev = dev; uev->envp[i] = NULL; -- 2.7.4