From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3 1/8] drm/i915: Make sure fb gtt offsets stay within 32bits Date: Tue, 25 Sep 2018 21:29:44 +0100 Message-ID: <153790738445.21139.17414049229386732949@skylake-alporthouse-com> References: <20180925193714.25280-1-ville.syrjala@linux.intel.com> <20180925193714.25280-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0845689228 for ; Tue, 25 Sep 2018 20:29:48 +0000 (UTC) In-Reply-To: <20180925193714.25280-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBWaWxsZSBTeXJqYWxhICgyMDE4LTA5LTI1IDIwOjM3OjA3KQo+IEZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gTGV0J3MgdHJ5 IHRvIG1ha2Ugc3VyZSB0aGUgZmIgb2Zmc2V0IGNvbXB1dGF0aW9ucyBuZXZlciBoaXQKPiBhbiBp bnRlZ2VyIG92ZXJmbG93IGJ5IG1ha2luZyBzdXJlIHRoZSBlbnRpcmUgZmIgc3RheXMKPiBiZWxv dyAzMmJpdHMuIGZyYW1lYnVmZmVyX2NoZWNrKCkgaW4gdGhlIGNvcmUgYWxyZWFkeSBkb2VzCj4g dGhlIHNhbWUgY2hlY2ssIGJ1dCBhcyBpdCBkb2Vzbid0IGtub3cgYWJvdXQgdGlsaW5nIHNvbWUg dGhpbmdzCj4gY2FuIHNsaXAgdGhyb3VnaC4gUmVwZWF0IHRoZSBjaGVjayBpbiB0aGUgZHJpdmVy IHdpdGggdGlsaW5nCj4gdGFrZW4gaW50byBhY2NvdW50Lgo+IAo+IHYyOiBVc2UgYWRkX292ZXJm bG93cygpIGFmdGVyIG1hc3NhZ2luZyBpdCB0byB3b3JrIGZvciBtZSAoQ2hyaXMpCgpPaCwgaXQg aGFkIGZhbGxlbiBvdXQgb2YgdXNlLgogCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV91dGlscy5oICAgIHwgIDggKysrKy0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIHwgMTggKysrKysrKysrKysrKysrKystCj4gIDIgZmlsZXMgY2hh bmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV91dGlscy5oCj4gaW5kZXggMzk1ZGQyNTExNTY4Li5jNDNlYzk5M2ZhOTAgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV91dGlscy5oCj4gQEAgLTQ0LDEzICs0NCwxMyBAQAo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnkoeCksIChsb25nKSh4KSkKPiAgCj4gICNp ZiBkZWZpbmVkKEdDQ19WRVJTSU9OKSAmJiBHQ0NfVkVSU0lPTiA+PSA3MDAwMAo+IC0jZGVmaW5l IGFkZF9vdmVyZmxvd3MoQSwgQikgXAo+IC0gICAgICAgX19idWlsdGluX2FkZF9vdmVyZmxvd19w KChBKSwgKEIpLCAodHlwZW9mKChBKSArIChCKSkpMCkKPiArI2RlZmluZSBhZGRfb3ZlcmZsb3dz KEEsIEIsIEMpIFwKPiArICAgICAgIF9fYnVpbHRpbl9hZGRfb3ZlcmZsb3dfcCgoQSksIChCKSwg KEMpKQo+ICAjZWxzZQo+IC0jZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQikgKHsgXAo+ICsjZGVm aW5lIGFkZF9vdmVyZmxvd3MoQSwgQiwgQykgKHsgXAo+ICAgICAgICAgdHlwZW9mKEEpIGEgPSAo QSk7IFwKPiAgICAgICAgIHR5cGVvZihCKSBiID0gKEIpOyBcCj4gLSAgICAgICBhICsgYiA8IGE7 IFwKPiArICAgICAgICh0eXBlb2YoQykpKGEgKyBiKSA8IGE7IFwKPiAgfSkKPiAgI2VuZGlmCj4g IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA0YzVjMmIzOWU2NWMu LmEzYWUyNGUwMzMxNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBA QCAtMjQwMCwxMCArMjQwMCwyNiBAQCBzdGF0aWMgaW50IGludGVsX2ZiX29mZnNldF90b194eShp bnQgKngsIGludCAqeSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgY29s b3JfcGxhbmUpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZmItPmRldik7Cj4gKyAgICAgICB1bnNpZ25lZCBpbnQgaGVpZ2h0Owo+ICAK PiAgICAgICAgIGlmIChmYi0+bW9kaWZpZXIgIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFSICYmCj4g LSAgICAgICAgICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdICUgaW50ZWxfdGlsZV9zaXplKGRl dl9wcml2KSkKPiArICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0gJSBpbnRlbF90 aWxlX3NpemUoZGV2X3ByaXYpKSB7Cj4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIk1p c2FsaWduZWQgb2Zmc2V0IDB4JTA4eCBmb3IgY29sb3IgcGxhbmUgJWRcbiIsCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdLCBjb2xvcl9wbGFu ZSk7Cj4gICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgfQo+ICsKPiAr ICAgICAgIGhlaWdodCA9IGRybV9mcmFtZWJ1ZmZlcl9wbGFuZV9oZWlnaHQoZmItPmhlaWdodCwg ZmIsIGNvbG9yX3BsYW5lKTsKPiArICAgICAgIGhlaWdodCA9IEFMSUdOKGhlaWdodCwgaW50ZWxf dGlsZV9oZWlnaHQoZmIsIGNvbG9yX3BsYW5lKSk7Cj4gKwo+ICsgICAgICAgLyogQ2F0Y2ggcG90 ZW50aWFsIG92ZXJmbG93cyBlYXJseSAqLwo+ICsgICAgICAgaWYgKGFkZF9vdmVyZmxvd3MobXVs X3UzMl91MzIoaGVpZ2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9wbGFuZV0pLAo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgZmItPm9mZnNldHNbY29sb3JfcGxhbmVdLCAodTMyKTApKSB7CgpTaG91 bGQgd2UganVzdCBwYXNzIHR5cGU/IEF0bSB3ZSBhcmVuJ3QgdXNpbmcgdGhlIHZhbHVlIGZvciBh bnl0aGluZy4KVGhlbiBpdCB3b3VsZCBiZSBhZGRfb3ZlcmZsb3dzX3QoYSwgYiwgVCkgd2l0aCB0 aGUgb2J2aW91cyB3cmFwcGluZyBmb3IKYWRkX292ZXJmbG93cyhhLCBiKS4gQWx0aG91Z2ggdG8g YmUgY29uc2lzdGVudCB3aXRoIG1pbl90LCBwZXJoYXBzCmFkZF9vdmVyZmxvd3NfdChULCBhLCBi KS4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=