Re: [PATCH] drm/i915: Log HWS seqno consistently

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tursulin@ursulin.net>
Subject: Re: [PATCH] drm/i915: Log HWS seqno consistently
Date: Wed, 26 Sep 2018 12:17:11 +0100	[thread overview]
Message-ID: <153796063158.22836.18296824848059760839@skylake-alporthouse-com> (raw)
In-Reply-To: <20180926111217.24130-1-tvrtko.ursulin@linux.intel.com>

Quoting Tvrtko Ursulin (2018-09-26 12:12:17)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> We mix hexa- and decimal which is confusing when reading the logs. So make
> the single odd one out instance decimal for consistency.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> Later we can consider whether we should move them all to unsigned, or hex,
> etc..
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 4b28225320ff..ad93aa4b0a6e 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
>         unsigned long flags;
>         u32 *regs;
>  
> -       GEM_TRACE("%s request global=%x, current=%d\n",
> +       GEM_TRACE("%s request global=%d, current=%d\n",
>                   engine->name, request ? request->global_seqno : 0,
>                   intel_engine_get_seqno(engine));
>  

One more in intel_ringbuffer.c
drivers/gpu/drm/i915/intel_ringbuffer.c:        GEM_TRACE("%s seqno=%x\n", engine->name, rq ? rq->global_seqno : 0);
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx