From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA432C433F5 for ; Mon, 25 Oct 2021 13:48:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9ED360F46 for ; Mon, 25 Oct 2021 13:48:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231980AbhJYNuu (ORCPT ); Mon, 25 Oct 2021 09:50:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54871 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbhJYNut (ORCPT ); Mon, 25 Oct 2021 09:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635169706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=RcUN7h3/KVcwB6CG2nyXxa0de24df0g3VfDOZrfqH/ynGLyLyDFmXnYkvZkf3l/Xy192Bw RupD1Y+KicOlz2O5kjHiwx3bttaThZ8ePhvcgYr++8Hf/XUpwmyXUFODZ+DX+NCwXtd/Hm eQB4dxnagmpWvuZtwsyzT1JmL8TEMXs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-C9xeyPrCMrmlJV_ui2mvyA-1; Mon, 25 Oct 2021 09:48:24 -0400 X-MC-Unique: C9xeyPrCMrmlJV_ui2mvyA-1 Received: by mail-wm1-f69.google.com with SMTP id z20-20020a05600c221400b0032cb38a76a9so2438wml.8 for ; Mon, 25 Oct 2021 06:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=viwwagiRrbZJ8tcNE2oDTDH1JTm6/Skpn22jEKwhHM/8OWcwBkCb65QEkSXUBlBKTu w3iFf5zYVz7NJ4+KUBuOqYdHYtji6vJ6TzKU5JkWuKYTiuK0tku3K4UhuJIb6yeaXwYM VnF2OOv0WMpWET+hir45AlB9zjWx0YtGGBTUBH+HscLiSSF5N9gv2YxvOrjJlsLO4+/J SdnP4aLRG1pj+JQQBWw+YJJQ5NJ3TZqNigiiiXhUFysIFeukt51BajhYKtTTrVB4jQOg 7QYVeDmVI8QHq6D7uWSAcYzab861qxXzPKsc8CEK/B4OjznCnfsPPo6l40hyrHjwi0jP AmxA== X-Gm-Message-State: AOAM5334DIOzx8FGiiGs7R/yMAKvwO/bruAfcwBTv2Lv2sgpH3PIysL4 7Ylp+iSirqGpnsjo2ATIjEEYlzeTcRWoZ9Hzc/mIP+dh6D3i4rJj6zO6WKlhlcJMYi4OKs9ZsfF 9mlypzGhorxNdlB2cavHLXGCN X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355622wrd.264.1635169703586; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvh4UiZag1iqCL0Yxmhmh7ghHaPzeCY1G7nZe+NYuublJxNb7HJYi3GJafbpt4P4VqHirR5w== X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355558wrd.264.1635169703285; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id m12sm3661638wrq.69.2021.10.25.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 06:48:22 -0700 (PDT) Message-ID: <1537b693-80ee-4f9e-2c4e-6e1c62ccca92@redhat.com> Date: Mon, 25 Oct 2021 15:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 20/43] KVM: VMX: Skip Posted Interrupt updates if APICv is hard disabled Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-21-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-21-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* Nothing to do if PI.SN==0 and the vCPU isn't being migrated. */ > if (!pi_test_sn(pi_desc) && vcpu->cpu == cpu) > return; This does not quite say "why", so: /* Nothing to do if PI.SN and PI.NDST both have the desired value. */ Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD974C433F5 for ; Mon, 25 Oct 2021 13:48:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C6056058D for ; Mon, 25 Oct 2021 13:48:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C6056058D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fiwOGjvATe7srF79NQCZLHjuv0peD7LkMaDZMM8k1kQ=; b=GJsohQ7pjWscM7 nlSTsNsMSFUBCjmB9RlQDmib2Nk7gNYQBHcIcMim7hgnM4bhdDE/Pv7xZJC5Aoo0qCGJMhZxE4SsF KOfcdYi3d+yWVI4jS4z11Mlblg5MjYFleJQZj3nmOQ9uQWXhTdS2lUtLORbS5dpFe96WIfI/0/swp B8hgJdPeNpwyWSbjcuIOV1GF3B67SdCmGLbB+oyaDxW0YShi0OSjOMSgL1lqpMjvSmuo59ds24TvT UhbTL84yYsoozJ9NQywImtE1OB6TSL2cnvOcmYru7f3drfBAGxDZOgCy/1U5V7YPJg7WrfuU16pCW CB8CeQ3bQzb8CDwIiZbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0LB-00GaBC-73; Mon, 25 Oct 2021 13:48:41 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0Ky-00Ga86-DD for linux-riscv@lists.infradead.org; Mon, 25 Oct 2021 13:48:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635169706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=RcUN7h3/KVcwB6CG2nyXxa0de24df0g3VfDOZrfqH/ynGLyLyDFmXnYkvZkf3l/Xy192Bw RupD1Y+KicOlz2O5kjHiwx3bttaThZ8ePhvcgYr++8Hf/XUpwmyXUFODZ+DX+NCwXtd/Hm eQB4dxnagmpWvuZtwsyzT1JmL8TEMXs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-ldtTqyYMP2WzpNoe2TFQpg-1; Mon, 25 Oct 2021 09:48:24 -0400 X-MC-Unique: ldtTqyYMP2WzpNoe2TFQpg-1 Received: by mail-wm1-f72.google.com with SMTP id z17-20020a7bc7d1000000b0032cafafaf79so4893wmk.5 for ; Mon, 25 Oct 2021 06:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=FFZNtOesmD9yZDDqyW8DAQYIfGSgoHecbk3eQb89hJm0FaG2asquD0yfbXg+j+iaje yBkxYHC4tWPPQru2G/4xwaXGW+J36fZtGm+dXwgMC582UjOT6qUlp9X6hieFodULPi8A nCv4uUExI/PN7TbLzBWE0Q9YbQeKzBWoVG45cc0YZIM1jotbJKBVHO6k4dXCSxElV7cF 9J6YOsYnmoov0dUsSqW+d95awrCuTAGlN2CjmZ2E/NBmPHEV01e+d2elCQl/i8/nSyQH wAnMJyqhqvn4AOmf5Rggsc92PI7N0jTJh8lWQYLaWsXSqZfVW0lgsvEjnnWbEdo2CA0m ZAgQ== X-Gm-Message-State: AOAM531MQRc4nYkNBEvy7NBkFS10yUP3rjoTcF3mSD010TvdQu/fVei1 YfbBpwC1emSQuqy2bUomDAFKJSc+u5SgGoI3l0bQzN52B4rgGOtFRwI3Ia/LTMq/ALmLpbclzAJ 3NOLlWp+2Rt9aX6aYAwvCS4xYRB+g X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355619wrd.264.1635169703585; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvh4UiZag1iqCL0Yxmhmh7ghHaPzeCY1G7nZe+NYuublJxNb7HJYi3GJafbpt4P4VqHirR5w== X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355558wrd.264.1635169703285; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id m12sm3661638wrq.69.2021.10.25.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 06:48:22 -0700 (PDT) Message-ID: <1537b693-80ee-4f9e-2c4e-6e1c62ccca92@redhat.com> Date: Mon, 25 Oct 2021 15:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 20/43] KVM: VMX: Skip Posted Interrupt updates if APICv is hard disabled To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-21-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-21-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_064828_559565_BF084843 X-CRM114-Status: UNSURE ( 6.39 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* Nothing to do if PI.SN==0 and the vCPU isn't being migrated. */ > if (!pi_test_sn(pi_desc) && vcpu->cpu == cpu) > return; This does not quite say "why", so: /* Nothing to do if PI.SN and PI.NDST both have the desired value. */ Paolo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D49C433F5 for ; Mon, 25 Oct 2021 13:48:33 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id DF72A60FBF for ; Mon, 25 Oct 2021 13:48:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF72A60FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 424934B17B; Mon, 25 Oct 2021 09:48:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X0hUCov7MoxI; Mon, 25 Oct 2021 09:48:30 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 86CF34B125; Mon, 25 Oct 2021 09:48:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3FFAE4B0FB for ; Mon, 25 Oct 2021 09:48:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e7YTq26e6y3R for ; Mon, 25 Oct 2021 09:48:27 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E1D024B0E6 for ; Mon, 25 Oct 2021 09:48:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635169707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=OgQfAz+Et8aZ/5O33dzEdbXp8BUTPmUcX5F+31gv6aKDvDxnkwmItPTmmvvfGUKTsSHBq9 gdK0ph45qeMBAviBHi3be2NNQarH3w4vYJinKumaczCmbDSaL+WtpOfCJ1rY6s2H0tAsqM vkxd0pTeaCZ3oEzYOx7dBqs1pPettVk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-406-_EKAYdJ5MRmFhc0PfOgeSg-1; Mon, 25 Oct 2021 09:48:24 -0400 X-MC-Unique: _EKAYdJ5MRmFhc0PfOgeSg-1 Received: by mail-wr1-f69.google.com with SMTP id d13-20020adf9b8d000000b00160a94c235aso3252926wrc.2 for ; Mon, 25 Oct 2021 06:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=e9rajMcyqorXRaH8DIwMNt0ZRHDP2X8EGuv01fUid3IQjtRWvFuMZ18GnqBmKGaDLW C1Gdlay8/bM0uGOxLGnFrduCVe2dJSzKnuKxorgkFn/0hXqML++ILUw45iTIyVwvJdin 2Pp/ofSG5JHOWihZCed1sXakJXoUkIpqs3t1/Vz4480fQgxMK6IIvtD/db4quWrcB56y A+j8JpcrgX6bXDzV3e1iW4lSUx2NDAZNMB6Fettms0Hg2FOF1NwnBmydQKAcJi20U4jE MGwRis/gz+VX3GShSUcIakF3VlDe2U5Vp0r5ds3SR09sbrr2AXG/sjjr4ikEp/eMbC5K yb2A== X-Gm-Message-State: AOAM531l7bMedKjwAk17Vyf++as43t/Ob1KJcY5TFdSdF6k7ZqlkEzKF sK3vz4nlt/Tkf+a2qi51vxH+dR0K2Ew2GyKHf9o9a76zthid57EuvnqvB1NqMzo71RELgJnRyLD uCBKRmC6yQ7Ab5OPvscwLEvHT X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355638wrd.264.1635169703594; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvh4UiZag1iqCL0Yxmhmh7ghHaPzeCY1G7nZe+NYuublJxNb7HJYi3GJafbpt4P4VqHirR5w== X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355558wrd.264.1635169703285; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id m12sm3661638wrq.69.2021.10.25.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 06:48:22 -0700 (PDT) Message-ID: <1537b693-80ee-4f9e-2c4e-6e1c62ccca92@redhat.com> Date: Mon, 25 Oct 2021 15:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 20/43] KVM: VMX: Skip Posted Interrupt updates if APICv is hard disabled To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-21-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-21-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, Joerg Roedel , kvm-ppc@vger.kernel.org, David Matlack , linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 09/10/21 04:12, Sean Christopherson wrote: > + /* Nothing to do if PI.SN==0 and the vCPU isn't being migrated. */ > if (!pi_test_sn(pi_desc) && vcpu->cpu == cpu) > return; This does not quite say "why", so: /* Nothing to do if PI.SN and PI.NDST both have the desired value. */ Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA28CC433EF for ; Mon, 25 Oct 2021 13:49:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A871C6058D for ; Mon, 25 Oct 2021 13:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A871C6058D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hcatMsO0JL/WRLphqgeVPAAQDtzIdz9G3HvyuKKSzVQ=; b=2PdIbPGhH2NHxe ahAj4NBdxFgnkqoqfYiL3xyh1RZxSNen3RiiYwsOvWsInsJHXSPL0SRYKVn+44ZcQq+C5EGEm+liv eaf2dxUhCEnbdToxwFcbULDA9f6eSrz/C6m3G9xuprohI8XTeIgNnzPZUelJqYdvnXzL1rGNIrYLG eTfUgwJt8X2NPL7lhDxrye6HOI5voBZejE1ygHtNSWr/OEa/+SCp5Cd5DdycQ5Sl0BAA1ejVPzmy+ hBywopCfabNpwSVbHqC+nT05OfNE14vd8GGuaVpCbnwzi3NxjA2ebvPn78x1iN5V/sqfjpjE1pbsf A7vjMBuoErc8ai3rLtpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0L1-00Ga9d-NL; Mon, 25 Oct 2021 13:48:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf0Ky-00Ga85-DA for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 13:48:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635169706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=RcUN7h3/KVcwB6CG2nyXxa0de24df0g3VfDOZrfqH/ynGLyLyDFmXnYkvZkf3l/Xy192Bw RupD1Y+KicOlz2O5kjHiwx3bttaThZ8ePhvcgYr++8Hf/XUpwmyXUFODZ+DX+NCwXtd/Hm eQB4dxnagmpWvuZtwsyzT1JmL8TEMXs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-510-CGCk3arbMSu3oQcQc00PPw-1; Mon, 25 Oct 2021 09:48:24 -0400 X-MC-Unique: CGCk3arbMSu3oQcQc00PPw-1 Received: by mail-wm1-f71.google.com with SMTP id q13-20020a1ca70d000000b0032ca7b7fad6so2199444wme.0 for ; Mon, 25 Oct 2021 06:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rAI1rvJIZVwx71e91km04CwkX5jtmNRsQSKYM+y4LQM=; b=mdhtFROu874CjULQsk8GL7+W2oQ2HKfRe41MLcMRyOsgJ7MD4pI4DOc/1FOzwPeoh7 TrEq82T5XVTarNMJif3Z5EdYKksbC0Bx2NnXmszlm8LHisWsMlxLHmJJ/IBdkydGXBax SLsnGOKTzoyFBV83DTS9jDLFRxKAYY5aSa17CYSS6quP0Gs8wSYwTaXU5u52nEUSCJxy 3Vxv182+9vuaKMFMcRsuVzIITbzasRRgIZWB1PffIu9FEougV5rDQzVrm+DzimuS7Erm Gg7MIgjQ0fGqZAl11NU/ZBfD+cIcsjrgcNecr7IjH1wUFuGF6WEmDGoD2+LCRJYW8Nwe R+ag== X-Gm-Message-State: AOAM530g+YX6UhZyDT3rZuHnZGL/e8+iCvZgOVUpsZKZ+v24n9Wqjt9+ GaeEBBSXtf3a4q7YRzxPfD9g4IJbCNeGnI9FxYf78/YPGXbVFyN3YIDIzJ2F8wxhtK1iPKgcyph V7sGIUhJwGpYuwf7wKvygg/VDBXIVvN8Qc6s= X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355621wrd.264.1635169703586; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvh4UiZag1iqCL0Yxmhmh7ghHaPzeCY1G7nZe+NYuublJxNb7HJYi3GJafbpt4P4VqHirR5w== X-Received: by 2002:adf:d1ee:: with SMTP id g14mr24355558wrd.264.1635169703285; Mon, 25 Oct 2021 06:48:23 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id m12sm3661638wrq.69.2021.10.25.06.48.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Oct 2021 06:48:22 -0700 (PDT) Message-ID: <1537b693-80ee-4f9e-2c4e-6e1c62ccca92@redhat.com> Date: Mon, 25 Oct 2021 15:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 20/43] KVM: VMX: Skip Posted Interrupt updates if APICv is hard disabled To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-21-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20211009021236.4122790-21-seanjc@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_064828_559588_9FBAC74B X-CRM114-Status: UNSURE ( 7.91 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/10/21 04:12, Sean Christopherson wrote: > + /* Nothing to do if PI.SN==0 and the vCPU isn't being migrated. */ > if (!pi_test_sn(pi_desc) && vcpu->cpu == cpu) > return; This does not quite say "why", so: /* Nothing to do if PI.SN and PI.NDST both have the desired value. */ Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Mon, 25 Oct 2021 13:48:20 +0000 Subject: Re: [PATCH v2 20/43] KVM: VMX: Skip Posted Interrupt updates if APICv is hard disabled Message-Id: <1537b693-80ee-4f9e-2c4e-6e1c62ccca92@redhat.com> List-Id: References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-21-seanjc@google.com> In-Reply-To: <20211009021236.4122790-21-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sean Christopherson , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang On 09/10/21 04:12, Sean Christopherson wrote: > + /* Nothing to do if PI.SN=0 and the vCPU isn't being migrated. */ > if (!pi_test_sn(pi_desc) && vcpu->cpu = cpu) > return; This does not quite say "why", so: /* Nothing to do if PI.SN and PI.NDST both have the desired value. */ Paolo