From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 1/2] librte_ether: add protection against overwrite device data Date: Thu, 06 Oct 2016 11:41:06 +0200 Message-ID: <1538060.S3DiiuebUu@xps13> References: <1474974783-4861-2-git-send-email-marcinx.kerlin@intel.com> <1475244055-6309-1-git-send-email-marcinx.kerlin@intel.com> <1475244055-6309-2-git-send-email-marcinx.kerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, sergio.gonzalez.monroy@intel.com To: Marcin Kerlin Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 96527374F for ; Thu, 6 Oct 2016 11:41:09 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f193so278978197wmg.0 for ; Thu, 06 Oct 2016 02:41:09 -0700 (PDT) In-Reply-To: <1475244055-6309-2-git-send-email-marcinx.kerlin@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Marcin, 2016-09-30 16:00, Marcin Kerlin: > Added protection against overwrite device data in array rte_eth_dev_data[] > for the next secondary applications. Secondary process appends in the > first free place rather than at the beginning. This behavior prevents > overwriting devices data of primary process by secondary process. I've just realized that you are trying to fix an useless code. Why not just remove the array rte_eth_dev_data[] at first? We already have the array rte_eth_devices[] and there is a pointer to rte_eth_dev_data in rte_eth_dev. Is it just a workaround to be able to lookup the rte_eth_dev_data memzone in the secondary process? So wouldn't it be saner to have rte_eth_devices[] in a memzone? Sergio, as the multi-process maintainer, I guess you have an idea :)