Re: [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc

[Luca Boccassi <bluca@debian.org>]

On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote:
> 1/4: enablement of aesni_gcm pmd in meson
> 2/4: enablement of aesni_mb pmd in meson
> 3/4: enablement of kasumi pmd enable in meson
> 4/4: enablement of zuc pmd enable in meson
> 
> Hari Kumar Vemula (4):
>   driver/crypto: enable meson support for the aesni gcm
>   drivers/crypto: enable meson support for the aesni mb
>   drivers/crypto: enable meson support for the kasumi
>   drivers/crypto: enable meson support for the zuc
> 
>  drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
>  drivers/crypto/aesni_mb/meson.build  | 16 ++++++++++++++++
>  drivers/crypto/kasumi/meson.build    | 18 ++++++++++++++++++
>  drivers/crypto/meson.build           |  4 ++--
>  drivers/crypto/zuc/meson.build       | 18 ++++++++++++++++++
>  meson_options.txt                    |  6 ++++++
>  6 files changed, 77 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/crypto/aesni_gcm/meson.build
>  create mode 100644 drivers/crypto/aesni_mb/meson.build
>  create mode 100644 drivers/crypto/kasumi/meson.build
>  create mode 100644 drivers/crypto/zuc/meson.build

Hi,

With Meson we want to reduce the large number of build-time options.
For dependencies, I don't think it's necessary to have a separate
option to pass the library path.

The preferred option would be for the dependency to have a pkg-config
file which sets the necessary flags. If that's not installed in the
standard path, the PKG_CONFIG_PATH environment variable can be set to
add custom paths.

If a dependency does not have a pkg-config file (if you control it
would be a good time to add it :-) ), then you can set the path to the
shared object with something like: LD_FLAGS=-L/path/to/lib/ and Meson
will use that automatically (and CFLAGS=-I/path/to/headers/ if
necessary as well).

-- 
Kind regards,
Luca Boccassi