From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andi Shyti <andi.shyti@intel.com>,
Jani Nikula <jani.nikula@intel.com>,
Joonas Lahtinen <joonas.lahtinen@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915: fix wrong error number report
Date: Tue, 02 Oct 2018 12:18:49 +0100 [thread overview]
Message-ID: <153847912974.23109.16519605205193105207@skylake-alporthouse-com> (raw)
In-Reply-To: <20181002092047.14705-1-andi.shyti@intel.com>
Quoting Andi Shyti (2018-10-02 10:20:47)
> During driver load it's considered that the i915_driver_create()
> function fails only in case of insufficient memory. Indeed, in
> case of failure of i915_driver_create(), the load function
> returns indiscriminately -ENOMEM ignoring the real cause of
> failure.
Though if it is not ENOMEM, some stern words will be addressed to
whomever at fault.
> In i915_driver_create() get the consistent error value from
> drm_dev_init() and embed it in the pointer return value.
>
> Signed-off-by: Andi Shyti <andi.shyti@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-02 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 9:20 [PATCH v2] drm/i915: fix wrong error number report Andi Shyti
2018-10-02 11:15 ` ✓ Fi.CI.BAT: success for drm/i915: fix wrong error number report (rev2) Patchwork
2018-10-02 11:18 ` Chris Wilson [this message]
2018-10-02 12:38 ` [PATCH v2] drm/i915: fix wrong error number report Chris Wilson
2018-10-02 17:47 ` ✓ Fi.CI.IGT: success for drm/i915: fix wrong error number report (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153847912974.23109.16519605205193105207@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=andi.shyti@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=joonas.lahtinen@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.