From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2ECC00449 for ; Fri, 5 Oct 2018 10:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89A5C2064E for ; Fri, 5 Oct 2018 10:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89A5C2064E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbeJER5l (ORCPT ); Fri, 5 Oct 2018 13:57:41 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:51653 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727798AbeJER5l (ORCPT ); Fri, 5 Oct 2018 13:57:41 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1g8NpG-0005pP-7R; Fri, 05 Oct 2018 12:59:18 +0200 Message-ID: <1538737156.3545.22.camel@pengutronix.de> Subject: Re: [PATCH v2 4/4] PCI: imx: Add PME_Turn_Off support From: Philipp Zabel To: Lorenzo Pieralisi , Leonard Crestez Cc: Lucas Stach , Richard Zhu , Andrey Smirnov , Gustavo Pimentel , Jingoo Han , Bjorn Helgaas , Shawn Guo , Fabio Estevam , dl-linux-imx , "kernel@pengutronix.de" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Fri, 05 Oct 2018 12:59:16 +0200 In-Reply-To: <20181005102906.GA25651@red-moon> References: <37d60fe2119361381a6a81f439fa1c3ad29db45e.1538670431.git.leonard.crestez@nxp.com> <20181005102906.GA25651@red-moon> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lorenzo, On Fri, 2018-10-05 at 11:29 +0100, Lorenzo Pieralisi wrote: > On Thu, Oct 04, 2018 at 04:34:30PM +0000, Leonard Crestez wrote: > > When the root complex suspends it must send a PME_Turn_Off TLP. > > Implement this by asserting the "turnoff" reset. > > > > On imx7d this functionality is part of the SRC and exposed through the > > linux reset-controller subsystem. On imx6 equivalent bits are in the > > IOMUXC GPR area which the imx6-pcie driver accesses directly. > > Nit: I am merging the series, please define what SRC and GPR are so > that I can update the commit log accordingly, it must be clear to > anyone reading it. SRC is the System Reset Controller, which controls reset signals to all kinds of devices, among them the PCIe PHY. IOMUXC GPR is a General Purpose Register range in the IOMUXC (pinmux controller) that is used to control various signals all over the SoC. regards Philipp