From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:58042 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbeJFAgt (ORCPT ); Fri, 5 Oct 2018 20:36:49 -0400 From: Zhoujie Wu To: , CC: , Zhoujie Wu Subject: [PATCH v2] lightnvm: pblk: consider max hw sectors supported for max_write_pgs Date: Fri, 5 Oct 2018 10:39:21 -0700 Message-ID: <1538761161-6652-1-git-send-email-zjwu@marvell.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org When do GC, the number of read/write sectors are determined by max_write_pgs(see gc_rq preparation in pblk_gc_line_prepare_ws). Due to max_write_pgs doesn't consider max hw sectors supported by nvme controller(128K), which leads to GC tries to read 64 * 4K in one command, and see below error caused by pblk_bio_map_addr in function pblk_submit_read_gc. [ 2923.005376] pblk: could not add page to bio [ 2923.005377] pblk: could not allocate GC bio (18446744073709551604) Signed-off-by: Zhoujie Wu --- v2: Changed according to Javier's comments. Remove unneccessary comment and move the definition of bqueue to maintain ordering. drivers/lightnvm/pblk-init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index e357388..0ef9ac5 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -391,6 +391,7 @@ static void pblk_put_global_caches(void) static int pblk_core_init(struct pblk *pblk) { struct nvm_tgt_dev *dev = pblk->dev; + struct request_queue *bqueue = dev->q; struct nvm_geo *geo = &dev->geo; int ret, max_write_ppas; @@ -407,6 +408,8 @@ static int pblk_core_init(struct pblk *pblk) pblk->min_write_pgs = geo->ws_opt; max_write_ppas = pblk->min_write_pgs * geo->all_luns; pblk->max_write_pgs = min_t(int, max_write_ppas, NVM_MAX_VLBA); + pblk->max_write_pgs = min_t(int, pblk->max_write_pgs, + queue_max_hw_sectors(bqueue) / (geo->csecs >> 9)); pblk_set_sec_per_write(pblk, pblk->min_write_pgs); pblk->pad_dist = kcalloc(pblk->min_write_pgs - 1, sizeof(atomic64_t), -- 1.9.1