All of lore.kernel.org
 help / color / mirror / Atom feed
From: Firoz Khan <firoz.khan@linaro.org>
To: linux-parisc@vger.kernel.org,
	"James E . J . Bottomley" <jejb@parisc-linux.org>,
	Helge Deller <deller@gmx.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, arnd@arndb.de,
	deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org,
	firoz.khan@linaro.org
Subject: [PATCH v3 2/6] parisc: add __NR_Linux_syscalls along with __NR_syscalls
Date: Mon,  8 Oct 2018 10:46:37 +0530	[thread overview]
Message-ID: <1538975801-13735-3-git-send-email-firoz.khan@linaro.org> (raw)
In-Reply-To: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org>

__NR_Linux_syscalls macro holds the number of system call
exist in PARISC architecture. This macro is currently the
part of uapi/asm/unistd.h file. We have to change the value
of __NR_Linux_syscalls, if we add or delete a system call.

One of the patch in this patch series has a script which
will generate a uapi header based on syscall.tbl file. The
syscall.tbl file contains the number of system call inform-
ation. So we have two option to update __NR_Linux_syscalls
value.

1. Update __NR_Linux_syscalls in uapi/asm/unistd.h manually
   by counting the no.of system calls. No need to update
   __NR_Linux_syscalls until we either add a new system call
   or delete an existing system call.

2. We can keep this feature it above mentioned script, that
   will count the number of syscalls and keep it in a gener-
   ated file. In this case we don't need to explicitly update
   __NR_Linux_syscalls in asm/unistd.h file.

The 2nd option will be the recommended one. For that, I moved
the __NR_Linux_syscalls macro from uapi/asm/unistd.h to asm/
unistd.h. The macro __NR_syscalls also added for making the
name convention same across all architecture. While __NR_sys-
calls isn't strictly part of the uapi, having it as part of
the generated header to simplifies the implementation. We also
need to enclose this macro with #ifdef __KERNEL__ to avoid
side effects.

Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
 arch/parisc/include/asm/unistd.h      | 2 ++
 arch/parisc/include/uapi/asm/unistd.h | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/parisc/include/asm/unistd.h b/arch/parisc/include/asm/unistd.h
index 93fd9f6..d30fdbcb 100644
--- a/arch/parisc/include/asm/unistd.h
+++ b/arch/parisc/include/asm/unistd.h
@@ -4,6 +4,8 @@
 
 #include <uapi/asm/unistd.h>
 
+#define __NR_Linux_syscalls     __NR_syscalls
+
 #ifndef __ASSEMBLY__
 
 #define SYS_ify(syscall_name)   __NR_##syscall_name
diff --git a/arch/parisc/include/uapi/asm/unistd.h b/arch/parisc/include/uapi/asm/unistd.h
index bb52e12..f10d065 100644
--- a/arch/parisc/include/uapi/asm/unistd.h
+++ b/arch/parisc/include/uapi/asm/unistd.h
@@ -366,7 +366,9 @@
 #define __NR_statx		(__NR_Linux + 349)
 #define __NR_io_pgetevents	(__NR_Linux + 350)
 
-#define __NR_Linux_syscalls	(__NR_io_pgetevents + 1)
+#ifdef __KERNEL__
+#define __NR_syscalls           351
+#endif
 
 #define LINUX_GATEWAY_ADDR      0x100
 
-- 
1.9.1

  parent reply	other threads:[~2018-10-08  5:16 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  5:16 [PATCH v3 0/6] System call table generation support Firoz Khan
2018-10-08  5:16 ` Firoz Khan
2018-10-08  5:16 ` Firoz Khan
2018-10-08  5:16 ` [PATCH v3 1/6] parisc: move __IGNORE* entries to non uapi header Firoz Khan
2018-10-08  5:16 ` Firoz Khan [this message]
2018-10-08  5:16 ` [PATCH v3 3/6] parisc: add system call table generation support Firoz Khan
2018-10-08  7:33   ` Firoz Khan
2018-10-08 13:03     ` Eugene Syromiatnikov
2018-10-08 13:56       ` Arnd Bergmann
2018-10-09  5:35         ` Firoz Khan
2018-10-09  5:40           ` Firoz Khan
2018-10-09  7:47           ` Arnd Bergmann
2018-10-09  9:36             ` Firoz Khan
2018-10-09 11:28               ` Arnd Bergmann
2018-10-09 14:10                 ` Firoz Khan
2018-10-08  5:16 ` [PATCH v3 4/6] parisc: uapi header and system call table file generation Firoz Khan
2018-10-08 19:43   ` Helge Deller
2018-10-09  4:56     ` Firoz Khan
2018-10-09 20:13   ` Helge Deller
2018-10-11  6:10     ` Firoz Khan
2018-10-11  6:14       ` Firoz Khan
2018-10-11  6:48       ` Firoz Khan
2018-10-11  7:03         ` Arnd Bergmann
2018-10-11 10:27         ` Helge Deller
2018-10-11 15:01           ` Firoz Khan
2018-10-11  7:07       ` Arnd Bergmann
2018-10-11  8:30         ` Firoz Khan
2018-10-08  5:16 ` [PATCH v3 5/6] parisc: wire up rseq system call Firoz Khan
2018-10-08  5:36   ` Helge Deller
2018-10-08  5:52     ` Firoz Khan
2018-10-08  5:52       ` Firoz Khan
2018-10-08  5:52       ` Firoz Khan
2018-10-08  6:06       ` Helge Deller
2018-10-08  6:48         ` Firoz Khan
2018-10-08  8:23           ` Geert Uytterhoeven
2018-10-08  8:55             ` Firoz Khan
2018-10-08  8:58               ` Geert Uytterhoeven
2018-10-08  9:11                 ` Arnd Bergmann
2018-10-08  5:16 ` [PATCH v3 6/6] parisc: syscalls: Ignore nfsservctl for other architectures Firoz Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538975801-13735-3-git-send-email-firoz.khan@linaro.org \
    --to=firoz.khan@linaro.org \
    --cc=arnd@arndb.de \
    --cc=deepa.kernel@gmail.com \
    --cc=deller@gmx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@parisc-linux.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.