[U-Boot] [PATCH] nand: atmel: Initialize pmecc smu with correct size

From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand: atmel: Initialize pmecc smu with correct size
Date: Mon,  8 Oct 2018 02:27:44 -0700	[thread overview]
Message-ID: <1538990864-26421-1-git-send-email-bmeng.cn@gmail.com> (raw)

Currently in pmecc_get_sigma(), the code tries to clear the memory
pointed by smu with wrong size 'sizeof(int16_t) * ARRAY_SIZE(smu)'.
Since smu is actually a pointer, not an array, so ARRAY_SIZE(smu)
does not generate correct size to be cleared.

In fact, GCC 8.1.0 reports a warning against it:

error: division 'sizeof (int16_t * {aka short int *}) / sizeof (int16_t
{aka short int})' does not compute the number of array elements
[-Werror=sizeof-pointer-div]

Fix it by using the correct size.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---

 drivers/mtd/nand/raw/atmel_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/atmel_nand.c b/drivers/mtd/nand/raw/atmel_nand.c
index a5b76e1..31ad2cf 100644
--- a/drivers/mtd/nand/raw/atmel_nand.c
+++ b/drivers/mtd/nand/raw/atmel_nand.c
@@ -249,7 +249,7 @@ static void pmecc_get_sigma(struct mtd_info *mtd)
 	int diff;
 
 	/* Init the Sigma(x) */
-	memset(smu, 0, sizeof(int16_t) * ARRAY_SIZE(smu));
+	memset(smu, 0, sizeof(int16_t) * num * (cap + 2));
 
 	dmu_0_count = 0;
 
-- 
2.7.4
