From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH net-next 00/19] Add support for Aquantia AQtion USB to 5/2.5GbE devices Date: Mon, 08 Oct 2018 16:21:36 +0200 Message-ID: <1539008496.10342.27.camel@suse.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" To: Igor Russkikh , "David S . Miller" Return-path: Received: from mx2.suse.de ([195.135.220.15]:57346 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726159AbeJHVmZ (ORCPT ); Mon, 8 Oct 2018 17:42:25 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Fr, 2018-10-05 at 10:24 +0000, Igor Russkikh wrote: > This patchset introduces support for new multigig ethernet to USB dongle, > developed jointly by Aquantia (Phy) and ASIX (USB MAC). > > The driver has similar structure with other ASIX MAC drivers (AX88179), but > with a number of important differences: > - Driver supports both direct Phy and custom firmware interface for Phy > programming. This is due to different firmware modules available with this > product. > - Driver handles new 2.5G/5G link speed configuration and reporting. > - Device support all speeds from 100M up to 5G. > - Device supports MTU up to 16K. > > Device supports various standard networking features, like > checksum offloads, vlan tagging/filtering, TSO. > > The code of this driver is based on original ASIX sources and was extended > by Aquantia for 5G multigig support. Thank you for the driver. It is good to see drivers for cool hardware. Unfortunately there have been a few issues I have tried to point out in reviews. Please fix them and resubmit. Regards Oliver