All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH 2/3] ext4: hard fail dax mount on unsupported devices
Date: Mon,  8 Oct 2018 14:32:48 -0500	[thread overview]
Message-ID: <1539027169-23332-3-git-send-email-sandeen@sandeen.net> (raw)
In-Reply-To: <1539027169-23332-1-git-send-email-sandeen@sandeen.net>

As dax inches closer to production use, an administrator should not
be surprised by silently disabling the feature they asked for.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
 fs/ext4/super.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5863fd2..bf0bea5 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3821,12 +3821,12 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
 		if (ext4_has_feature_inline_data(sb)) {
 			ext4_msg(sb, KERN_ERR, "Cannot use DAX on a filesystem"
 					" that may contain inline data");
-			sbi->s_mount_opt &= ~EXT4_MOUNT_DAX;
+			goto failed_mount;
 		}
 		if (!bdev_dax_supported(sb->s_bdev, blocksize)) {
 			ext4_msg(sb, KERN_ERR,
-				"DAX unsupported by block device. Turning off DAX.");
-			sbi->s_mount_opt &= ~EXT4_MOUNT_DAX;
+				"DAX unsupported by block device.");
+			goto failed_mount;
 		}
 	}
 
-- 
1.8.3.1

  parent reply	other threads:[~2018-10-09  2:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 19:32 [PATCH 0/3] ext2, ext4, xfs: hard fail dax mount on unsupported devices Eric Sandeen
2018-10-08 19:32 ` [PATCH 1/3] " Eric Sandeen
2018-10-08 22:10   ` Dave Chinner
2018-10-08 19:32 ` Eric Sandeen [this message]
2018-12-04  5:48   ` [PATCH 2/3] ext4: " Theodore Y. Ts'o
2018-10-08 19:32 ` [PATCH 3/3] ext2: " Eric Sandeen
2018-10-11 10:36 ` [PATCH 0/3] ext2, ext4, xfs: " Jan Kara
2018-10-11 18:08   ` Dan Williams
2018-10-11 18:38     ` Eric Sandeen
2018-10-12  2:21       ` Theodore Y. Ts'o
2018-10-12  8:21       ` Christoph Hellwig
2018-10-13 16:05         ` Ross Zwisler
2018-10-17 19:42           ` Eric Sandeen
2018-10-17 19:51             ` Ross Zwisler
2018-10-17 19:52             ` Dan Williams
2018-10-17 21:31             ` Jeff Moyer
2018-10-17 21:44               ` Dan Williams
2018-10-18  1:05                 ` Dave Chinner
2018-10-18  2:01                   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539027169-23332-3-git-send-email-sandeen@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.