From: Robin Gong <yibin.gong@nxp.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: [PATCH v1 3/3] spi: imx: use PIO mode if size is small
Date: Wed, 10 Oct 2018 10:32:48 +0000 [thread overview]
Message-ID: <1539196453-8704-4-git-send-email-yibin.gong@nxp.com> (raw)
In-Reply-To: <1539196453-8704-1-git-send-email-yibin.gong@nxp.com>
Use PIO mode instead if size is smaller than fifo size, since
dma may be less efficient.
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
drivers/spi/spi-imx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 037abbb..dd1ce12 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -224,6 +224,9 @@ static bool spi_imx_can_dma(struct spi_master *master, struct spi_device *spi,
if (spi_imx->slave_mode)
return false;
+ if (transfer->len < spi_imx->devtype_data->fifo_size)
+ return false;
+
spi_imx->dynamic_burst = 0;
return true;
--
2.7.4
next prev parent reply other threads:[~2018-10-10 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 10:32 [PATCH v1 0/3] Correct wml setting for spi-imx in dma mode Robin Gong
2018-10-10 10:32 ` [PATCH v1 1/3] spi: imx: move wml setting to later than setup_transfer Robin Gong
2018-10-12 17:01 ` Applied "spi: imx: move wml setting to later than setup_transfer" to the spi tree Mark Brown
2018-10-12 17:01 ` Mark Brown
2018-10-10 10:32 ` [PATCH v1 2/3] spi: imx: correct wml as the last sg length Robin Gong
2018-10-10 10:32 ` Robin Gong [this message]
2018-10-12 17:01 ` Applied "spi: imx: use PIO mode if size is small" to the spi tree Mark Brown
2018-10-12 17:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539196453-8704-4-git-send-email-yibin.gong@nxp.com \
--to=yibin.gong@nxp.com \
--cc=broonie@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.