All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
	"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"barakw@amazon.com" <barakw@amazon.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"talel@amazon.com" <talel@amazon.com>,
	"ronenk@amazon.com" <ronenk@amazon.com>
Subject: Re: [PATCH 1/2] dt-bindings: spi: dw: add cs-override property
Date: Wed, 10 Oct 2018 22:52:58 +0000	[thread overview]
Message-ID: <1539211978.1944.46.camel@impinj.com> (raw)
In-Reply-To: <20181010122710.GE6294@sirena.org.uk>

On Wed, 2018-10-10 at 13:27 +0100, Mark Brown wrote:
> 
> That's great and we get to reuse all the driver code with a quirk (a
> quirk which fixes the hardware to be more compatible with devices, this
> is a really good hardware change).  Ideally we'd be able to enumerate
> things like IP versions and options from hardware but that's a more
> entertaining problem.

Might well be possible here.  There are an id code and version
registers that could be used.  Did anyone have the foresight to change
them would modifying the IP is the question.


> Having said all this if there are production systems using this
> property, especially production systems where people other than the
> system integrator can realistically deploy their own kernel separate to
> the device tree, then supporting those existing DTs even if they're not
> doing the ideal thing might be the best thing.  You mentioned that this
> might be the case, can you check what the status is there please?

I've developed systems that used chips with this SPI master.  I used
GPIO chip selects to work around the existing behavior and would not be
negatively affected if someone fixed this bug.

There's also another quirk where certain phase/polarity combination
make it generate a CS pulse between each word.

IMHO, Linux SPI has a specification for how it works.  Setup an xfer a
certain way and you get a certain waveform from the master.  If the
master generates the wrong waveform then it's a bug.  Designers should
know better than to design a system that depends on a bug never being
fixed and be caught off guard when it is.  If you want CS to turn off
whenever the FIFO is empty (why???) then extend the spec to encompass
the behavior you want.  Like how "pulse between words" can be specified
now.

  reply	other threads:[~2018-10-10 22:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  7:08 [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Talel Shenhar
2018-10-10  7:08 ` Talel Shenhar
2018-10-10  7:08 ` [PATCH 2/2] dw: spi: add 'cs-override' DT property support Talel Shenhar
2018-10-10  7:08   ` Talel Shenhar
2018-10-10 10:18 ` [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Mark Brown
2018-10-10 10:34   ` Talel Shenhar
2018-10-10 10:34     ` Talel Shenhar
2018-10-10 11:29     ` David Woodhouse
2018-10-10 11:29       ` David Woodhouse
2018-10-10 11:23   ` Talel Shenhar
2018-10-10 11:23     ` Talel Shenhar
2018-10-10 11:27     ` Mark Brown
2018-10-10 11:58       ` Woodhouse, David
2018-10-10 12:27         ` Mark Brown
2018-10-10 22:52           ` Trent Piepho [this message]
2018-10-10 15:15 ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Alpine spi controller Talel Shenhar
2018-10-10 15:15   ` Talel Shenhar
2018-10-10 15:15   ` [PATCH 2/2] dw: spi: add support " Talel Shenhar
2018-10-10 15:15     ` Talel Shenhar
2018-10-10 22:08     ` Trent Piepho
2018-10-11 11:20       ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Amazon's " Talel Shenhar
2018-10-11 11:20         ` Talel Shenhar
2018-10-11 11:20         ` [PATCH 2/2] dw: spi: add support " Talel Shenhar
2018-10-11 11:20           ` Talel Shenhar
2018-10-11 14:58           ` Applied "dw: spi: add support for Amazon's Alpine spi controller" to the spi tree Mark Brown
2018-10-11 14:58             ` Mark Brown
2018-10-11 14:58             ` Mark Brown
2018-10-11 13:44         ` [PATCH 1/2] dt-bindings: spi: dw: add compatible for Amazon's Alpine spi controller Mark Brown
2018-10-11 14:58         ` Applied "spi: dw: add compatible for Amazon's Alpine spi controller" to the spi tree Mark Brown
2018-10-11 14:58           ` Mark Brown
2018-10-11 14:58           ` Mark Brown
2018-10-11 11:22       ` [PATCH 2/2] dw: spi: add support for Alpine spi controller Talel Shenhar
2018-10-10 22:21 ` [PATCH 1/2] dt-bindings: spi: dw: add cs-override property Trent Piepho
2018-10-11  7:39   ` Talel Shenhar
2018-10-11  7:39     ` Talel Shenhar
2018-10-11 13:46   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539211978.1944.46.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=barakw@amazon.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw@amazon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=ronenk@amazon.com \
    --cc=talel@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.