From: "Darrick J. Wong" <darrick.wong@oracle.com> To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: [PATCH 25/25] xfs: remove redundant remap partial EOF block checks Date: Wed, 10 Oct 2018 21:15:26 -0700 [thread overview] Message-ID: <153923132645.5546.97372209609060021.stgit@magnolia> (raw) In-Reply-To: <153923113649.5546.9840926895953408273.stgit@magnolia> From: Darrick J. Wong <darrick.wong@oracle.com> Now that we've moved the partial EOF block checks to the VFS helpers, we can remove the redundantn functionality from XFS. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- fs/xfs/xfs_reflink.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 12a1fe92454e..4450443f1148 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1307,8 +1307,6 @@ xfs_reflink_remap_prep( struct inode *inode_out = file_inode(file_out); struct xfs_inode *dest = XFS_I(inode_out); bool same_inode = (inode_in == inode_out); - bool is_dedupe = (remap_flags & RFR_SAME_DATA); - u64 blkmask = i_blocksize(inode_in) - 1; ssize_t ret; /* Lock both files against IO */ @@ -1336,24 +1334,6 @@ xfs_reflink_remap_prep( if (ret <= 0) goto out_unlock; - /* - * If the dedupe data matches, chop off the partial EOF block - * from the source file so we don't try to dedupe the partial - * EOF block. - */ - if (is_dedupe) { - *len &= ~blkmask; - } else if (*len & blkmask) { - /* - * The user is attempting to share a partial EOF block, - * if it's inside the destination EOF then reject it. - */ - if (pos_out + *len < i_size_read(inode_out)) { - ret = -EINVAL; - goto out_unlock; - } - } - /* Attach dquots to dest inode before changing block map */ ret = xfs_qm_dqattach(dest); if (ret)
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com> To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH 25/25] xfs: remove redundant remap partial EOF block checks Date: Wed, 10 Oct 2018 21:15:26 -0700 [thread overview] Message-ID: <153923132645.5546.97372209609060021.stgit@magnolia> (raw) In-Reply-To: <153923113649.5546.9840926895953408273.stgit@magnolia> From: Darrick J. Wong <darrick.wong@oracle.com> Now that we've moved the partial EOF block checks to the VFS helpers, we can remove the redundantn functionality from XFS. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> --- fs/xfs/xfs_reflink.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 12a1fe92454e..4450443f1148 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1307,8 +1307,6 @@ xfs_reflink_remap_prep( struct inode *inode_out = file_inode(file_out); struct xfs_inode *dest = XFS_I(inode_out); bool same_inode = (inode_in == inode_out); - bool is_dedupe = (remap_flags & RFR_SAME_DATA); - u64 blkmask = i_blocksize(inode_in) - 1; ssize_t ret; /* Lock both files against IO */ @@ -1336,24 +1334,6 @@ xfs_reflink_remap_prep( if (ret <= 0) goto out_unlock; - /* - * If the dedupe data matches, chop off the partial EOF block - * from the source file so we don't try to dedupe the partial - * EOF block. - */ - if (is_dedupe) { - *len &= ~blkmask; - } else if (*len & blkmask) { - /* - * The user is attempting to share a partial EOF block, - * if it's inside the destination EOF then reject it. - */ - if (pos_out + *len < i_size_read(inode_out)) { - ret = -EINVAL; - goto out_unlock; - } - } - /* Attach dquots to dest inode before changing block map */ ret = xfs_qm_dqattach(dest); if (ret)
next prev parent reply other threads:[~2018-10-11 4:15 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-11 4:12 [PATCH v3 00/25] fs: fixes for serious clone/dedupe problems Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:12 ` [PATCH 01/25] xfs: add a per-xfs trace_printk macro Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 13:39 ` Christoph Hellwig 2018-10-11 13:39 ` [Ocfs2-devel] " Christoph Hellwig 2018-10-11 23:34 ` Darrick J. Wong 2018-10-11 23:34 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:12 ` [PATCH 02/25] vfs: vfs_clone_file_prep_inodes should return EINVAL for a clone from beyond EOF Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 13:40 ` Christoph Hellwig 2018-10-11 13:40 ` [Ocfs2-devel] " Christoph Hellwig 2018-10-11 4:12 ` [PATCH 03/25] vfs: check file ranges before cloning files Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 13:42 ` Christoph Hellwig 2018-10-11 13:42 ` [Ocfs2-devel] " Christoph Hellwig 2018-10-11 14:13 ` Amir Goldstein 2018-10-11 4:12 ` [PATCH 04/25] vfs: strengthen checking of file range inputs to generic_remap_checks Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 13:43 ` Christoph Hellwig 2018-10-11 13:43 ` [Ocfs2-devel] " Christoph Hellwig 2018-10-11 4:12 ` [PATCH 05/25] vfs: avoid problematic remapping requests into partial EOF block Darrick J. Wong 2018-10-11 4:12 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-12 0:16 ` Dave Chinner 2018-10-12 0:16 ` [Ocfs2-devel] " Dave Chinner 2018-10-12 16:07 ` Darrick J. Wong 2018-10-12 16:07 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-12 20:22 ` Filipe Manana 2018-10-12 20:22 ` Filipe Manana 2018-10-15 0:31 ` Dave Chinner 2018-10-15 0:31 ` [Ocfs2-devel] " Dave Chinner 2018-11-02 12:04 ` Filipe Manana 2018-11-02 12:04 ` Filipe Manana 2018-11-02 17:42 ` Darrick J. Wong 2018-11-02 17:42 ` Darrick J. Wong 2018-11-02 17:42 ` [Ocfs2-devel] " Darrick J. Wong 2018-11-02 18:18 ` Filipe Manana 2018-11-02 19:05 ` Filipe Manana 2018-10-11 4:13 ` [PATCH 06/25] vfs: skip zero-length dedupe requests Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 07/25] vfs: combine the clone and dedupe into a single remap_file_range Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 08/25] vfs: rename vfs_clone_file_prep to be more descriptive Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 09/25] vfs: rename clone_verify_area to remap_verify_area Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 10/25] vfs: create generic_remap_file_range_touch to update inode metadata Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 11/25] vfs: pass remap flags to generic_remap_file_range_prep Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 12/25] vfs: pass remap flags to generic_remap_checks Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:13 ` [PATCH 13/25] vfs: make remap_file_range functions take and return bytes completed Darrick J. Wong 2018-10-11 4:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 14/25] vfs: plumb RFR_* remap flags through the vfs clone functions Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 15/25] vfs: plumb RFR_* remap flags through the vfs dedupe functions Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 16/25] vfs: make remapping to source file eof more explicit Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 17/25] vfs: enable remap callers that can handle short operations Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 5:15 ` Amir Goldstein 2018-10-11 16:04 ` Darrick J. Wong 2018-10-11 16:04 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 16:05 ` [PATCH v2 " Darrick J. Wong 2018-10-11 16:05 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 18/25] vfs: hide file range comparison function Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 19/25] vfs: implement opportunistic short dedupe Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 20/25] ocfs2: truncate page cache for clone destination file before remapping Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:14 ` [PATCH 21/25] ocfs2: fix pagecache truncation prior to reflink Darrick J. Wong 2018-10-11 4:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:15 ` [PATCH 22/25] ocfs2: support partial clone range and dedupe range Darrick J. Wong 2018-10-11 4:15 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:15 ` [PATCH 23/25] xfs: fix pagecache truncation prior to reflink Darrick J. Wong 2018-10-11 4:15 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-12 1:15 ` Dave Chinner 2018-10-12 1:15 ` [Ocfs2-devel] " Dave Chinner 2018-10-11 4:15 ` [PATCH 24/25] xfs: support returning partial reflink results Darrick J. Wong 2018-10-11 4:15 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-12 1:22 ` Dave Chinner 2018-10-12 1:22 ` [Ocfs2-devel] " Dave Chinner 2018-10-12 16:06 ` Darrick J. Wong 2018-10-12 16:06 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-11 4:15 ` Darrick J. Wong [this message] 2018-10-11 4:15 ` [Ocfs2-devel] [PATCH 25/25] xfs: remove redundant remap partial EOF block checks Darrick J. Wong 2018-10-12 1:22 ` Dave Chinner 2018-10-12 1:22 ` [Ocfs2-devel] " Dave Chinner 2018-10-11 8:33 ` [PATCH v3 00/25] fs: fixes for serious clone/dedupe problems Amir Goldstein 2018-10-11 15:55 ` Darrick J. Wong 2018-10-11 15:55 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-13 0:05 [PATCH v4 " Darrick J. Wong 2018-10-13 0:08 ` [PATCH 25/25] xfs: remove redundant remap partial EOF block checks Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=153923132645.5546.97372209609060021.stgit@magnolia \ --to=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nfs@vger.kernel.org \ --cc=linux-unionfs@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=ocfs2-devel@oss.oracle.com \ --cc=sandeen@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.