From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E92DECDE32 for ; Wed, 17 Oct 2018 07:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41E1B21526 for ; Wed, 17 Oct 2018 07:33:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SDjzy7m4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41E1B21526 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbeJQP2M (ORCPT ); Wed, 17 Oct 2018 11:28:12 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44870 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbeJQP2M (ORCPT ); Wed, 17 Oct 2018 11:28:12 -0400 Received: by mail-pl1-f193.google.com with SMTP id p25-v6so12246960pli.11 for ; Wed, 17 Oct 2018 00:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:to:from:in-reply-to:cc :references:message-id:user-agent:subject:date; bh=hCE0ZcZdwgZvtFE0zbl/Eo1rYMv4l6e4nGtVlRuQEOk=; b=SDjzy7m4GXEC4sE0OnPI/ao1SvPUzTL4COpSknDCaPFSJiWa9fSNQjfbm2d5IdldFN jirezX2XXOdRCLbqIZcDMMXIgMjt64wW5ie+t7L9U+nTgWY5y2U1hITz087zYY04XYLB VIAKcWtkzxcRvMRsbo8XReaFQUUZGmTO9kUlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:to:from :in-reply-to:cc:references:message-id:user-agent:subject:date; bh=hCE0ZcZdwgZvtFE0zbl/Eo1rYMv4l6e4nGtVlRuQEOk=; b=er0VT7beYhxulOhhFJIoyBN8q6gCLmF6YBX9M11cwV/5hQT3URjbJU3AgAgLwVEyNv x4mLNWMN6idySMwLupCtnM0UzhHKbpW3We+uFg7imqfgGwF2TZ8r3LvXYZGJEL/XHJTt Z/t+BO7nQDP1ALlV0nLRW8zxjOJNVXbrmAEPDL2sUDIV8TIOPDMdnbGBwiYBFa4bn5tF 6ropnjbm2EM4R0FuOwAemHrNHlj9umbBx6t7FReUQMpiy42XN9N/zNrN42GXVcvhEg0/ cbyqFA3fIrRUZSznRE7/OeXHNWIJeD1uHW7oQMAJ/WR9PW23whjnfQzvynziiGinw0el o6fg== X-Gm-Message-State: ABuFfoinf9f/HZdXgnCAcqV64KN8hqZ7Yh7Kbef0l5PuzbnoV8y+4wsT 26XUf1ftSPc8BNuzjST1/kDRZQ== X-Google-Smtp-Source: ACcGV62l2exbH/0mN9A19UJQarFjJZygTcIHpiPQC+YXSE38ryK8K+kGHyOI9d9TRx1xt/3mwpDMUQ== X-Received: by 2002:a17:902:ab8a:: with SMTP id f10-v6mr25019336plr.203.1539761630747; Wed, 17 Oct 2018 00:33:50 -0700 (PDT) Received: from localhost ([2620:15c:202:1:fed3:9637:a13a:6c15]) by smtp.gmail.com with ESMTPSA id s2-v6sm21640860pfk.133.2018.10.17.00.33.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Oct 2018 00:33:49 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Govind Singh , andy.gross@linaro.org, ath10k@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-wireless@vger.kernel.org, robh+dt@kernel.org From: Stephen Boyd In-Reply-To: <1539172376-19269-3-git-send-email-govinds@codeaurora.org> Cc: Govind Singh References: <1539172376-19269-1-git-send-email-govinds@codeaurora.org> <1539172376-19269-3-git-send-email-govinds@codeaurora.org> Message-ID: <153976162862.5275.4810472671573539341@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Date: Wed, 17 Oct 2018 00:33:48 -0700 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Quoting Govind Singh (2018-10-10 04:52:55) > @@ -1403,5 +1408,26 @@ > status =3D "disabled"; > }; > }; > + > + wifi: wifi@18800000 { > + compatible =3D "qcom,wcn3990-wifi"; > + status =3D "disabled"; > + reg =3D <0x18800000 0x800000>; > + reg-names =3D "membase"; > + memory-region =3D <&wlan_msa_mem>; > + interrupts =3D > + <0 413 0 /* CE0 */ >, Please specify these as GIC_SPI and give trigger types (level high I guess?). I'd also drop the comment and add interrupt-names to match the comment. It's self documenting that way. > + <0 414 0 /* CE1 */ >, > + <0 415 0 /* CE2 */ >, > + <0 416 0 /* CE3 */ >, > + <0 417 0 /* CE4 */ >, > + <0 418 0 /* CE5 */ >, > + <0 420 0 /* CE6 */ >, > + <0 421 0 /* CE7 */ >, > + <0 422 0 /* CE8 */ >, > + <0 423 0 /* CE9 */ >, > + <0 424 0 /* CE10 */ >, > + <0 425 0 /* CE11 */ >; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Date: Wed, 17 Oct 2018 00:33:48 -0700 Message-ID: <153976162862.5275.4810472671573539341@swboyd.mtv.corp.google.com> References: <1539172376-19269-1-git-send-email-govinds@codeaurora.org> <1539172376-19269-3-git-send-email-govinds@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1539172376-19269-3-git-send-email-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: Govind Singh List-Id: linux-arm-msm@vger.kernel.org Quoting Govind Singh (2018-10-10 04:52:55) > @@ -1403,5 +1408,26 @@ > status =3D "disabled"; > }; > }; > + > + wifi: wifi@18800000 { > + compatible =3D "qcom,wcn3990-wifi"; > + status =3D "disabled"; > + reg =3D <0x18800000 0x800000>; > + reg-names =3D "membase"; > + memory-region =3D <&wlan_msa_mem>; > + interrupts =3D > + <0 413 0 /* CE0 */ >, Please specify these as GIC_SPI and give trigger types (level high I guess?). I'd also drop the comment and add interrupt-names to match the comment. It's self documenting that way. > + <0 414 0 /* CE1 */ >, > + <0 415 0 /* CE2 */ >, > + <0 416 0 /* CE3 */ >, > + <0 417 0 /* CE4 */ >, > + <0 418 0 /* CE5 */ >, > + <0 420 0 /* CE6 */ >, > + <0 421 0 /* CE7 */ >, > + <0 422 0 /* CE8 */ >, > + <0 423 0 /* CE9 */ >, > + <0 424 0 /* CE10 */ >, > + <0 425 0 /* CE11 */ >; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCgLB-0004E6-TD for ath10k@lists.infradead.org; Wed, 17 Oct 2018 07:34:08 +0000 Received: by mail-pl1-x643.google.com with SMTP id v5-v6so12247512plz.13 for ; Wed, 17 Oct 2018 00:33:51 -0700 (PDT) MIME-Version: 1.0 From: Stephen Boyd In-Reply-To: <1539172376-19269-3-git-send-email-govinds@codeaurora.org> References: <1539172376-19269-1-git-send-email-govinds@codeaurora.org> <1539172376-19269-3-git-send-email-govinds@codeaurora.org> Message-ID: <153976162862.5275.4810472671573539341@swboyd.mtv.corp.google.com> Subject: Re: [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Date: Wed, 17 Oct 2018 00:33:48 -0700 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Govind Singh , andy.gross@linaro.org, ath10k@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-wireless@vger.kernel.org, robh+dt@kernel.org Quoting Govind Singh (2018-10-10 04:52:55) > @@ -1403,5 +1408,26 @@ > status = "disabled"; > }; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + status = "disabled"; > + reg = <0x18800000 0x800000>; > + reg-names = "membase"; > + memory-region = <&wlan_msa_mem>; > + interrupts = > + <0 413 0 /* CE0 */ >, Please specify these as GIC_SPI and give trigger types (level high I guess?). I'd also drop the comment and add interrupt-names to match the comment. It's self documenting that way. > + <0 414 0 /* CE1 */ >, > + <0 415 0 /* CE2 */ >, > + <0 416 0 /* CE3 */ >, > + <0 417 0 /* CE4 */ >, > + <0 418 0 /* CE5 */ >, > + <0 420 0 /* CE6 */ >, > + <0 421 0 /* CE7 */ >, > + <0 422 0 /* CE8 */ >, > + <0 423 0 /* CE9 */ >, > + <0 424 0 /* CE10 */ >, > + <0 425 0 /* CE11 */ >; _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k