From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/6] drm/i915/guc: drop negative doorbell alloc selftest
Date: Thu, 18 Oct 2018 13:43:21 +0100 [thread overview]
Message-ID: <153986660153.19935.3893925447134042914@skylake-alporthouse-com> (raw)
In-Reply-To: <op.zq2xx7ijxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
Quoting Michal Wajdeczko (2018-10-18 13:21:33)
> On Thu, 18 Oct 2018 02:46:05 +0200, Daniele Ceraolo Spurio
> <daniele.ceraolospurio@intel.com> wrote:
>
> > The test requires driver tweaks to avoid causing error messages
> > on intentionally-triggered errors and to stop accessing non
> > existing register. However, this is a pure GuC FW interface test
> > and should be covered by FW validation, so it isn't really worth
> > tweaking the driver for it and we're better off dropping it instead.
> >
> > Testing the driver running out of doorbells is already covered by
> > igt_guc_doorbells
> >
> > Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > ---
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
And dropped from testing, thanks.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-18 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 0:46 [PATCH v2 1/6] drm/i915/guc: drop negative doorbell alloc selftest Daniele Ceraolo Spurio
2018-10-18 0:46 ` [PATCH v2 2/6] drm/i915/guc: rename __create/destroy_doorbell Daniele Ceraolo Spurio
2018-10-18 0:46 ` [PATCH v2 3/6] drm/i915/guc: reserve the doorbell before selecting the cacheline Daniele Ceraolo Spurio
2018-10-18 0:46 ` [PATCH v2 4/6] drm/i915/guc: doorbell checking cleanup Daniele Ceraolo Spurio
2018-10-18 12:50 ` Michal Wajdeczko
2018-10-18 23:10 ` [PATCH v3] " Daniele Ceraolo Spurio
2018-10-19 10:22 ` Michal Wajdeczko
2018-10-18 0:46 ` [PATCH v2 5/6] drm/i915/guc: fix comment about fallback to execlists Daniele Ceraolo Spurio
2018-10-18 12:51 ` Michal Wajdeczko
2018-10-18 0:46 ` [PATCH v2 6/6] HAX enable GuC for CI Daniele Ceraolo Spurio
2018-10-18 1:07 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest Patchwork
2018-10-18 1:32 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-18 12:21 ` [PATCH v2 1/6] " Michal Wajdeczko
2018-10-18 12:43 ` Chris Wilson [this message]
2018-10-18 23:22 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest (rev2) Patchwork
2018-10-18 23:44 ` ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153986660153.19935.3893925447134042914@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.