All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, amarkovic@wavecomp.com
Subject: [Qemu-devel] [PULL v2 27/28] target/mips: Fix misplaced 'break' in handling of NM_SHRA_R_PH
Date: Thu, 18 Oct 2018 20:47:52 +0200	[thread overview]
Message-ID: <1539888473-16340-28-git-send-email-aleksandar.markovic@rt-rk.com> (raw)
In-Reply-To: <1539888473-16340-1-git-send-email-aleksandar.markovic@rt-rk.com>

From: Stefan Markovic <smarkovic@wavecomp.com>

Fix misplaced 'break' in handling of NM_SHRA_R_PH. Found by
Coverity (CID 1395627).

Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>
Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
 target/mips/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index 2890219..12f2aec 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -19970,8 +19970,8 @@ static void gen_pool32a5_nanomips_insn(DisasContext *ctx, int opc,
         case 0:
             /* SHRA_PH */
             gen_helper_shra_ph(v1_t, t0, v1_t);
-            break;
             gen_store_gpr(v1_t, rt);
+            break;
         case 1:
             /* SHRA_R_PH */
             gen_helper_shra_r_ph(v1_t, t0, v1_t);
-- 
2.7.4

  parent reply	other threads:[~2018-10-18 18:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-18 18:47 [Qemu-devel] [PULL v2 00/28] MIPS queue October 2018, part 1, v2 Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 01/28] mailmap: Add an item for Yongbok Kim Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 02/28] elf: Fix PT_MIPS_XXX constants Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 03/28] elf: Add MIPS_ABI_FP_XXX constants Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 04/28] elf: Add Mips_elf_abiflags_v0 structure Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 05/28] elf: Fix comments to EF_MIPS_MACH_xxx constants Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 06/28] linux-user: Add MIPS-specific prctl() options Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 07/28] linux-user: Add infrastructure for handling MIPS-specific prctl() Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 08/28] target/mips: Add a comment with an overview of CP0 registers Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 09/28] target/mips: Add a comment before each CP0 register section in cpu.h Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 10/28] target/mips: Add basic description of MXU ASE Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 11/28] target/mips: Add assembler mnemonics list for " Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 12/28] target/mips: Add organizational chart of " Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 13/28] target/mips: Add opcode values " Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 14/28] target/mips: Increase 'supported ISAs/ASEs' flag holder size Aleksandar Markovic
2018-10-19 11:46   ` Philippe Mathieu-Daudé
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 15/28] target/mips: Reorganize bit definitions for insn_flags (ISAs/ASEs flags) Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 16/28] target/mips: Add bit definitions for DSP R3 ASE Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 17/28] target/mips: Add availability control " Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 18/28] target/mips: Improve DSP R2/R3-related naming Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 19/28] target/mips: Add CP0 Config2 to DisasContext Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 20/28] target/mips: Add CP0 PWBase register Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 21/28] target/mips: Add CP0 PWField register Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 22/28] target/mips: Add CP0 PWSize register Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 23/28] target/mips: Add CP0 PWCtl register Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 24/28] target/mips: Add reset state for PWSize and PWField registers Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 25/28] target/mips: Implement hardware page table walker for MIPS32 Aleksandar Markovic
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 26/28] target/mips: Fix emulation of microMIPS R6 <SELEQZ|SELNEZ>.<D|S> Aleksandar Markovic
2018-10-18 18:47 ` Aleksandar Markovic [this message]
2018-10-18 18:47 ` [Qemu-devel] [PULL v2 28/28] target/mips: Add opcodes for nanoMIPS EVA instructions Aleksandar Markovic
2018-10-19 10:19 ` [Qemu-devel] [PULL v2 00/28] MIPS queue October 2018, part 1, v2 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539888473-16340-28-git-send-email-aleksandar.markovic@rt-rk.com \
    --to=aleksandar.markovic@rt-rk.com \
    --cc=amarkovic@wavecomp.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.