All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Alexandru Avadanii <Alexandru.Avadanii@enea.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: svc-armband <armband@enea.com>, Jeff Cody <jcody@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] rbd: Possible regression in 2.9 RCs
Date: Thu, 30 Mar 2017 20:22:05 -0500	[thread overview]
Message-ID: <153e27df-ed6d-f562-9831-9790b584beb1@redhat.com> (raw)
In-Reply-To: <058D52979F67BF47BCD9EA78EAECA6DC7779F35F@SESTOEX04.enea.se>

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

On 03/30/2017 08:05 PM, Alexandru Avadanii wrote:
> c7cacb3e7a2e9fdf929c993b98268e4179147cbb is the first bad commit
>     block/rbd: parse all options via bdrv_parse_filename

Yep, my bisect finished about 2 minutes after your email on the same
spot. I'm working on a patch.  I can reproduce the problem with a mere:

./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio
-drive
'file=rbd:volumes/volume-ea141b5c-cdb3-4765-910d-e7008b209a70:id=compute:key=AQAVkvxXAAAAABAA9ZxWFYdRmV+DSwKr7BKKXg==:auth_supported=cephx\;none:mon_host=192.168.1.2\:6789,format=raw,if=none,id=drive-virtio-disk0,serial=ea141b5c-cdb3-4765-910d-e7008b209a70,cache=writeback'

the good behavior (on my setup) just hangs trying to connect to a
non-existent machine, the bad behavior gets rather-badly misparsed
(splitting the escaped : in the host:port portion as if the port were
the next key-value pair) resulting in an instant error message. I don't
have an actual RBD setup for testing the fix, but will cc you on the
patch that I propose once I have something.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2017-03-31  1:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 23:42 [Qemu-devel] rbd: Possible regression in 2.9 RCs Alexandru Avadanii
2017-03-31  0:39 ` Eric Blake
2017-03-31  0:52   ` Alexandru Avadanii
2017-03-31  1:05   ` Alexandru Avadanii
2017-03-31  1:22     ` Eric Blake [this message]
2017-03-31  2:08       ` Eric Blake
2017-03-31  3:54         ` Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153e27df-ed6d-f562-9831-9790b584beb1@redhat.com \
    --to=eblake@redhat.com \
    --cc=Alexandru.Avadanii@enea.com \
    --cc=armband@enea.com \
    --cc=armbru@redhat.com \
    --cc=jcody@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.