From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v4 1/8] drm/i915: Make sure fb gtt offsets stay within 32bits Date: Tue, 23 Oct 2018 19:49:42 +0100 Message-ID: <154032058266.9962.2779486016415271875@skylake-alporthouse-com> References: <20180925193714.25280-2-ville.syrjala@linux.intel.com> <20181023160201.9840-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id A067F6E225 for ; Tue, 23 Oct 2018 18:49:47 +0000 (UTC) In-Reply-To: <20181023160201.9840-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBWaWxsZSBTeXJqYWxhICgyMDE4LTEwLTIzIDE3OjAyOjAxKQo+IEZyb206IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gCj4gTGV0J3MgdHJ5 IHRvIG1ha2Ugc3VyZSB0aGUgZmIgb2Zmc2V0IGNvbXB1dGF0aW9ucyBuZXZlciBoaXQKPiBhbiBp bnRlZ2VyIG92ZXJmbG93IGJ5IG1ha2luZyBzdXJlIHRoZSBlbnRpcmUgZmIgc3RheXMKPiBiZWxv dyAzMmJpdHMuIGZyYW1lYnVmZmVyX2NoZWNrKCkgaW4gdGhlIGNvcmUgYWxyZWFkeSBkb2VzCj4g dGhlIHNhbWUgY2hlY2ssIGJ1dCBhcyBpdCBkb2Vzbid0IGtub3cgYWJvdXQgdGlsaW5nIHNvbWUg dGhpbmdzCj4gY2FuIHNsaXAgdGhyb3VnaC4gUmVwZWF0IHRoZSBjaGVjayBpbiB0aGUgZHJpdmVy IHdpdGggdGlsaW5nCj4gdGFrZW4gaW50byBhY2NvdW50Lgo+IAo+IHYyOiBVc2UgYWRkX292ZXJm bG93cygpIGFmdGVyIG1hc3NhZ2luZyBpdCB0byB3b3JrIGZvciBtZSAoQ2hyaXMpCj4gdjM6IENh bGwgaXQgYWRkX292ZXJmbG93X3QoKSB0byBtYXRjaCBtaW5fdCgpICYgY28uIChDaHJpcykKPiAK PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gU2lnbmVkLW9m Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oICAgIHwgMTEgKysrKysrKy0t LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTggKysrKysrKysr KysrKysrKystCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oCj4gaW5kZXggNTg1OGE0M2UxOWRh Li45NzI2ZGYzN2M0YzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91 dGlscy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV91dGlscy5oCj4gQEAgLTQ0 LDE2ICs0NCwxOSBAQAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX19zdHJpbmdpZnko eCksIChsb25nKSh4KSkKPiAgCj4gICNpZiBkZWZpbmVkKEdDQ19WRVJTSU9OKSAmJiBHQ0NfVkVS U0lPTiA+PSA3MDAwMAo+IC0jZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQikgXAo+IC0gICAgICAg X19idWlsdGluX2FkZF9vdmVyZmxvd19wKChBKSwgKEIpLCAodHlwZW9mKChBKSArIChCKSkpMCkK PiArI2RlZmluZSBhZGRfb3ZlcmZsb3dzX3QoVCwgQSwgQikgXAo+ICsgICAgICAgX19idWlsdGlu X2FkZF9vdmVyZmxvd19wKChBKSwgKEIpLCAoVCkwKQo+ICAjZWxzZQo+IC0jZGVmaW5lIGFkZF9v dmVyZmxvd3MoQSwgQikgKHsgXAo+ICsjZGVmaW5lIGFkZF9vdmVyZmxvd3NfdChULCBBLCBCKSAo eyBcCj4gICAgICAgICB0eXBlb2YoQSkgYSA9IChBKTsgXAo+ICAgICAgICAgdHlwZW9mKEIpIGIg PSAoQik7IFwKPiAtICAgICAgIGEgKyBiIDwgYTsgXAo+ICsgICAgICAgKFQpKGEgKyBiKSA8IGE7 IFwKPiAgfSkKPiAgI2VuZGlmCj4gIAo+ICsjZGVmaW5lIGFkZF9vdmVyZmxvd3MoQSwgQikgXAo+ ICsgICAgICAgYWRkX292ZXJmbG93c190KHR5cGVvZigoQSkgKyAoQikpLCAoQSksIChCKSkKPiAr Cj4gICNkZWZpbmUgcmFuZ2Vfb3ZlcmZsb3dzKHN0YXJ0LCBzaXplLCBtYXgpICh7IFwKPiAgICAg ICAgIHR5cGVvZihzdGFydCkgc3RhcnRfXyA9IChzdGFydCk7IFwKPiAgICAgICAgIHR5cGVvZihz aXplKSBzaXplX18gPSAoc2l6ZSk7IFwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gaW5kZXggOTY5ZDIyY2E4ZGNkLi5lNTIwZmFjYzIzZTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTIzNTEsMTAgKzIzNTEsMjYgQEAgc3RhdGljIGludCBp bnRlbF9mYl9vZmZzZXRfdG9feHkoaW50ICp4LCBpbnQgKnksCj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaW50IGNvbG9yX3BsYW5lKQo+ICB7Cj4gICAgICAgICBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGZiLT5kZXYpOwo+ICsgICAgICAgdW5z aWduZWQgaW50IGhlaWdodDsKPiAgCj4gICAgICAgICBpZiAoZmItPm1vZGlmaWVyICE9IERSTV9G T1JNQVRfTU9EX0xJTkVBUiAmJgo+IC0gICAgICAgICAgIGZiLT5vZmZzZXRzW2NvbG9yX3BsYW5l XSAlIGludGVsX3RpbGVfc2l6ZShkZXZfcHJpdikpCj4gKyAgICAgICAgICAgZmItPm9mZnNldHNb Y29sb3JfcGxhbmVdICUgaW50ZWxfdGlsZV9zaXplKGRldl9wcml2KSkgewo+ICsgICAgICAgICAg ICAgICBEUk1fREVCVUdfS01TKCJNaXNhbGlnbmVkIG9mZnNldCAweCUwOHggZm9yIGNvbG9yIHBs YW5lICVkXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZiLT5vZmZzZXRzW2Nv bG9yX3BsYW5lXSwgY29sb3JfcGxhbmUpOwo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZB TDsKPiArICAgICAgIH0KPiArCj4gKyAgICAgICBoZWlnaHQgPSBkcm1fZnJhbWVidWZmZXJfcGxh bmVfaGVpZ2h0KGZiLT5oZWlnaHQsIGZiLCBjb2xvcl9wbGFuZSk7Cj4gKyAgICAgICBoZWlnaHQg PSBBTElHTihoZWlnaHQsIGludGVsX3RpbGVfaGVpZ2h0KGZiLCBjb2xvcl9wbGFuZSkpOwoKZmIg aGVpZ2h0IGlzIGxpbWl0ZWQgdG8gdTE2IG9yIHRoZXJlYWJvdXRzPwoKPiArCj4gKyAgICAgICAv KiBDYXRjaCBwb3RlbnRpYWwgb3ZlcmZsb3dzIGVhcmx5ICovCj4gKyAgICAgICBpZiAoYWRkX292 ZXJmbG93c190KHUzMiwgbXVsX3UzMl91MzIoaGVpZ2h0LCBmYi0+cGl0Y2hlc1tjb2xvcl9wbGFu ZV0pLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFu ZV0pKSB7Cj4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoIkJhZCBvZmZzZXQgMHglMDh4 IG9yIHBpdGNoICVkIGZvciBjb2xvciBwbGFuZSAlZFxuIiwKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBmYi0+b2Zmc2V0c1tjb2xvcl9wbGFuZV0sIGZiLT5waXRjaGVzW2NvbG9yX3Bs YW5lXSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb2xvcl9wbGFuZSk7Cj4gKyAg ICAgICAgICAgICAgIHJldHVybiAtRVJBTkdFOwo+ICsgICAgICAgfQoKUmV2aWV3ZWQtYnk6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgotQ2hyaXMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==