From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3 6/8] drm/i915: Overcome display engine stride limits via GTT remapping Date: Tue, 23 Oct 2018 20:16:56 +0100 Message-ID: <154032221683.9962.2032560963337898922@skylake-alporthouse-com> References: <20180925193714.25280-1-ville.syrjala@linux.intel.com> <20180925193714.25280-7-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7AB66E0A4 for ; Tue, 23 Oct 2018 19:17:01 +0000 (UTC) In-Reply-To: <20180925193714.25280-7-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBWaWxsZSBTeXJqYWxhICgyMDE4LTA5LTI1IDIwOjM3OjEyKQo+ICtzdGF0aWMgYm9v bCBpbnRlbF9wbGFuZV9uZWVkc19yZW1hcChjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUg KnBsYW5lX3N0YXRlKQo+ICt7Cj4gKyAgICAgICBzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lID0g dG9faW50ZWxfcGxhbmUocGxhbmVfc3RhdGUtPmJhc2UucGxhbmUpOwo+ICsgICAgICAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+ ICsgICAgICAgY29uc3Qgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwbGFuZV9zdGF0ZS0+ YmFzZS5mYjsKPiArICAgICAgIHVuc2lnbmVkIGludCByb3RhdGlvbiA9IHBsYW5lX3N0YXRlLT5i YXNlLnJvdGF0aW9uOwo+ICsgICAgICAgdTMyIHN0cmlkZSwgbWF4X3N0cmlkZTsKPiArCj4gKyAg ICAgICAvKiBXZSBkb24ndCB3YW50IHRvIGRlYWwgd2l0aCByZW1hcHBpbmcgd2l0aCBjdXJzb3Jz ICovCj4gKyAgICAgICBpZiAocGxhbmUtPmlkID09IFBMQU5FX0NVUlNPUikKPiArICAgICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwo+ICsKPiArICAgICAgIC8qIE5vIGZlbmNlIGZvciB0aGUgcmVt YXBwZWQgdm1hICovCgpTaG91bGQgd29yayBub3cgKHdpdGggYSBtaW5vciB0d2VhayB0byBwbGFu ZV9jYW5fZmVuY2UpLCByaWdodD8KCj4gKyAgICAgICBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8 IDQpCj4gKyAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiArCj4gKyAgICAgICAvKiBOZXcg Q0NTIGhhc2ggbW9kZSBtYWtlcyByZW1hcHBpbmcgaW1wb3NzaWJsZSAqLwo+ICsgICAgICAgaWYg KGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKQo+ICsgICAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7Cj4gKwo+ICsgICAgICAgLyogRklYTUUgb3RoZXIgY29sb3IgcGxhbmVzPyAqLwo+ICsg ICAgICAgc3RyaWRlID0gaW50ZWxfZmJfcGl0Y2goZmIsIDAsIHJvdGF0aW9uKTsKPiArICAgICAg IG1heF9zdHJpZGUgPSBwbGFuZS0+bWF4X3N0cmlkZShwbGFuZSwgZmItPmZvcm1hdC0+Zm9ybWF0 LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZiLT5tb2RpZmllciwg cm90YXRpb24pOwo+ICsKPiArICAgICAgIHJldHVybiBzdHJpZGUgPiBtYXhfc3RyaWRlOwo+ICt9 Cj4gKwo+ICBzdGF0aWMgaW50Cj4gIGludGVsX2ZpbGxfZmJfaW5mbyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fZnJhbWVi dWZmZXIgKmZiKQo+IEBAIC0yNjc2LDYgKzI3NDEsMTgyIEBAIGludGVsX2ZpbGxfZmJfaW5mbyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAgICAgICByZXR1cm4gMDsKPiAg fQo+ICAKPiArc3RhdGljIHZvaWQKPiAraW50ZWxfcGxhbmVfcmVtYXBfZ3R0KHN0cnVjdCBpbnRl bF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpCj4gK3sKPiArICAgICAgIHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9Cj4gKyAgICAgICAgICAgICAgIHRvX2k5MTUocGxhbmVfc3Rh dGUtPmJhc2UucGxhbmUtPmRldik7Cj4gKyAgICAgICBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpm YiA9IHBsYW5lX3N0YXRlLT5iYXNlLmZiOwo+ICsgICAgICAgc3RydWN0IGludGVsX2ZyYW1lYnVm ZmVyICppbnRlbF9mYiA9IHRvX2ludGVsX2ZyYW1lYnVmZmVyKGZiKTsKPiArICAgICAgIHN0cnVj dCBpbnRlbF9yb3RhdGlvbl9pbmZvICppbmZvID0gJnBsYW5lX3N0YXRlLT52aWV3LnJvdGF0ZWQ7 Cj4gKyAgICAgICB1bnNpZ25lZCBpbnQgcm90YXRpb24gPSBwbGFuZV9zdGF0ZS0+YmFzZS5yb3Rh dGlvbjsKPiArICAgICAgIGludCBpLCBudW1fcGxhbmVzID0gZmItPmZvcm1hdC0+bnVtX3BsYW5l czsKPiArICAgICAgIHVuc2lnbmVkIGludCB0aWxlX3NpemUgPSBpbnRlbF90aWxlX3NpemUoZGV2 X3ByaXYpOwo+ICsgICAgICAgdW5zaWduZWQgaW50IHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0Owo+ ICsgICAgICAgdW5zaWduZWQgaW50IGFsaWduZWRfeCwgYWxpZ25lZF95Owo+ICsgICAgICAgdW5z aWduZWQgaW50IGFsaWduZWRfdywgYWxpZ25lZF9oOwo+ICsgICAgICAgdW5zaWduZWQgaW50IHNy Y194LCBzcmNfeTsKPiArICAgICAgIHVuc2lnbmVkIGludCBzcmNfdywgc3JjX2g7Cj4gKyAgICAg ICB1bnNpZ25lZCBpbnQgeCwgeTsKPiArICAgICAgIHUzMiBndHRfb2Zmc2V0ID0gMDsKPiArCj4g KyAgICAgICBtZW1zZXQoJnBsYW5lX3N0YXRlLT52aWV3LCAwLCBzaXplb2YocGxhbmVfc3RhdGUt PnZpZXcpKTsKPiArICAgICAgIHBsYW5lX3N0YXRlLT52aWV3LnR5cGUgPSBkcm1fcm90YXRpb25f OTBfb3JfMjcwKHJvdGF0aW9uKSA/Cj4gKyAgICAgICAgICAgICAgIEk5MTVfR0dUVF9WSUVXX1JP VEFURUQgOiBJOTE1X0dHVFRfVklFV19SRU1BUFBFRDsKPiArCj4gKyAgICAgICBzcmNfeCA9IHBs YW5lX3N0YXRlLT5iYXNlLnNyYy54MSA+PiAxNjsKPiArICAgICAgIHNyY195ID0gcGxhbmVfc3Rh dGUtPmJhc2Uuc3JjLnkxID4+IDE2Owo+ICsgICAgICAgc3JjX3cgPSBkcm1fcmVjdF93aWR0aCgm cGxhbmVfc3RhdGUtPmJhc2Uuc3JjKSA+PiAxNjsKPiArICAgICAgIHNyY19oID0gZHJtX3JlY3Rf aGVpZ2h0KCZwbGFuZV9zdGF0ZS0+YmFzZS5zcmMpID4+IDE2Owo+ICsKPiArICAgICAgIFdBUk5f T04oaXNfY2NzX21vZGlmaWVyKGZiLT5tb2RpZmllcikpOwo+ICsKPiArICAgICAgIC8qIEFsaWdu IG91ciB2aWV3cG9ydCBzdGFydCB0byB0aWxlIGJvdW5kYXJ5ICovCj4gKyAgICAgICBpbnRlbF90 aWxlX2RpbXMoZmIsIDAsICZ0aWxlX3dpZHRoLCAmdGlsZV9oZWlnaHQpOwo+ICsKPiArICAgICAg IHggPSBzcmNfeCAmICh0aWxlX3dpZHRoIC0gMSk7Cj4gKyAgICAgICB5ID0gc3JjX3kgJiAodGls ZV9oZWlnaHQgLSAxKTsKPiArCj4gKyAgICAgICBhbGlnbmVkX3ggPSBzcmNfeCAtIHg7Cj4gKyAg ICAgICBhbGlnbmVkX3kgPSBzcmNfeSAtIHk7Cj4gKwo+ICsgICAgICAgYWxpZ25lZF93ID0geCAr IHNyY193Owo+ICsgICAgICAgYWxpZ25lZF9oID0geSArIHNyY19oOwo+ICsKPiArICAgICAgIC8q IE1ha2Ugc3JjIGNvb3JkaW5hdGVzIHJlbGF0aXZlIHRvIHRoZSBhbGlnbmVkIHZpZXdwb3J0ICov Cj4gKyAgICAgICBkcm1fcmVjdF90cmFuc2xhdGUoJnBsYW5lX3N0YXRlLT5iYXNlLnNyYywKPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAtKGFsaWduZWRfeCA8PCAxNiksIC0oYWxpZ25lZF95 IDw8IDE2KSk7Cj4gKwo+ICsgICAgICAgLyogUm90YXRlIHNyYyBjb29yZGluYXRlcyB0byBtYXRj aCByb3RhdGVkIEdUVCB2aWV3ICovCj4gKyAgICAgICBpZiAoZHJtX3JvdGF0aW9uXzkwX29yXzI3 MChyb3RhdGlvbikpCj4gKyAgICAgICAgICAgICAgIGRybV9yZWN0X3JvdGF0ZSgmcGxhbmVfc3Rh dGUtPmJhc2Uuc3JjLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWxpZ25lZF93 IDw8IDE2LCBhbGlnbmVkX2ggPDwgMTYsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBEUk1fTU9ERV9ST1RBVEVfMjcwKTsKPiArCj4gKyAgICAgICBmb3IgKGkgPSAwOyBpIDwgbnVt X3BsYW5lczsgaSsrKSB7Cj4gKyAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBoc3ViID0gaSA/ IGZiLT5mb3JtYXQtPmhzdWIgOiAxOwo+ICsgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgdnN1 YiA9IGkgPyBmYi0+Zm9ybWF0LT52c3ViIDogMTsKPiArICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IGNwcCA9IGZiLT5mb3JtYXQtPmNwcFtpXTsKPiArICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IHdpZHRoLCBoZWlnaHQ7Cj4gKyAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBwaXRjaF90 aWxlczsKPiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHgsIHk7Cj4gKyAgICAgICAgICAg ICAgIHUzMiBvZmZzZXQ7Cj4gKwo+ICsgICAgICAgICAgICAgICBpbnRlbF90aWxlX2RpbXMoZmIs IGksICZ0aWxlX3dpZHRoLCAmdGlsZV9oZWlnaHQpOwo+ICsKPiArICAgICAgICAgICAgICAgeCA9 IGFsaWduZWRfeCAvIGhzdWI7Cj4gKyAgICAgICAgICAgICAgIHkgPSBhbGlnbmVkX3kgLyB2c3Vi Owo+ICsgICAgICAgICAgICAgICB3aWR0aCA9IGFsaWduZWRfdyAvIGhzdWI7CgphbGlnbmVkX3cg aGVyZSBzZWVtcyB0byBiZSBqdXN0IHgyLgoKRGlkIEkgbWlzcyBhbGlnbmVkX3cgPSBBTElHTihh bGlnbmVkX3csIHRpbGVfd2lkdGgpIC0gYWxpZ25lZF94PwoKPiArICAgICAgICAgICAgICAgaGVp Z2h0ID0gYWxpZ25lZF9oIC8gdnN1YjsKPiArCj4gKyAgICAgICAgICAgICAgIC8qCj4gKyAgICAg ICAgICAgICAgICAqIEZpcnN0IHBpeGVsIG9mIHRoZSBhbGlnbmVkIHNyYyB2aWV3cG9ydAo+ICsg ICAgICAgICAgICAgICAgKiBmcm9tIHRoZSBzdGFydCBvZiB0aGUgbm9ybWFsIGd0dCBtYXBwaW5n Lgo+ICsgICAgICAgICAgICAgICAgKi8KPiArICAgICAgICAgICAgICAgeCArPSBpbnRlbF9mYi0+ bm9ybWFsW2ldLng7Cj4gKyAgICAgICAgICAgICAgIHkgKz0gaW50ZWxfZmItPm5vcm1hbFtpXS55 Owo+ICsKPiArICAgICAgICAgICAgICAgb2Zmc2V0ID0gaW50ZWxfY29tcHV0ZV9hbGlnbmVkX29m ZnNldChkZXZfcHJpdiwgJngsICZ5LAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZiLCBpLCBmYi0+cGl0Y2hlc1tpXSwKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEUk1fTU9ERV9ST1RB VEVfMCwgdGlsZV9zaXplKTsKPiArICAgICAgICAgICAgICAgb2Zmc2V0IC89IHRpbGVfc2l6ZTsK PiArCj4gKyAgICAgICAgICAgICAgIGluZm8tPnBsYW5lW2ldLm9mZnNldCA9IG9mZnNldDsKPiAr ICAgICAgICAgICAgICAgaW5mby0+cGxhbmVbaV0uc3RyaWRlID0gRElWX1JPVU5EX1VQKGZiLT5w aXRjaGVzW2ldLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdGlsZV93aWR0aCAqIGNwcCk7Cj4gKyAgICAgICAgICAgICAgIGluZm8tPnBsYW5l W2ldLndpZHRoID0gRElWX1JPVU5EX1VQKHggKyB3aWR0aCwgdGlsZV93aWR0aCk7Cj4gKyAgICAg ICAgICAgICAgIGluZm8tPnBsYW5lW2ldLmhlaWdodCA9IERJVl9ST1VORF9VUCh5ICsgaGVpZ2h0 LCB0aWxlX2hlaWdodCk7CgpJIHRob3VnaHQgLndpZHRoIGhlcmUgd291bGQgYmUgaW4gcGFnZXM/ IE9rIHRpbGVfd2lkdGggIT0gZmVuY2Vfc3RyaWRlCmFuZCBkb2VzIHByb2R1Y2UgcGFnZXMganVz dCBmaW5lLgoKQW5kIHNob3VsZG4ndCB3aWR0aCBoZXJlIGJlIGFkanVzdGVkIGZvciB4PyBTaW1p bGFybHkgZm9yIGhlaWdodD8KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=