All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Alan Tull <atull@kernel.org>,
	Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: Re: [PATCH 0/5] Implement devm_of_clk_add_provider
Date: Thu, 01 Nov 2018 16:35:45 -0700	[thread overview]
Message-ID: <154111534593.88331.1129843003477644482@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181101144044.11495-1-ricardo.ribalda@gmail.com>

Quoting Ricardo Ribalda Delgado (2018-11-01 07:40:39)
> All Tull reported that there might be a great ammount of drivers with
> imbalance on clk_add_provider. This is an issue for Device tree overlays
> (and also a bug) https://lkml.org/lkml/2018/10/18/1103
> 
> This patchset implement a devm_ function of of_clk_add_provider, and
> fixes 3 drivers.
> 
> Drivers like clk-gpio will be easily fixed with coccinelle if this set
> is accepted. (I volunteer, I want to learn how to use it, just seen the
> great presentations from Julia).

We already have devm_of_clk_add_hw_provider(), so any instances of
of_clk_add_provider() should be replaced with that, instead of
propagating the usage of of_clk_add_provider() any further. I'll gladly
apply patches to convert drivers from struct clk based APIs to struct
clk_hw based APIs so that we can clearly split clk providers from clk
consumers. So if you're interested in working on some coccinelle script
for that it would be great!


  parent reply	other threads:[~2018-11-01 23:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 14:40 [PATCH 0/5] Implement devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 1/5] clk: Refactor of_clk_add_provider and of_clk_add_hw_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 2/5] clk: Create devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 3/5] clk: fixed-factor: Use devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 4/5] clk: fixed-rate: " Ricardo Ribalda Delgado
2018-11-01 14:40 ` [PATCH 5/5] clk: gpio: " Ricardo Ribalda Delgado
2018-11-01 23:35 ` Stephen Boyd [this message]
2018-11-02  6:54   ` [PATCH 0/5] Implement devm_of_clk_add_provider Ricardo Ribalda Delgado
2018-11-02 16:05     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154111534593.88331.1129843003477644482@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=atull@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.