From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH iproute2] Fix warning in tc-skbprio.8 manpage
Date: Fri, 02 Nov 2018 15:28:06 +0000
Message-ID: <1541172486.4849.23.camel@debian.org>
References: <20181102105741.25381-1-bluca@debian.org>
         <d6165e95-06bf-b835-21ae-f0a1f744bec6@solarflare.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-2fgfPxexFTExsJgSsOMC"
Cc: stephen@networkplumber.org, dsahern@gmail.com
To: Edward Cree <ecree@solarflare.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f68.google.com ([209.85.221.68]:35310 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726085AbeKCAfg (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Nov 2018 20:35:36 -0400
Received: by mail-wr1-f68.google.com with SMTP id z16-v6so2409778wrv.2
        for <netdev@vger.kernel.org>; Fri, 02 Nov 2018 08:28:09 -0700 (PDT)
In-Reply-To: <d6165e95-06bf-b835-21ae-f0a1f744bec6@solarflare.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--=-2fgfPxexFTExsJgSsOMC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2018-11-02 at 15:19 +0000, Edward Cree wrote:
> On 02/11/18 10:57, Luca Boccassi wrote:
> > ". If" gets interpreted as a macro, so move the period to the
> > previous
> > line:
> >=20
> > =C2=A0 33: warning: macro `If' not defined
> >=20
> > Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
> >=20
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > =C2=A0man/man8/tc-skbprio.8 | 4 ++--
> > =C2=A01 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/man/man8/tc-skbprio.8 b/man/man8/tc-skbprio.8
> > index 844bbf46..8b259839 100644
> > --- a/man/man8/tc-skbprio.8
> > +++ b/man/man8/tc-skbprio.8
> > @@ -29,8 +29,8 @@ While SKB Priority Queue is agnostic to how
> > =C2=A0.B skb->priority
> > =C2=A0is assigned. A typical use case is to copy
> > =C2=A0the 6-bit DS field of IPv4 and IPv6 packets using
> > -.BR tc-skbedit (8)
> > -. If
> > +.BR tc-skbedit (8) .
> > +If
>=20
> Won't that make the full-stop bold?
> Removing the space, i.e.
> .BR rc-skbedit (8).
> ought to work.
> -Ed

Yes you are right, fixed in v2, thanks.

--=20
Kind regards,
Luca Boccassi
--=-2fgfPxexFTExsJgSsOMC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE6g0RLAGYhL9yp9G8SylmgFB4UWIFAlvcbQYACgkQSylmgFB4
UWJFGgf+N3Tabvj9FGaOixnFK2ioPZUNyV9ne4J+Hr9Qdudyeb0ZZXHdVNmiwwRb
1EO1bpq94PQeRvsoh1rxZUg7MLnNxWsgk+VYsTW6J010aN26KhYEtNYhC8wmKNc8
S6dMyStzFfF6IcGQ+fae8RPrkiBnYkgmEnjjeFjqvp2YDftBbsTQ+rKIktuwy4U6
cPn2NViqeQO5fxAEmGCi4zjq5i5vBh5hXk8APso9nkTtFsGSFVWNW4KksmjN2Mw2
+QI2qlVwH9r010kQtiskWM5dD2kLZhlO3zsN04L3BLj+b8Zu8auNPwneDti5xN9u
lOijA1kuvB6DInXWCNOpX+oQUkaytg==
=QEI5
-----END PGP SIGNATURE-----

--=-2fgfPxexFTExsJgSsOMC--