From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult Date: Wed, 28 Jun 2017 16:10:14 +0300 Message-ID: <1541474.We3gYspHHt@avalon> References: <20170627203843.27004-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CA7D6E55C for ; Wed, 28 Jun 2017 13:10:12 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: Neil Armstrong , Liviu Dudau , ML dri-devel , Thierry Reding , Gerd Hoffmann , Daniel Vetter , Boris Brezillon , Thomas Hellstrom , Laurent Pinchart , Alexey Brodkin , Xinliang Liu , Xinwei Kong , Tomi Valkeinen , Mali DP Maintainers , Dave Airlie , Chen Feng , Jyri Sarha , Vincent Abriou , VMware Graphics , Alison Wang , Seung-Woo Kim List-Id: dri-devel@lists.freedesktop.org SGkgRW1pbCwKCk9uIFdlZG5lc2RheSAyOCBKdW4gMjAxNyAxMjoyNzowNiBFbWlsIFZlbGlrb3Yg d3JvdGU6Cj4gT24gMjcgSnVuZSAyMDE3IGF0IDIxOjM4LCBMYXVyZW50IFBpbmNoYXJ0IHdyb3Rl Ogo+ID4gSGVsbG8sCj4gPiAKPiA+IFRoZSBhdG9taWMgaGVscGVycyBmYXZvdXIgdGhlIC5lbmFi bGUoKSBhbmQgLmF0b21pY19kaXNhYmxlKCkgQ1JUQyBoZWxwZXIKPiA+IG9wZXJhdGlvbnMsIGJ1 dCBzdGlsbCBzdXBwb3J0IHRoZSBsZWdhY3kgLnByZXBhcmUoKSwgLmNvbW1pdCgpLCAuZGlzYWJs ZSgpCj4gPiBhbmQgLmRwbXMoKSBvcGVyYXRpb25zLiBTb21lIGRyaXZlcnMgaGF2ZSBiZWVuIHVw ZGF0ZWQsIGJ1dCBtb3N0IHN0aWxsCj4gPiB1c2UgdmFyaW91cyBjb21iaW5hdGlvbiBvZiBuZXcg YW5kIGxlZ2FjeSBvcGVyYXRpb25zLCBsZWFkaW5nIHRvCj4gPiBjb25mdXNpb24gYW1vbmcgbmV3 IGRldmVsb3BlcnMgd2hlbiB0aGV5IHJlYWQgdGhlIGNvZGUuCj4gCj4gSnVzdCBoYWQgYSBjcmF6 eSBpZGVhOgo+IAo+IFdvdWxkIGl0IG1ha2Ugc2Vuc2UgZm9yIHRoZSBmdW5jdGlvbihzKSB0aGF0 IHRha2VzIHRoZQo+IGRyaXZlcl9mb29fZnVuY3MgYXMgYW4gYXJndW1lbnQgdG8gY3Jvc3MtY2hl Y2sgZm9yIHN1Y2ggbWlzdGFrZXM/Cj4gU2luY2UgbWFueSBvZiB0aGUgaG9va3MgYXJlIG9wdGlv bmFsLCBvbmUgY291bGQgY2hlY2sgZm9yIHRoZQo+ICdmb3JiaWRkZW4nIGNvbWJpbmF0aW9uczoK PiBBdG9taWMgZHJpdmVycyBzaG91bGQgbm90IGhhdmUgYW55IGxlZ2FjeSBob29rcyBzZXQsIHdo aWxlIGxlZ2FjeSBvbmVzCj4gc2hvdWxkIG5vdCBoYXZlIGFueSBvZiB0aGUgYXRvbWljIG9uZXMu CgpJIHRoaW5rIGl0J3MgYSBnb29kIGlkZWEsIGFsdGhvdWdoIHRyYW5zaXRpb24gdG8gYXRvbWlj IG1vZGVzZXR0aW5nIChmb2xsb3dpbmcgCnRoZSBwcm9jZWR1cmUgb3V0bGluZWQgaW4gRGFuaWVs J3MgYmxvZykgbWlnaHQgbWl4IGxlZ2FjeSBhbmQgYXRvbWljIApvcGVyYXRpb25zLgoKQXQgdGhl IG1vbWVudCB0aGUgb25seSBhdG9taWMgZHJpdmVyIHRoYXQgc3RpbGwgdXNlcyBsZWdhY3kgQ1JU QyBoZWxwZXIgCm9wZXJhdGlvbnMgaXMgdm13Z2Z4LiBUaGUgZHJpdmVyIGltcGxlbWVudHMgYm90 aCB0aGUgLnByZXBhcmUoKSBhbmQgCi5hdG9taWNfZGlzYWJsZSgpIGhlbHBlciBvcGVyYXRpb25z LCB3aXRoIC5wcmVwYXJlKCkgYmVpbmcgZW1wdHkuIFRoZSBDUlRDIApoZWxwZXJzIGNhbGwgdGhv c2Ugb3BlcmF0aW9ucyBmcm9tIGRpc2FibGVfb3V0cHV0cygpOgoKICAgICAgICAgICAgICAgIC8q IFJpZ2h0IGZ1bmN0aW9uIGRlcGVuZHMgdXBvbiB0YXJnZXQgc3RhdGUuICovCiAgICAgICAgICAg ICAgICBpZiAobmV3X2NydGNfc3RhdGUtPmVuYWJsZSAmJiBmdW5jcy0+cHJlcGFyZSkKICAgICAg ICAgICAgICAgICAgICAgICAgZnVuY3MtPnByZXBhcmUoY3J0Yyk7CiAgICAgICAgICAgICAgICBl bHNlIGlmIChmdW5jcy0+YXRvbWljX2Rpc2FibGUpCiAgICAgICAgICAgICAgICAgICAgICAgIGZ1 bmNzLT5hdG9taWNfZGlzYWJsZShjcnRjLCBvbGRfY3J0Y19zdGF0ZSk7CiAgICAgICAgICAgICAg ICBlbHNlIGlmIChmdW5jcy0+ZGlzYWJsZSkKICAgICAgICAgICAgICAgICAgICAgICAgZnVuY3Mt PmRpc2FibGUoY3J0Yyk7CiAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAg ICAgIGZ1bmNzLT5kcG1zKGNydGMsIERSTV9NT0RFX0RQTVNfT0ZGKTsKCi5wcmVwYXJlKCkgYW5k IC5hdG9taWNfZGlzYWJsZSgpIGFyZSB0aHVzIG5vdCBjb21wbGV0ZWx5IGlkZW50aWNhbC4KCkkg YmVsaWV2ZSB0aGlzIGNvdWxkIGJlIGFkZHJlc3NlZCBieSBhZGRpbmcKCiAgICAgICAgaWYgKGNy dGMtPnN0YXRlLT5lbmFibGUpCiAgICAgICAgICAgICAgICByZXR1cm47Cgp0byB0aGUgLmF0b21p Y19kaXNhYmxlKCkgaGFuZGxlciBpbiB0aGUgdm13Z2Z4IGRyaXZlci4gSSdsbCBzdWJtaXQgYSBw YXRjaCBmb3IgCnRoYXQuCgo+IE9mIGNvdXJzZSB0aGUgaWRlYSBpcyBub3QgcmVzdHJpY3RlZCB0 byB0aGUgQ1JUQyBoZWxwZXJzIC0KPiBkcm1fe2NydGMsZW5jb2Rlcixjb25uZWN0b3IscGxhbmUs bW9kZV9jb25maWd9X3toZWxwZXJfLH1mdW5jcyBzaG91bGQKPiBhbGwgYmUgYXBwbGljYWJsZS4K Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==