All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Hao <peng.hao2@zte.com.cn>
To: robh+dt@kernel.org, mark.rutland@arm.com, arnd@arndb.de,
	gregkh@linuxfoundation.org, andy@infradead.org,
	dvhart@infradead.org
Cc: linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, hutao@cn.fujitsu.com,
	linux-doc@vger.kernel.org, Peng Hao <peng.hao2@zte.com.cn>
Subject: [PATCH v8 02/11]  misc/pvpanic: simplify the code using acpi_dev_resource_io
Date: Tue, 6 Nov 2018 22:57:13 +0800	[thread overview]
Message-ID: <1541516242-98568-2-git-send-email-peng.hao2@zte.com.cn> (raw)
In-Reply-To: <1541516242-98568-1-git-send-email-peng.hao2@zte.com.cn>

Use acpi_dev_resource_io API.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 drivers/misc/pvpanic.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index fd86dab..49c59e1 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -77,17 +77,14 @@
 static acpi_status
 pvpanic_walk_resources(struct acpi_resource *res, void *context)
 {
-	switch (res->type) {
-	case ACPI_RESOURCE_TYPE_END_TAG:
-		return AE_OK;
+	struct resource r;
 
-	case ACPI_RESOURCE_TYPE_IO:
-		port = res->data.io.minimum;
+	if (acpi_dev_resource_io(res, &r)) {
+		port = r.start;
 		return AE_OK;
-
-	default:
-		return AE_ERROR;
 	}
+
+	return AE_ERROR;
 }
 
 static int pvpanic_add(struct acpi_device *device)
-- 
1.8.3.1


  reply	other threads:[~2018-11-06  6:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 14:57 [PATCH V8 01/11] pvpanic: move pvpanic to misc as common driver Peng Hao
2018-11-06 14:57 ` Peng Hao [this message]
2018-11-06 14:57 ` [PATCH V8 03/11] misc/pvpanic: add MMIO support Peng Hao
2018-11-06 14:57 ` [PATCH V8 04/11] dt-bindings: misc/pvpanic: add document for pvpanic-mmio Peng Hao
2018-11-06 14:57 ` [PATCH V8 05/11] misc/pvpanic: add support to get pvpanic device info FDT Peng Hao
2018-11-06 14:57 ` [PATCH V8 06/11] misc/pvpanic : grouping ACPI related stuff Peng Hao
2018-11-06 14:57 ` [PATCH V8 07/11] misc/pvpanic : break dependency on ACPI Peng Hao
2018-11-06 14:57 ` [PATCH V8 08/11] misc/pvpanic: remove unnecessary header file Peng Hao
2018-11-06 14:57 ` [PATCH V8 09/11] misc/pvpanic: change header file sort style Peng Hao
2018-11-06 10:02   ` Andy Shevchenko
2018-11-06 14:57 ` [PATCH V8 10/11] misc/pvpanic: convert to SPDX license tags Peng Hao
2018-11-06 14:57 ` [PATCH V8 11/11] misc/pvpanic: remove a redundant comma Peng Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541516242-98568-2-git-send-email-peng.hao2@zte.com.cn \
    --to=peng.hao2@zte.com.cn \
    --cc=andy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hutao@cn.fujitsu.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.