From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/3] drm/i915: Return immediately if trylock fails for direct-reclaim Date: Thu, 08 Nov 2018 16:48:05 +0000 Message-ID: <154169568572.30559.8677186074374608822@skylake-alporthouse-com> References: <20181108081740.25615-1-chris@chris-wilson.co.uk> <20181108081740.25615-2-chris@chris-wilson.co.uk> <892ae58f-33ed-b468-fe7c-bd655f8567d4@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3A416E4B5 for ; Thu, 8 Nov 2018 16:48:10 +0000 (UTC) In-Reply-To: <892ae58f-33ed-b468-fe7c-bd655f8567d4@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxOC0xMS0wOCAxNjoyMzowOCkKPiAKPiBPbiAwOC8x MS8yMDE4IDA4OjE3LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBJZ25vcmUgdHJ5aW5nIHRvIHNo cmluayBmcm9tIGk5MTUgaWYgd2UgZmFpbCB0byBhY3F1aXJlIHRoZSBzdHJ1Y3RfbXV0ZXgKPiA+ IGluIHRoZSBzaHJpbmtlciB3aGlsZSBwZXJmb3JtaW5nIGRpcmVjdC1yZWNsYWltLiBUaGUgdHJh ZGUtb2ZmIGJlaW5nCj4gPiAobXVjaCkgbG93ZXIgbGF0ZW5jeSBmb3Igbm9uLWk5MTUgY2xpZW50 cyBhdCBhbiBpbmNyZWFzZWQgcmlzayBvZiBiZWluZwo+ID4gdW5hYmxlIHRvIG9idGFpbiBhIHBh Z2UgZnJvbSBkaXJlY3QtcmVjbGFpbSB3aXRob3V0IGhpdHRpbmcgdGhlCj4gPiBvb20tbm90aWZp ZXIuIFRoZSBwcm92aXNvIGJlaW5nIHRoYXQgd2Ugc3RpbGwga2VlcCB0cnlpbmcgdG8gaGFyZAo+ ID4gb2J0YWluIHRoZSBsb2NrIGZvciBvb20gc28gdGhhdCB3ZSBjYW4gcmVhcCB1bmRlciBoZWF2 eSBtZW1vcnkgcHJlc3N1cmUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28u dXJzdWxpbkBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW1fc2hyaW5rZXIuYyB8IDI0ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ID4gICAxIGZp bGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9zaHJpbmtlci5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fc2hyaW5rZXIuYwo+ID4gaW5kZXggZWE5MGQzYTBk NTExLi5kNDYxZjQ1OGY0YWYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9zaHJpbmtlci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bV9zaHJpbmtlci5jCj4gPiBAQCAtMzYsNyArMzYsOSBAQAo+ID4gICAjaW5jbHVkZSAiaTkxNV9k cnYuaCIKPiA+ICAgI2luY2x1ZGUgImk5MTVfdHJhY2UuaCIKPiA+ICAgCj4gPiAtc3RhdGljIGJv b2wgc2hyaW5rZXJfbG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwgYm9vbCAqdW5s b2NrKQo+ID4gK3N0YXRpYyBib29sIHNocmlua2VyX2xvY2soc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZ3Ms Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBib29sICp1bmxvY2spCj4gPiAgIHsKPiA+ICAg ICAgIHN3aXRjaCAobXV0ZXhfdHJ5bG9ja19yZWN1cnNpdmUoJmk5MTUtPmRybS5zdHJ1Y3RfbXV0 ZXgpKSB7Cj4gPiAgICAgICBjYXNlIE1VVEVYX1RSWUxPQ0tfUkVDVVJTSVZFOgo+ID4gQEAgLTQ1 LDE1ICs0NywxMSBAQCBzdGF0aWMgYm9vbCBzaHJpbmtlcl9sb2NrKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICppOTE1LCBib29sICp1bmxvY2spCj4gPiAgIAo+ID4gICAgICAgY2FzZSBNVVRFWF9U UllMT0NLX0ZBSUxFRDoKPiA+ICAgICAgICAgICAgICAgKnVubG9jayA9IGZhbHNlOwo+ID4gLSAg ICAgICAgICAgICBwcmVlbXB0X2Rpc2FibGUoKTsKPiA+IC0gICAgICAgICAgICAgZG8gewo+ID4g LSAgICAgICAgICAgICAgICAgICAgIGNwdV9yZWxheCgpOwo+ID4gLSAgICAgICAgICAgICAgICAg ICAgIGlmIChtdXRleF90cnlsb2NrKCZpOTE1LT5kcm0uc3RydWN0X211dGV4KSkgewo+ID4gLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKnVubG9jayA9IHRydWU7Cj4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+IC0gICAgICAgICAgICAgICAgICAgICB9Cj4g PiAtICAgICAgICAgICAgIH0gd2hpbGUgKCFuZWVkX3Jlc2NoZWQoKSk7Cj4gPiAtICAgICAgICAg ICAgIHByZWVtcHRfZW5hYmxlKCk7Cj4gPiArICAgICAgICAgICAgIGlmIChmbGFncyAmIEk5MTVf U0hSSU5LX0FDVElWRSkgewo+IAo+IFNvIHVudGlsIEk5MTVfU0hSSU5LX0FDVElWRSwgd2hpY2gg aXMgdGhlIGxhc3QgZGl0Y2ggYXR0ZW1wdCB0byBzaHJpbmsgCj4gaW4gdGhlIG5vcm1hbCBjYXNl IChkaXJlY3QgcmVjbGFpbT8pIG9yIG9vbSwgd2UgYmFpbCBvdXQgb24gdGhlIGZpcnN0IAo+IHNp Z24gb2Ygc3RydWN0IG11dGV4IGNvbnRlbnRpb24uIERvZXNuJ3QgdGhpcyBtYWtlIG91ciBzaHJp bmtlciBtdWNoIAo+IGxlc3MgZWZmZWN0aXZlIGF0IHJ1bnRpbWUgYW5kIHdoeSBpcyB0aGF0IE9L PwoKQXMgSSBzYWlkLCBpdCdzIGEgdHJhZGVvZmYgYmV0d2VlbiBibG9ja2luZyBvdGhlcnMgZm9y IF9zZXZlcmFsXwpfc2Vjb25kc18gYW5kIG1ha2luZyBubyBwcm9ncmVzcyBhbmQgcmV0dXJuaW5n IGltbWVkaWF0ZWx5IGFuZCBtYWtpbmcgbm8KcHJvZ3Jlc3MuIE15IGFyZ3VtZW50IGlzIGFsb25n IHRoZSBsaW5lcyBvZiBpZiBkaXJlY3QtcmVjbGFpbSBpcyBydW5uaW5nCmluIGFub3RoZXIgcHJv Y2VzcyBhbmQgc29tZXRoaW5nIGVsc2UgaXMgZW5nYWdlZCBpbiB0aGUgZHJpdmVyIGhvcGVmdWxs eQp0aGUgZHJpdmVyIHdpbGwgYmUgY2xlYW5pbmcgdXAgYXMgaXQgZ29lcyBhbG9uZyBvciBlbHNl IHdoYXQgcmVtYWlucyBpcwphY3RpdmUgYW5kIHdvbid0IGJlIHJlYXBlZCBhbnl3YXkuIElmIGRp cmVjdCByZWNsYWltIGlzIGZhaWxpbmcsIHRoZQpkZWxheSBiZWZvcmUgdHJ5aW5nIHRoZSBvb20g cGF0aCBpcyBpbnNpZ25pZmljYW50LgoKPiBPciBpbiBvdGhlciB3b3JkcywgZm9yIHdoYXQgdXNl IGNhc2VzLCB0ZXN0cyBvciBiZW5jaG1hcmsgd2FzIHRoZSAKPiBleGlzdGluZyBhcHByb2FjaCBv ZiBidXN5IGxvb3BpbmcgYSBwcm9ibGVtPwoKRG8gc29tZXRoaW5nIGxpa2UgJ2ZpbmQgLyAtZXhl YyBjYXQnIHdoaWxlIHJ1bm5pbmcgaTkxNSBhbmQgc2VlIGhvdyBsb25nCnlvdSBoYXZlIHRvIHdh aXQgZm9yIGEga2h1bmd0YXNrZCA6fAoKZ2VtX3N5c2xhdGVuY3kgcmVwb3J0cyBtYXggbGF0ZW5j aWVzIG9mIG92ZXIgNjAwcywgYW5kIEknbSBzdXJlIGl0J3MKcHJldHR5IG11Y2ggdW5ib3VuZGVk LiBJdCdzIGJhZCBlbm91Z2ggdGhhdCBJIGV4cGVjdCB3ZSBhcmUgdGhlIGNhdXNlIG9mCnNpZ25p ZmljYW50IGhpdGNoaW5nIChtYWlubHkgaW4gb3RoZXIgdGFza3MpIG9uIHRoZSBkZXNrdG9wIHJ1 bm5pbmcgYXQKbWVtb3J5IGNhcGFjaXR5LgoKPiA+ICsgICAgICAgICAgICAgICAgICAgICBtdXRl eF9sb2NrX25lc3RlZCgmaTkxNS0+ZHJtLnN0cnVjdF9tdXRleCwKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBJOTE1X01NX1NIUklOS0VSKTsKPiAKPiBfbmVzdGVk IGlzIG5lZWRlZCBzaW5jZSBhYmFuZG9uaW5nIHRyeWxvY2sgd291bGQgb3RoZXJ3aXNlIGNhdXNl IGxvY2tkZXAgCj4gaXNzdWVzPyBCdXQgaXMgaXQgcmVhbGx5IHNhZmU/IEkgZG9uJ3Qga25vdy4u IGhvdyBjYW4gaXQgYmU/IEl0IGlzIAo+IGd1YXJhbnRlZWQgdG8gYmUgYSBkaWZmZXJlbnQgcHJv Y2VzcyBoZXJlIG90aGVyd2lzZSB0aGUgcmVzdWx0IHdvdWxkbid0IAo+IGJlIE1VVEVYX1RSWUxP Q0tfRkFJTEVELgoKVGhlIGVhc3kgb3B0aW9uIHdhcyB0byBvbmx5IGZvcmNlIHRoZSBtdXRleF9s b2NrIGZvciBrc3dhcGQuIEhvd2V2ZXIsCm5vdGluZyB0aGF0IHdlIGRvIG5lZWQgdG8gZm9yY2li bHkgc2hyaW5rIGJlZm9yZSBvb20sIEkgb3B0ZWQgZm9yIHRoZQptb3JlIGluY2x1c2l2ZSBhdHRl bXB0IHRvIHRha2UgaXQgaW4gYm90aC4gRm9yIHRoZSBvb20gYXBwcm9hY2gsIG15IG9ubHkKaGFu ZHdhdmluZyBpcyB3ZSBzaG91bGRuJ3QgYmUgbmVzdGVkIHVuZGVyIG9vbSBzZXJpYWxpc2F0aW9u IGFuZCBzbwphdm9pZCBhbiBBQkJBIGRlYWRsb2NrLiBJdCdzIHN1cnZpdmVkIHNvbWUgb29tIGFi dXNlLCBidXQgdGhlIG1hY2hpbmUKc3RpbGwgYmVjb21lcyB1bnJlc3BvbnNpdmUgKGJ1dCBwaW5n YWJsZSkgZXZlbnR1YWxseSAoYXMgaXQgZG9lcyBiZWZvcmUKdGhlIHBhdGNoKS4KCj4gQWxzbywg STkxNV9NTV9TSFJJTktFUiBpcyBzbyBmYXIgb25seSBkb2N1bWVudGVkIHRvIGFwcGx5IHRvIG9i ai0+bW0ubG9jay4KCkl0IHN1aXRzIHZlcnkgbmljZWx5IGFzIGl0IGJlaW5nIGFwcGxpZWQgZm9y IHRoZSBzYW1lIHB1cnBvc2UuCi1DaHJpcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK