From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14360C07E96 for ; Thu, 15 Jul 2021 08:41:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79AE86127C for ; Thu, 15 Jul 2021 08:41:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79AE86127C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A489B82F0C; Thu, 15 Jul 2021 10:41:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="M67Lhj6N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 255AF82F13; Thu, 15 Jul 2021 10:41:00 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 24F9382EA7 for ; Thu, 15 Jul 2021 10:40:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20210715084048epoutp02d9d6ac185d5da9f445ff1acd4fedde5b~R6jPMymDd2268722687epoutp02V for ; Thu, 15 Jul 2021 08:40:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20210715084048epoutp02d9d6ac185d5da9f445ff1acd4fedde5b~R6jPMymDd2268722687epoutp02V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1626338448; bh=k8XYf/kJihJpSO+WTDXU65NtRk0jc7p21v6/64TXrUg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=M67Lhj6Ni7Z66LcDpiQAIDDS3zTZLYhgEMfZcoUiuCAu05rrK6rbcGOb5FnM/VY9a w6aUgzKdhvAR056/GhPpUx+HKehKA5bTj3HwwPtGitzAl/50sQIOVHKErYm8K2cdbU aZy9H32pAwCegK9WVwprSqmEFl3PnF87yisbmjT0= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20210715084048epcas1p3c8ff19a040c20c2cb206f1fdeec773fb~R6jOvaMzm0047000470epcas1p39; Thu, 15 Jul 2021 08:40:48 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.152]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4GQSWJ6wSsz4x9Q2; Thu, 15 Jul 2021 08:40:44 +0000 (GMT) Received: from epcas1p3.samsung.com ( [182.195.41.47]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 1B.99.09551.C84FFE06; Thu, 15 Jul 2021 17:40:44 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20210715084044epcas1p12e4676b68ad82cb1d2a258e41c46c4fb~R6jLFuFUC3041830418epcas1p1P; Thu, 15 Jul 2021 08:40:44 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210715084044epsmtrp12414c285d7bb2003a1a588b6099f8d5c~R6jLE7Gr91253312533epsmtrp1S; Thu, 15 Jul 2021 08:40:44 +0000 (GMT) X-AuditID: b6c32a36-2c9ff7000000254f-04-60eff48cb000 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 01.66.08289.C84FFE06; Thu, 15 Jul 2021 17:40:44 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20210715084043epsmtip1026147a96766f13717bdfe300a4ab13f~R6jKxCG1Q2641626416epsmtip1m; Thu, 15 Jul 2021 08:40:43 +0000 (GMT) Subject: Re: [PATCH 3/3] mmc: mmc_get_op_cond: Allow quiet detection of eMMC To: Stefan Roese , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Andre Heider , =?UTF-8?Q?G=c3=a9rald_Kerma?= , Konstantin Porotchkin , Baruch Siach , Fabio Estevam , Peng Fan Cc: u-boot@lists.denx.de From: Jaehoon Chung Message-ID: <154200cc-5ac0-b18d-59eb-f855a0ab9267@samsung.com> Date: Thu, 15 Jul 2021 17:41:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <90f97347-fadb-6ebb-2705-91b9f8fd4b32@denx.de> Content-Language: en-US Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHJsWRmVeSWpSXmKPExsWy7bCmvm7Pl/cJBjfOmFl0rj3KbrHi2hsW i4dX/S1erulislj0aAerxYI9p9ksfqz6wmpxct0HJou3ezvZHTg95s06weKx6ruMx85Zd9k9 Nq3qZPM4e2cHo8fkhReZPTa+28HkMbfhFlMAR1S2TUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7yp mYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QeUoKZYk5pUChgMTiYiV9O5ui/NKSVIWM/OISW6XU gpScAssCveLE3OLSvHS95PxcK0MDAyNToMKE7Ixv8y0LnihX/JoV28D4WbaLkZNDQsBE4sej R6xdjFwcQgI7GCWu/fzGCOF8YpS42DaXEaRKSOAzo8Slue4wHU8mNbNDFO1ilNh/+gAzhPOe UaJn41c2kCphAR+JBfd3gs0VEdjGJPFv9i+wBLOAhMSSQ/dZQWw2AR2J7d+OM4HYvAJ2Etfm /AazWQRUJSb/fM4MYosKREqc372ABaJGUOLkzCdgNqeAtcT3eT9ZIGaKS9x6Mp8JwpaXaN46 mxni1LUcEv/u2ELYLhL7mprZIGxhiVfHt7BD2FISL/vboOxqiV3NZ8C+kRDoYJS4ta2JCSJh LLF/6WQgmwNogabE+l36EGFFiZ2/IUHELMAn8e5rDytIiYQAr0RHmxBEiYrEpdcvmWBW3X3y nxXC9pDYt/A50wRGxVlIPpuF5JtZSL6ZhbB4ASPLKkax1ILi3PTUYsMCI+S43sQITrhaZjsY J739oHeIkYmD8RCjBAezkgjvUqO3CUK8KYmVValF+fFFpTmpxYcYTYFhPZFZSjQ5H5jy80ri DU2NjI2NLUwMzUwNDZXEeXeyHUoQEkhPLEnNTk0tSC2C6WPi4JRqYGo8dYNB8p9h5up1D7pa u/uaTsRZiNyrSA6tXnt4n3vP2ovxnAeSbp1SrsmM6BfnaeIwd6lYYv/qX6XbwoufV8zJ3f/K ed7ZDKVZhY8NpLN5LrIem76I2e3HtR8WNzflzT66cJoJ14ZPUzN/vKvZKM5U7X1QUrnindmh w3ECgbN23H8SEqj24crHyY/Wycxxr1JzX/rjnNlm4UcvHhw676P139v3uNWpgov38nZsz2kt eStzbpaBQMUdifdXfR9ek373x1hTn5vBSGIDB/O68NtPuPwWFZYefVrjlhi8Sdld9YmB448k QZU/tpFbFl5R33Tr/06G3+/7Ni1qvl3E0FfVWmohnnLvZb7l2g1x7m1KLMUZiYZazEXFiQAe SuEeQQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42LZdlhJTrfny/sEg4ObOCw61x5lt1hx7Q2L xcOr/hYv13QxWSx6tIPVYsGe02wWP1Z9YbU4ue4Dk8XbvZ3sDpwe82adYPFY9V3GY+esu+we m1Z1snmcvbOD0WPywovMHhvf7WDymNtwiymAI4rLJiU1J7MstUjfLoEr49t8y4InyhW/ZsU2 MH6W7WLk5JAQMJF4MqmZvYuRi0NIYAejxO8/E5kgElISn59OZeti5ACyhSUOHy6GqHnLKNG8 uocFpEZYwEdiwf2drCAJEYFtTBJzHrwAa2YWkJBYcug+K4gtJDCZSWLmSmEQm01AR2L7t+Ng NbwCdhLX5vwGs1kEVCUm/3zODGKLCkRKfF7wihWiRlDi5MwnYMs4Bawlvs/7yQIxX13iz7xL zBC2uMStJ/Oh9spLNG+dzTyBUWgWkvZZSFpmIWmZhaRlASPLKkbJ1ILi3PTcYsMCo7zUcr3i xNzi0rx0veT83E2M4BjT0trBuGfVB71DjEwcjIcYJTiYlUR4lxq9TRDiTUmsrEotyo8vKs1J LT7EKM3BoiTOe6HrZLyQQHpiSWp2ampBahFMlomDU6qBSWR6W3Je7t0pobM1Yyr7TJqPPTmd ITdVb2NH9lGruUsT0i433bklvOWFbtIXL/l286D1T5U9qy5wK0b9nXzvatLUdT8m8XGnL1zz tSdwBtsrSf1evU+V2xscz15gmHr7lveVGZsf/S/qqtka8FLSRaF2P1NNXuIrjQffnU/n7DL/ Jbvmnfdqyab2c4ovEyZmPspSu3Ip4YWQ1kF7tSZmxcxPz7naJq6VNr8pWTVHtCa0lZXb96V6 zfMevqnGE08lbTg2d6NB/O6ITcU/L/9ZHBym+6ZG5sm/n+pua3lya9R8FgZVXQqpuV2iznhW evePd+9yHt1QiSiqsVMTNZnQW1lXueviioKaptN99dsXKrEUZyQaajEXFScCAJqI0J0gAwAA X-CMS-MailID: 20210715084044epcas1p12e4676b68ad82cb1d2a258e41c46c4fb X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210715082030epcas1p15dbd7307c8ac4342c31e0db9e4dd0676 References: <20210714143729.2396-1-pali@kernel.org> <20210714143729.2396-3-pali@kernel.org> <90f97347-fadb-6ebb-2705-91b9f8fd4b32@denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Stefan, On 7/15/21 5:20 PM, Stefan Roese wrote: > (added Jaehoon as MMC co-maintainer) > > On 15.07.21 10:03, Stefan Roese wrote: >> On 14.07.21 16:37, Pali Rohár wrote: >>> Add a new 'quiet' argument to mmc_get_op_cond() function which avoids >>> printing error message when SD/eMMC card is not detected. >>> >>> Espressobin and mx6cuboxi boards use this function for detecting presence >>> of eMMC and therefore it is expected and normal that eMMC does not have to >>> be connected. So error message "Card did not respond to voltage select!" >>> should be skipped in this case as it is not an error. >>> >>> Signed-off-by: Pali Rohár >> >> Reviewed-by: Stefan Roese > > Peng, Jaehoon are you okay with this patch? If yes, is it okay that > I will pull it via the marvell tree? I don't have any objection. Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung > > Thanks, > Stefan > >> Thanks, >> Stefan >> >>> --- >>>   board/Marvell/mvebu_armada-37xx/board.c | 2 +- >>>   board/solidrun/mx6cuboxi/mx6cuboxi.c    | 2 +- >>>   drivers/mmc/mmc.c                       | 7 ++++--- >>>   include/mmc.h                           | 3 ++- >>>   4 files changed, 8 insertions(+), 6 deletions(-) >>> >>> diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c >>> index 6086996b8062..fdc873b1952f 100644 >>> --- a/board/Marvell/mvebu_armada-37xx/board.c >>> +++ b/board/Marvell/mvebu_armada-37xx/board.c >>> @@ -124,7 +124,7 @@ int board_late_init(void) >>>       /* eMMC is mmc dev num 1 */ >>>       mmc_dev = find_mmc_device(1); >>> -    emmc = (mmc_dev && mmc_get_op_cond(mmc_dev) == 0); >>> +    emmc = (mmc_dev && mmc_get_op_cond(mmc_dev, true) == 0); >>>       /* if eMMC is not present then remove it from DM */ >>>       if (!emmc && mmc_dev) { >>> diff --git a/board/solidrun/mx6cuboxi/mx6cuboxi.c b/board/solidrun/mx6cuboxi/mx6cuboxi.c >>> index 3eadc38f6fd4..6207bf8253ab 100644 >>> --- a/board/solidrun/mx6cuboxi/mx6cuboxi.c >>> +++ b/board/solidrun/mx6cuboxi/mx6cuboxi.c >>> @@ -374,7 +374,7 @@ static bool has_emmc(void) >>>       mmc = find_mmc_device(2); >>>       if (!mmc) >>>           return 0; >>> -    return (mmc_get_op_cond(mmc) < 0) ? 0 : 1; >>> +    return (mmc_get_op_cond(mmc, true) < 0) ? 0 : 1; >>>   } >>>   int checkboard(void) >>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c >>> index 1e83007286b2..8078a89f18cb 100644 >>> --- a/drivers/mmc/mmc.c >>> +++ b/drivers/mmc/mmc.c >>> @@ -2766,7 +2766,7 @@ static int mmc_power_cycle(struct mmc *mmc) >>>       return mmc_power_on(mmc); >>>   } >>> -int mmc_get_op_cond(struct mmc *mmc) >>> +int mmc_get_op_cond(struct mmc *mmc, bool quiet) >>>   { >>>       bool uhs_en = supports_uhs(mmc->cfg->host_caps); >>>       int err; >>> @@ -2842,7 +2842,8 @@ retry: >>>           if (err) { >>>   #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT) >>> -            pr_err("Card did not respond to voltage select! : %d\n", err); >>> +            if (!quiet) >>> +                pr_err("Card did not respond to voltage select! : %d\n", err); >>>   #endif >>>               return -EOPNOTSUPP; >>>           } >>> @@ -2882,7 +2883,7 @@ int mmc_start_init(struct mmc *mmc) >>>           return -ENOMEDIUM; >>>       } >>> -    err = mmc_get_op_cond(mmc); >>> +    err = mmc_get_op_cond(mmc, false); >>>       if (!err) >>>           mmc->init_in_progress = 1; >>> diff --git a/include/mmc.h b/include/mmc.h >>> index 6f943e78b740..0bf19de20e52 100644 >>> --- a/include/mmc.h >>> +++ b/include/mmc.h >>> @@ -900,9 +900,10 @@ int mmc_set_bkops_enable(struct mmc *mmc); >>>    * the presence of SD/eMMC when no card detect logic is available. >>>    * >>>    * @param mmc    Pointer to a MMC device struct >>> + * @param quiet    Be quiet, do not print error messages when card is not detected. >>>    * @return 0 on success, <0 on error. >>>    */ >>> -int mmc_get_op_cond(struct mmc *mmc); >>> +int mmc_get_op_cond(struct mmc *mmc, bool quiet); >>>   /** >>>    * Start device initialization and return immediately; it does not block on >>> >> >> >> Viele Grüße, >> Stefan >> > > > Viele Grüße, > Stefan >