From: Philipp Zabel <p.zabel@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>, uli@fpond.eu
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Auger Eric <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
KVM list <kvm@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reset: Add reset_control_get_count()
Date: Wed, 14 Nov 2018 10:26:01 +0100 [thread overview]
Message-ID: <1542187561.4095.1.camel@pengutronix.de> (raw)
In-Reply-To: <CAMuHMdV=1GL43ogU3PO6u8x6f2gX-vdgBVON2+t+1QUJtj=Tkg@mail.gmail.com>
On Wed, 2018-11-14 at 09:58 +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 14, 2018 at 7:30 AM Ulrich Hecht <uli@fpond.eu> wrote:
> > On November 13, 2018 at 1:47 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > > Currently the reset core has internal support for counting the number of
> > > resets for a device described in DT. Generalize this to devices using
> > > lookup resets, and export it for public use.
> > >
> > > This will be used by generic drivers that need to be sure a device is
> > > controlled by a single, dedicated reset line (e.g. vfio-platform).
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > See https://lore.kernel.org/lkml/1539003437.11512.20.camel@pengutronix.de/
> > > for the rationale to ensure a single, dedicated reset line.
> > >
> > > drivers/reset/core.c | 41 +++++++++++++++++++++++++++++++++++++++++
> > > include/linux/reset.h | 7 +++++++
> > > 2 files changed, 48 insertions(+)
> > >
> > > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > > index 654e20ff2d5da9d4..c32b755ec373c338 100644
> > > --- a/drivers/reset/core.c
> > > +++ b/drivers/reset/core.c
> > > +/**
> > > + * of_reset_control_get_count - Count number of resets available with a device
> >
> > Should be "reset_control_get_count", without of_ prefix.
>
> Oops, thanks for catching!
>
> Philipp: Do you want a v2 or incremental, or can you fix it up yourself?
No need, I'll fix it up.
thanks
Philipp
next prev parent reply other threads:[~2018-11-14 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 12:47 [PATCH] reset: Add reset_control_get_count() Geert Uytterhoeven
2018-11-13 14:29 ` Philipp Zabel
2018-11-14 6:30 ` Ulrich Hecht
2018-11-14 8:58 ` Geert Uytterhoeven
2018-11-14 9:26 ` Philipp Zabel [this message]
2018-11-14 9:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542187561.4095.1.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@redhat.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=uli@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.