From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C360FC43441 for ; Fri, 16 Nov 2018 10:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 940D220892 for ; Fri, 16 Nov 2018 10:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 940D220892 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389480AbeKPUuy (ORCPT ); Fri, 16 Nov 2018 15:50:54 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:43571 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727615AbeKPUuy (ORCPT ); Fri, 16 Nov 2018 15:50:54 -0500 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 16 Nov 2018 11:39:06 +0100 Received: from [149.44.172.157] (nwb-a10-snat.microfocus.com [10.120.13.202]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Fri, 16 Nov 2018 10:38:57 +0000 Message-ID: <1542364721.3020.5.camel@suse.com> Subject: Re: [PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure From: osalvador To: Michal Hocko , Andrew Morton Cc: Baoquan He , Anshuman Khandual , linux-mm@kvack.org, LKML , Michal Hocko Date: Fri, 16 Nov 2018 11:38:41 +0100 In-Reply-To: <20181116083020.20260-5-mhocko@kernel.org> References: <20181116083020.20260-1-mhocko@kernel.org> <20181116083020.20260-5-mhocko@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-11-16 at 09:30 +0100, Michal Hocko wrote: > From: Michal Hocko > > The memory offlining failure reporting is inconsistent and > insufficient. > Some error paths simply do not report the failure to the log at all. > When we do report there are no details about the reason of the > failure > and there are several of them which makes memory offlining failures > hard to debug. > > Make sure that the > memory offlining [mem %#010llx-%#010llx] failed > message is printed for all failures and also provide a short textual > reason for the failure e.g. > > [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000- > 0x8267fffffff] failed due to signal backoff > > this tells us that the offlining has failed because of a signal > pending > aka user intervention. > > [akpm: tweak messages a bit] > Signed-off-by: Michal Hocko Reviewed-by: Oscar Salvador