From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC93EC43441 for ; Mon, 26 Nov 2018 05:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD77F20855 for ; Mon, 26 Nov 2018 05:30:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD77F20855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbeKZQX3 (ORCPT ); Mon, 26 Nov 2018 11:23:29 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:27251 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726145AbeKZQX2 (ORCPT ); Mon, 26 Nov 2018 11:23:28 -0500 X-UUID: 322d924fc63448108ea5f03f7d6d5ce9-20181126 X-UUID: 322d924fc63448108ea5f03f7d6d5ce9-20181126 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1253449590; Mon, 26 Nov 2018 13:30:02 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 26 Nov 2018 13:29:59 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 26 Nov 2018 13:29:59 +0800 Message-ID: <1543210200.1796.2.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: Only try to attach bridge if there is one From: CK Hu To: Nicolas Boichat CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , Date: Mon, 26 Nov 2018 13:30:00 +0800 In-Reply-To: <20181126040737.138682-1-drinkcat@chromium.org> References: <20181126040737.138682-1-drinkcat@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 0A7AF0185B64A501D509B3774DF140A431209166BDD2867CD57FF28CC137D2382000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Nicolas: On Mon, 2018-11-26 at 12:07 +0800, Nicolas Boichat wrote: > Even if dsi->bridge is NULL, we still try to call drm_bridge_attach, > and print out an error message, before creating the connector. > > When no bridge is provided, let's skip these 2 steps and directly > create the connector. Reviewed-by: CK Hu > > Signed-off-by: Nicolas Boichat > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 66df1b17795921..27b507eb4a997d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -818,10 +818,13 @@ static int mtk_dsi_create_conn_enc(struct drm_device *drm, struct mtk_dsi *dsi) > dsi->encoder.possible_crtcs = 1; > > /* If there's a bridge, attach to it and let it create the connector */ > - ret = drm_bridge_attach(&dsi->encoder, dsi->bridge, NULL); > - if (ret) { > - DRM_ERROR("Failed to attach bridge to drm\n"); > - > + if (dsi->bridge) { > + ret = drm_bridge_attach(&dsi->encoder, dsi->bridge, NULL); > + if (ret) { > + DRM_ERROR("Failed to attach bridge to drm\n"); > + goto err_encoder_cleanup; > + } > + } else { > /* Otherwise create our own connector and attach to a panel */ > ret = mtk_dsi_create_connector(drm, dsi); > if (ret) From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH] drm/mediatek: Only try to attach bridge if there is one Date: Mon, 26 Nov 2018 13:30:00 +0800 Message-ID: <1543210200.1796.2.camel@mtksdaap41> References: <20181126040737.138682-1-drinkcat@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181126040737.138682-1-drinkcat@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicolas Boichat Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIE5pY29sYXM6CgpPbiBNb24sIDIwMTgtMTEtMjYgYXQgMTI6MDcgKzA4MDAsIE5pY29sYXMg Qm9pY2hhdCB3cm90ZToKPiBFdmVuIGlmIGRzaS0+YnJpZGdlIGlzIE5VTEwsIHdlIHN0aWxsIHRy eSB0byBjYWxsIGRybV9icmlkZ2VfYXR0YWNoLAo+IGFuZCBwcmludCBvdXQgYW4gZXJyb3IgbWVz c2FnZSwgYmVmb3JlIGNyZWF0aW5nIHRoZSBjb25uZWN0b3IuCj4gCj4gV2hlbiBubyBicmlkZ2Ug aXMgcHJvdmlkZWQsIGxldCdzIHNraXAgdGhlc2UgMiBzdGVwcyBhbmQgZGlyZWN0bHkKPiBjcmVh dGUgdGhlIGNvbm5lY3Rvci4KClJldmlld2VkLWJ5OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29t PgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNvbGFzIEJvaWNoYXQgPGRyaW5rY2F0QGNocm9taXVt Lm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kc2kuYyB8IDExICsr KysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHNpLmMg Yi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jCj4gaW5kZXggNjZkZjFiMTc3OTU5 MjEuLjI3YjUwN2ViNGE5OTdkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl ay9tdGtfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jCj4g QEAgLTgxOCwxMCArODE4LDEzIEBAIHN0YXRpYyBpbnQgbXRrX2RzaV9jcmVhdGVfY29ubl9lbmMo c3RydWN0IGRybV9kZXZpY2UgKmRybSwgc3RydWN0IG10a19kc2kgKmRzaSkKPiAgCWRzaS0+ZW5j b2Rlci5wb3NzaWJsZV9jcnRjcyA9IDE7Cj4gIAo+ICAJLyogSWYgdGhlcmUncyBhIGJyaWRnZSwg YXR0YWNoIHRvIGl0IGFuZCBsZXQgaXQgY3JlYXRlIHRoZSBjb25uZWN0b3IgKi8KPiAtCXJldCA9 IGRybV9icmlkZ2VfYXR0YWNoKCZkc2ktPmVuY29kZXIsIGRzaS0+YnJpZGdlLCBOVUxMKTsKPiAt CWlmIChyZXQpIHsKPiAtCQlEUk1fRVJST1IoIkZhaWxlZCB0byBhdHRhY2ggYnJpZGdlIHRvIGRy bVxuIik7Cj4gLQo+ICsJaWYgKGRzaS0+YnJpZGdlKSB7Cj4gKwkJcmV0ID0gZHJtX2JyaWRnZV9h dHRhY2goJmRzaS0+ZW5jb2RlciwgZHNpLT5icmlkZ2UsIE5VTEwpOwo+ICsJCWlmIChyZXQpIHsK PiArCQkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gYXR0YWNoIGJyaWRnZSB0byBkcm1cbiIpOwo+ICsJ CQlnb3RvIGVycl9lbmNvZGVyX2NsZWFudXA7Cj4gKwkJfQo+ICsJfSBlbHNlIHsKPiAgCQkvKiBP dGhlcndpc2UgY3JlYXRlIG91ciBvd24gY29ubmVjdG9yIGFuZCBhdHRhY2ggdG8gYSBwYW5lbCAq Lwo+ICAJCXJldCA9IG10a19kc2lfY3JlYXRlX2Nvbm5lY3Rvcihkcm0sIGRzaSk7Cj4gIAkJaWYg KHJldCkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Mon, 26 Nov 2018 13:30:00 +0800 Subject: [PATCH] drm/mediatek: Only try to attach bridge if there is one In-Reply-To: <20181126040737.138682-1-drinkcat@chromium.org> References: <20181126040737.138682-1-drinkcat@chromium.org> Message-ID: <1543210200.1796.2.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Nicolas: On Mon, 2018-11-26 at 12:07 +0800, Nicolas Boichat wrote: > Even if dsi->bridge is NULL, we still try to call drm_bridge_attach, > and print out an error message, before creating the connector. > > When no bridge is provided, let's skip these 2 steps and directly > create the connector. Reviewed-by: CK Hu > > Signed-off-by: Nicolas Boichat > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 66df1b17795921..27b507eb4a997d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -818,10 +818,13 @@ static int mtk_dsi_create_conn_enc(struct drm_device *drm, struct mtk_dsi *dsi) > dsi->encoder.possible_crtcs = 1; > > /* If there's a bridge, attach to it and let it create the connector */ > - ret = drm_bridge_attach(&dsi->encoder, dsi->bridge, NULL); > - if (ret) { > - DRM_ERROR("Failed to attach bridge to drm\n"); > - > + if (dsi->bridge) { > + ret = drm_bridge_attach(&dsi->encoder, dsi->bridge, NULL); > + if (ret) { > + DRM_ERROR("Failed to attach bridge to drm\n"); > + goto err_encoder_cleanup; > + } > + } else { > /* Otherwise create our own connector and attach to a panel */ > ret = mtk_dsi_create_connector(drm, dsi); > if (ret)