All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Rapeli <mikko.rapeli@bmw.de>
To: openembedded-core@lists.openembedded.org
Cc: Michael.Ho@bmw.de
Subject: [PATCH 5/5] insane.bbclass: add package specific skips to sstate hash
Date: Thu, 29 Nov 2018 14:21:37 +0200	[thread overview]
Message-ID: <1543494097-19534-6-git-send-email-mikko.rapeli@bmw.de> (raw)
In-Reply-To: <1543494097-19534-1-git-send-email-mikko.rapeli@bmw.de>

From: Michael Ho <Michael.Ho@bmw.de>

The bbclass currently adds INSANE_SKIP to the sstate hash dependencies
however the package specific skips such as INSANE_SKIP_${PN} are
not added automatically because of how the class references them.

This causes the problem that modifying INSANE_SKIP_${PN} does not
invalidate the sstate cache and can mask build breaking warnings.

Add an anonymous python snippet to explicitly include these additional
relevant skips to the sstate hash.

Singed-off-by: Michael Ho <Michael.Ho@bmw.de>
---
 meta/classes/insane.bbclass | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 4644221..e015c94 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1017,6 +1017,13 @@ do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
 do_package_qa[rdeptask] = "do_packagedata"
 addtask do_package_qa after do_packagedata do_package before do_build
 
+# Add the package specific INSANE_SKIPs to the sstate dependencies
+python() {
+    pkgs = (d.getVar('PACKAGES') or '').split()
+    for pkg in pkgs:
+        d.appendVarFlag("do_package_qa", "vardeps", " INSANE_SKIP_{}".format(pkg))
+}
+
 SSTATETASKS += "do_package_qa"
 do_package_qa[sstate-inputdirs] = ""
 do_package_qa[sstate-outputdirs] = ""
-- 
1.9.1



  parent reply	other threads:[~2018-11-29 12:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 12:21 [PATCH 0/5] various fixes Mikko Rapeli
2018-11-29 12:21 ` [PATCH 1/5] RFC image_types.bbclass: add image size limit for tar image type Mikko Rapeli
2018-11-29 14:04   ` Richard Purdie
2018-11-29 14:17     ` Mikko.Rapeli
2018-11-29 15:21       ` Christopher Larson
2018-11-29 16:34       ` richard.purdie
2018-11-29 12:21 ` [PATCH 2/5] bitbake: fetch2/svn: Fix SVN repository concurrent update race Mikko Rapeli
2018-11-29 12:21 ` [PATCH 3/5] cmake.bbclass: append includedir to implicit include dirs Mikko Rapeli
2019-07-11  2:51   ` Douglas Royds
2019-07-11  4:55     ` Douglas Royds
2018-11-29 12:21 ` [PATCH 4/5] sstate: add support for caching shared workdir tasks Mikko Rapeli
2018-11-29 12:21 ` Mikko Rapeli [this message]
2018-11-29 13:33 ` ✗ patchtest: failure for various fixes Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1543494097-19534-6-git-send-email-mikko.rapeli@bmw.de \
    --to=mikko.rapeli@bmw.de \
    --cc=Michael.Ho@bmw.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.