From: no-reply@patchew.org
To: ehabkost@redhat.com
Cc: famz@redhat.com, qemu-devel@nongnu.org, mst@redhat.com,
kwolf@redhat.comfamz@redhat.com, marcel.apfelbaum@gmail.com,
amit@kernel.org, libvir-list@redhat.com, jasowang@redhat.com,
cohuck@redhat.com, abologna@redhat.com, wainersm@redhat.com,
mreitz@redhat.com, ccarrara@redhat.com, arei.gonglei@huawei.com,
laine@redhat.com, kraxel@redhat.com, stefanha@redhat.com,
crosa@redhat.com, pbonzini@redhat.com, philmd@redhat.com
Subject: Re: [Qemu-devel] [libvirt] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices
Date: Wed, 5 Dec 2018 13:42:06 -0800 (PST) [thread overview]
Message-ID: <154404612326.2740.10680987050091612104@bb8f5089e434> (raw)
In-Reply-To: <20181205195704.17605-1-ehabkost@redhat.com>
Patchew URL: https://patchew.org/QEMU/20181205195704.17605-1-ehabkost@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181205195704.17605-1-ehabkost@redhat.com
Subject: [libvirt] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
486a758 virtio: Provide version-specific variants of virtio PCI devices
85361d9 virtio: Helper for registering virtio device types
=== OUTPUT BEGIN ===
Checking PATCH 1/2: virtio: Helper for registering virtio device types...
WARNING: line over 80 characters
#496: FILE: hw/virtio/virtio-pci.h:443:
+ * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE,
WARNING: line over 80 characters
#505: FILE: hw/virtio/virtio-pci.h:452:
+ * Implements both INTERFACE_PCIE_DEVICE and INTERFACE_CONVENTIONAL_PCI_DEVICE.
total: 0 errors, 2 warnings, 469 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: virtio: Provide version-specific variants of virtio PCI devices...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#316:
new file mode 100644
ERROR: line over 90 characters
#372: FILE: tests/acceptance/virtio_version.py:52:
+ return devtype in [d['name'] for d in vm.command('qom-list-types', implements=implements)]
WARNING: line over 80 characters
#427: FILE: tests/acceptance/virtio_version.py:107:
+ dev_1_0, nt_ifaces = self.run_device('%s-non-transitional' % (qemu_devtype))
WARNING: line over 80 characters
#451: FILE: tests/acceptance/virtio_version.py:131:
+ dev_trans, trans_ifaces = self.run_device('%s-transitional' % (qemu_devtype))
total: 1 errors, 3 warnings, 404 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20181205195704.17605-1-ehabkost@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2018-12-05 23:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 19:57 [Qemu-devel] [PATCH for-4.0 v4 0/2] virtio: Provide version-specific variants of virtio PCI devices Eduardo Habkost
2018-12-05 19:57 ` [Qemu-devel] [PATCH for-4.0 v4 1/2] virtio: Helper for registering virtio device types Eduardo Habkost
2018-12-05 19:57 ` [Qemu-devel] [PATCH for-4.0 v4 2/2] virtio: Provide version-specific variants of virtio PCI devices Eduardo Habkost
2018-12-07 12:03 ` Caio Carrara
2019-01-03 9:38 ` Thomas Huth
2019-01-03 10:14 ` Thomas Huth
2019-01-03 10:48 ` Cornelia Huck
2019-01-03 18:32 ` Eduardo Habkost
2019-01-04 4:27 ` Michael S. Tsirkin
2019-01-04 8:27 ` Cornelia Huck
2018-12-05 21:42 ` no-reply [this message]
2018-12-12 1:18 ` [Qemu-devel] [PATCH for-4.0 v4 0/2] " Eduardo Habkost
2018-12-12 1:22 ` Michael S. Tsirkin
2019-03-05 12:09 ` Andrea Bolognani
2019-03-05 14:38 ` Gerd Hoffmann
2019-03-05 15:56 ` Andrea Bolognani
2019-03-06 7:41 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-03-06 8:30 ` Ján Tomko
2019-03-06 9:08 ` Andrea Bolognani
2019-03-06 9:10 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154404612326.2740.10680987050091612104@bb8f5089e434 \
--to=no-reply@patchew.org \
--cc=ehabkost@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.comfamz \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.