From: Qian Cai <cai@lca.pw>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkstack.pl: fix for aarch64
Date: Fri, 07 Dec 2018 15:46:54 -0500 [thread overview]
Message-ID: <1544215614.18411.1.camel@lca.pw> (raw)
In-Reply-To: <20181207122434.efb1941a3ded73267496c784@linux-foundation.org>
On Fri, 2018-12-07 at 12:24 -0800, Andrew Morton wrote:
> On Fri, 7 Dec 2018 14:58:43 -0500 Qian Cai <cai@lca.pw> wrote:
>
> > There is actually a space after "sp," like this,
> >
> > ffff2000080813c8: a9bb7bfd stp x29, x30, [sp, #-80]!
> >
>
> Confused. Why does this matter? Why is the patched version superior?
<Resend in plain text.>
Right now, checkstack.pl won’t be able to print anything on aarch64, because it
won’t be able to match the stating objdump line of a function due to this
missing space. Hence, it saw every stack is zero-size.
After applied this patch, checkpatch.pl is able to match the start of a
function’s objdump, and then be able to calculate each function’s stack
correctly.
prev parent reply other threads:[~2018-12-07 20:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 19:58 [PATCH] checkstack.pl: fix for aarch64 Qian Cai
2018-12-07 20:24 ` Andrew Morton
2018-12-07 20:46 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544215614.18411.1.camel@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.