From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mus2P-0007Vu-LJ for mharc-grub-devel@gnu.org; Wed, 08 Dec 2021 03:10:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mus2G-0007VQ-96 for grub-devel@gnu.org; Wed, 08 Dec 2021 03:10:44 -0500 Received: from mout.gmx.net ([212.227.15.18]:40969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mus2D-0000qb-E7 for grub-devel@gnu.org; Wed, 08 Dec 2021 03:10:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638951035; bh=kSJ/OE0OkKikifEPeZaw9x0AXA4JvHbQVGeyb3VFbZ4=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=B4biF/E2v8ndj+Az0bPOCZjxm99AFRwWHBqZ7F+iUN1k05Yrk5p1BtLPx9q6DlJk+ vSHZcqGPbaR1UTZbsKwvwU1sUnRf5ZA/LYoWcz3hSRoYa8f3mYC0u17GAi0AMvRCAw 7D0GdvMtf7UwdLWZVI2sKpx65V32MZDphD/91AH4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.243.172]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N49lD-1mUmao1JNB-0106wL; Wed, 08 Dec 2021 09:10:35 +0100 Date: Wed, 08 Dec 2021 09:11:07 +0100 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH] tests: Refactor building xorriso command for iso9660 tests Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dkiper@net-space.pl,development@efficientek.com References: <20211208064051.980395-1-development@efficientek.com> In-Reply-To: <20211208064051.980395-1-development@efficientek.com> Message-Id: <15442353715111753079@scdbackup.webframe.org> X-Provags-ID: V03:K1:uIkCQMEOXKGAlTkwuRyJ+gfPEC+DfuqIoVjKvmO3uHB+oR2nZFM 0ceAWI4rb94CIjnIMw08BN4VZ/gWR7RPADa7OKREXKGDce1nNFHgi+lhMARZ9Q7RQz0Qmo6 CRPpfaciDrQ6aw1oQtfHh1MU2POtj60QB/cIJlDEZAyZeVirrmSdSDAw9a6Py5799wbg7Wy EtgiFsWgbWFAK5zwPqIKQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:NZYSbBAISlQ=:2GRjbnSfslddibpLmg6dV5 UikUEkX4d49Uc6z148NBE/nZsZ1CFnoS9fWgN5KmytKe3BvVwjE5n9+giVDH9ZKBFEcZ4gRcf BmMzw+hF+TFirJ/OjGRjFhyTvNvJSabgYDyUMjK4Il/l+cvtb8m3HebYlowH+iytJg1HWfXKV hnqMgLCdQCeDHsKaWR21DzXV3V1wWiLFYT2f/u/ktynFrkMwu7SE+BI1I1oRluwc5aV8owDdW GR7Bv0xCUKAoVhHB1KC907NwAjMweliKRiqdqVIGPMCB+sJlwz8aZJeukevgClum5yoS0zj+i zV/N9awaPnGSYKAteXvJZmGmJum1UNsp2eDyuKdT/mmTKfeWR+bqsV9VSybZnJDGR/UwI332T +I+jKdpI4CPprs+dH/sWmbATz1TKvJNbPUG2PDYwovQOXf+5xiVJmL2LotYyZki9kJsM78B7W bx+ozKlUkBcNaK0uvH7KyFXM82GBNBV9I4kR361XeicsgvpBa45rJL3sq8mTGZqLIeaSwoPZn UGm57OF4t/j3UA7Mhq0YmasBM5gx/oLs9pvYZN3+erCam+ePjHHPjW1DFM6m2rJ1jF0bIO9fI PLEN590Br6avjlSLkWhUhWjrGUukVDfIrVirOmVyZ36l9MXUtJ5uoe6qBnW3w/t1S8YQ/KuU3 OqTeAgNE6zTn+sxQ6u9mH9j889V0IqAeKfC7s4ba2xwB86DSgoGWdxHfxru5AVq+2rtKBYf87 6HstrRvbsmZEZN2s91/saXUPmS56+GMgzq7TnS4UPWRT/jX6MKndPhIh7NLZRsOMkBRCLMaz/ 536J9vusJpTbM0VBO7siW0i9+bUZXV1kTrXmfGYGG5lhjVP3lxCyog9KnEHJejBO21gP8EnNp QGFBZ/pAM7TSxOjbgXJRaYcn6aL5nFZRoT1WFmImMwy1vDhZNW0Tv/asQqW0smWpuhGsP1IEn iBJHAGDlNyz/yU8nRsfPkrD6io9jnccgwpffg7Aw4Bxl/0s26haiy6atd1YiUf37hR+132wJb XvnsqpFIr3Cg7DKjQbzdwaN83w2arQBZTzsmpLpAB7L3sraUBQIeLkjqU7J48LsHV34INYYgU AGTgOkyRtWwU6A= Received-SPF: pass client-ip=212.227.15.18; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 08:10:44 -0000 Hi, i think this change is beneficial for the maintainability of the test. But this sequence looks a bit confusing, albeit it is ok on the second glimpse: + XORRISO_ARGS=3D"-as mkisofs $XORRISOFS_CHARSET -graft-= points" + + if [ -z "${fs##*rockridge*}" ]; then + XORRISO_ARGS=3D"-rockridge on $XORRISO_ARGS" + else + XORRISO_ARGS=3D"-rockridge off $XORRISO_ARGS" + fi + + if [ -z "${fs##*1999*}" ]; then + XORRISO_ARGS=3D"$XORRISO_ARGS -iso-level 4" + else + XORRISO_ARGS=3D"$XORRISO_ARGS -iso-level 3" + fi It is essential here, but not really obvious, that the native command -rockridge "on"|"off" must be _prepended_ to XORRISO_ARGS whereas the mkisofs emulation options must be _appended_ to the variable content. If not, then the xorriso run would fail: $ xorriso -as mkisofs -rockridge on ... xorriso : FAILURE : -as mkisofs: Unrecognized option '-rockridge' xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' $ xorriso -iso-level 4 -as mkisofs ... xorriso : FAILURE : Not a known command: '-iso-level' xorriso : FAILURE : Not a known command: '4' xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE' $ It would be more intuitive to build XORRISO_ARGS in the sequence that will be seen by xorriso. So consider to pull -compliance "rec_mtime" into XORRISO_ARGS too, and to set the native commands before the -as "mkisofs" command. Like: XORRISO_ARGS=3D"-compliance rec_mtime" if [ -z "${fs##*rockridge*}" ]; then XORRISO_ARGS=3D"$XORRISO_ARGS -rockridge on" else XORRISO_ARGS=3D"$XORRISO_ARGS -rockridge off" fi XORRISO_ARGS=3D"$XORRISO_ARGS -as mkisofs $XORRISOFS_CH= ARSET -graft-points" if [ -z "${fs##*1999*}" ]; then XORRISO_ARGS=3D"$XORRISO_ARGS -iso-level 4" else XORRISO_ARGS=3D"$XORRISO_ARGS -iso-level 3" fi if [ -z "${fs##*joliet*}" ]; then XORRISO_ARGS=3D"$XORRISO_ARGS -J -joliet-long" fi xorriso $XORRISO_ARGS -V "$FSLABEL" --modification-date= =3D$(echo ${FSUUID} | sed 's/-//g;') -o "${FSIMAGEP}0.img" /=3D"$MASTER" ;= ; Have a nice day :) Thomas