From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 1/5] xfs/111: fix golden output
Date: Tue, 18 Dec 2018 12:35:50 -0800 [thread overview]
Message-ID: <154516535027.31115.4827015654233888092.stgit@magnolia> (raw)
In-Reply-To: <154516534392.31115.7010578395334646479.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
In commit f4eee5126, this test was changed to run xfs_fsr to bulkstat
its way through the filesystem until it finds the corrupt inode. The
golden output was changed to capture xfs_fsr's output, but neglects the
fact that when fsr's output is not a tty, all the status and error
messages are sent to syslog, not stdout. Therefore, this test
consistently fails because it expects output of "$SCRATCH_MNT start
inode=0" but this never appears.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/111 | 2 +-
tests/xfs/111.out | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/xfs/111 b/tests/xfs/111
index 2ef69f07..965eb625 100755
--- a/tests/xfs/111
+++ b/tests/xfs/111
@@ -58,7 +58,7 @@ _try_scratch_mount || _fail "Couldn't mount after itrash"
echo Attempting bulkstat
#src/bstat -q $SCRATCH_MNT
-$XFS_FSR_PROG $SCRATCH_MNT | _filter_scratch
+$XFS_FSR_PROG -g $SCRATCH_MNT | _filter_scratch
# Fix up intentional corruption so test can pass
_scratch_unmount
diff --git a/tests/xfs/111.out b/tests/xfs/111.out
index fd56c3c8..41fa48f8 100644
--- a/tests/xfs/111.out
+++ b/tests/xfs/111.out
@@ -10,4 +10,3 @@ Blat inode clusters
Starting overwrite
Overwrite complete
Attempting bulkstat
-SCRATCH_MNT start inode=0
next prev parent reply other threads:[~2018-12-18 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 20:35 [PATCH 0/5] fstests: fix various problems Darrick J. Wong
2018-12-18 20:35 ` Darrick J. Wong [this message]
2018-12-18 20:35 ` [PATCH 2/5] xfs/123: fix remote symlink block size calculation Darrick J. Wong
2018-12-18 20:36 ` [PATCH 3/5] generic/050: fix ro blockdev mount of xfs with quota Darrick J. Wong
2018-12-18 20:36 ` [PATCH 4/5] xfs: look for stringified constants in ftrace formats Darrick J. Wong
2018-12-18 20:36 ` [PATCH 5/5] xfs: filter out mount options that don't work on v4 filesystems Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154516535027.31115.4827015654233888092.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.